[webgpu] Refactors CommandBufferClient interface. [chromium/src : main]

0 views
Skip to first unread message

Loko Kung (Gerrit)

unread,
Nov 12, 2025, 5:33:53 PMNov 12
to Stephen Chenney, chromium...@chromium.org, Dirk Schulze, kinuko...@chromium.org, jmedle...@chromium.org, drott+bl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, cwalle...@chromium.org, kainin...@chromium.org, blink-reviews-p...@chromium.org

Loko Kung has uploaded the change for review

Commit message

[webgpu] Refactors CommandBufferClient interface.

- Creates a separate CommandBufferClientMessageFilter object when
  the callback task runner is different than the sequence that creates
  the CommandBufferProxyImpl. This is important to ensure that we
  avoid races on teardown where the CommandBufferProxyImpl may be gone
  and the other sequence may still have pending tasks to complete.
- This change reflects how the GpuChannel and it's corresponding
  GpuChannelMessageFilter accomplishes the same thing.
Bug: 441981783
Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51

Change diff


Change information

Files:
  • M gpu/ipc/client/command_buffer_proxy_impl.cc
  • M gpu/ipc/client/command_buffer_proxy_impl.h
Change size: M
Delta: 2 files changed, 133 insertions(+), 8 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51
Gerrit-Change-Number: 7148764
Gerrit-PatchSet: 1
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Loko Kung (Gerrit)

unread,
Dec 2, 2025, 2:53:58 AMDec 2
to Sunny Sachanandani, Victor Miura, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Sunny Sachanandani and Victor Miura

Loko Kung voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sunny Sachanandani
  • Victor Miura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51
Gerrit-Change-Number: 7148764
Gerrit-PatchSet: 8
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Reviewer: Victor Miura <vmi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Attention: Victor Miura <vmi...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Dec 2025 07:53:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Miura (Gerrit)

unread,
Dec 2, 2025, 11:00:43 AMDec 2
to Loko Kung, Sunny Sachanandani, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Loko Kung and Sunny Sachanandani

Victor Miura added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Victor Miura . resolved

sunnyps@, this is more in your wheelhouse so I will defer to you as primary reviewer here. thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Loko Kung
  • Sunny Sachanandani
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51
Gerrit-Change-Number: 7148764
Gerrit-PatchSet: 8
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Reviewer: Victor Miura <vmi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Sunny Sachanandani <sun...@chromium.org>
Gerrit-Attention: Loko Kung <loko...@google.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 16:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Miura (Gerrit)

unread,
Dec 2, 2025, 2:56:11 PMDec 2
to Loko Kung, Sunny Sachanandani, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Loko Kung and Sunny Sachanandani

Victor Miura added 1 comment

Patchset-level comments
Victor Miura . resolved

I just remembered that Sunny is out and won't be able to review this. I will take a look asap but not today (GRAD).

Gerrit-Comment-Date: Tue, 02 Dec 2025 19:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kai Ninomiya (Gerrit)

unread,
Dec 5, 2025, 7:37:10 PMDec 5
to Loko Kung, Code Review Nudger, Victor Miura, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Loko Kung

Kai Ninomiya added 2 comments

Patchset-level comments
Kai Ninomiya . resolved

On second thought I am probably not a very useful reviewer for this code. Seems good to me though.

File gpu/ipc/client/command_buffer_proxy_impl.cc
Line 83, Patchset 8 (Latest): raw_ptr<CommandBufferProxyImpl> proxy_ GUARDED_BY(proxy_lock_) = nullptr;
Kai Ninomiya . resolved

This macro would be helpful in Dawn...

Open in Gerrit

Related details

Attention is currently required from:
  • Loko Kung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51
Gerrit-Change-Number: 7148764
Gerrit-PatchSet: 8
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-Reviewer: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Victor Miura <vmi...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Loko Kung <loko...@google.com>
Gerrit-Comment-Date: Sat, 06 Dec 2025 00:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Loko Kung (Gerrit)

unread,
Dec 18, 2025, 12:58:49 PM (2 days ago) Dec 18
to Daniel Cheng, Kai Ninomiya, Code Review Nudger, Victor Miura, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng

Loko Kung added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Loko Kung . resolved

Bumping and adding Daniel since he had some context on the previous iteration/changes that Sunny made for this.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51
Gerrit-Change-Number: 7148764
Gerrit-PatchSet: 10
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-Reviewer: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Victor Miura <vmi...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 17:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Miura (Gerrit)

unread,
Dec 19, 2025, 6:32:12 PM (14 hours ago) Dec 19
to Loko Kung, Daniel Cheng, Kai Ninomiya, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng and Loko Kung

Victor Miura voted and added 1 comment

Votes added by Victor Miura

Code-Review+1

1 comment

Patchset-level comments
Victor Miura . resolved

LGTM, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Loko Kung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0114b6d6c60ed737bc87c28e19942362705b6b51
Gerrit-Change-Number: 7148764
Gerrit-PatchSet: 10
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-Reviewer: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Victor Miura <vmi...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Loko Kung <loko...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 23:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages