[Blink] Fold inner class into CanvasSnapshotProviderExternalBitmap [chromium/src : main]

0 views

Skip to first unread message

Florin Malita (Gerrit)

unread,

Dec 16, 2025, 10:55:29 AM (4 days ago) Dec 16

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Attention needed from Colin Blundell

Florin Malita voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 17, 2025, 2:54:04 AM (3 days ago) Dec 17

to Colin Blundell, Florin Malita, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Blink] Fold inner class into CanvasSnapshotProviderExternalBitmap

The abstraction here is unnecessary, and we are looking to streamline
this code as much as possible with the eventual goal of reducing
CSPExternalBitmap itself to a static helper.

Bug: 352263194

Change-Id: I4924e6387823510438655f999eac73527dc11203

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7260443

Reviewed-by: Florin Malita <fma...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1559772}

Files:

M third_party/blink/renderer/platform/graphics/canvas_snapshot_provider_external_bitmap.cc
M third_party/blink/renderer/platform/graphics/canvas_snapshot_provider_external_bitmap.h

Change size: M

Delta: 2 files changed, 53 insertions(+), 65 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Florin Malita

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages