Assign unique id to mouse pointer [chromium/src : main]

0 views
Skip to first unread message

Robert Flack (Gerrit)

unread,
Apr 17, 2024, 10:38:02 AMApr 17
to Sahir Vellani, Christian Biesinger, Charlie Hu, Xida Chen, Chromium Metrics Reviews, Daniel Andersson, Peter Beverloo, Rijubrata Bhaumik, Nico Weber, Enterprise Policy Reviews, Sam Zackrisson, Nate Chapin, Per Åhgren, Henrique Ferreiro, Dirk Schulze, Peter Williamson, Sadrul Chowdhury, Hongchan Choi, Alexis Menard, Kentaro Hara, Ilya Biryukov, Jiewei Qian, Wanming Lin, Peter Collingbourne, James Su, Sam Clegg, David Bokan, Mathias Bynens, David Worsham, Robert Kroeger, Ale Bzk, Mirko Bonadei, Fredrik Söderquist, Jerome Jiang, Lei Zhang, Ian Vollick, Zijie He, Yoav Weiss (@Shopify), Sina Firoozabadi, Hans Wennborg, Hiroki Nakagawa, Tommy Li, Kaan Icer, W. James Maclean, Giovanni Ortuno Urquidi, Stephen Chenney, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Javier Fernandez, Simon Hangl, Alvin Ji, Mike Taylor, Raphael Kubo Da Costa, srirama chandra sekhar, Nektarios Paisios, Victor Tan, Nancy Wang, Kevin Babbitt, Reid Kleckner, Daniel Cheng, AyeAye, Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, rouslan+...@chromium.org, tburkar...@chromium.org, tsergea...@chromium.org, jz...@chromium.org, vinnypersky+...@google.com, anastas...@google.com, cclem+wat...@google.com, dominicc+...@chromium.org, performance-m...@chromium.org, fgorsk...@chromium.org, kinuko+...@chromium.org, ajayramamurthy...@google.com, rsesek...@chromium.org, robertshi...@chromium.org, yfriedm...@chromium.org, shimazu+se...@chromium.org, shend...@chromium.org, cros-essential...@chromium.org, blink-rev...@chromium.org, devtools...@chromium.org, dominickn+...@chromium.org, jiajunz+wa...@google.com, agriev...@chromium.org, pushi+wat...@google.com, dmurph+wat...@chromium.org, csharris...@chromium.org, andreaor...@chromium.org, katie...@chromium.org, siyua+aut...@chromium.org, caitkp...@chromium.org, eric.c...@apple.com, torne...@chromium.org, abigailbk...@google.com, blink-revie...@chromium.org, blink-revi...@chromium.org, dtseng+c...@chromium.org, jdh+wat...@chromium.org, chrome-mem...@google.com, dtapuska+ch...@chromium.org, tmartino+tran...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, chromeos-ca...@google.com, ryanchu...@chromium.org, crost...@chromium.org, wanderview...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, loyso...@chromium.org, yuezhang...@chromium.org, xlythe+wa...@google.com, cros-report...@google.com, dtseng...@chromium.org, ender...@chromium.org, michaelpg+wa...@chromium.org, video-networking...@google.com, jackshira+wat...@google.com, dimich...@chromium.org, pdf-r...@chromium.org, multipaste-...@google.com, shgar+aut...@google.com, asvitkine...@chromium.org, alexmo...@chromium.org, martijn...@martijnc.be, dmurph+watch...@chromium.org, pasko...@chromium.org, mattreyno...@chromium.org, tbarzi...@chromium.org, ios-revie...@chromium.org, xiaohui...@chromium.org, boujane+watch-...@google.com, dmurph+watching...@chromium.org, media-wi...@chromium.org, wychen...@chromium.org, blink-work...@chromium.org, scheduler-...@chromium.org, zentaro+sca...@chromium.org, ajayramamu...@google.com, chadduffin+w...@chromium.org, dullweber+watch...@chromium.org, mxcai+watch...@chromium.org, shannc...@chromium.org, rkgibso...@chromium.org, wfh+...@chromium.org, dpr...@google.com, tote-eng...@google.com, bcb+watch-pl...@chromium.org, emi...@google.com, jessemcke...@google.com, cclem+wat...@google.com, devtools-re...@chromium.org, droger+w...@chromium.org, steimel+...@chromium.org, chromium-...@engflow.com, wittma...@chromium.org, haoliu...@chromium.org, jonmann+watc...@chromium.org, pushi+wa...@google.com, chikamu...@chromium.org, aleventhal...@chromium.org, yuzo+...@chromium.org, gavinwill+sc...@chromium.org, glenro...@chromium.org, msrame...@chromium.org, wnwen+w...@chromium.org, blink-revie...@chromium.org, shuche...@chromium.org, ydago...@chromium.org, wiss+watc...@chromium.org, davidj...@chromium.org, hansberry+w...@chromium.org, feature-v...@chromium.org, olesiamaru...@google.com, andrewxu+wat...@google.com, minap+watch-p...@google.com, hidehik...@chromium.org, hayato...@chromium.org, nburris+pa...@chromium.org, creis...@chromium.org, michaelpg+wa...@chromium.org, sky+...@chromium.org, pdr+svgw...@chromium.org, alimariam+watch...@google.com, print-rev...@chromium.org, xhwang...@chromium.org, gbiv+...@chromium.org, tommyw+w...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, chasej...@chromium.org, twelling...@chromium.org, feature-me...@chromium.org, lingqi...@chromium.org, media-cro...@chromium.org, pmonett...@chromium.org, michaelcheco+watch-i...@google.com, zackha...@chromium.org, twifka...@chromium.org, gbb-cct...@google.com, dominickn+watch-...@chromium.org, core-web-vita...@chromium.org, ericwillige...@chromium.org, jeffreycohen+...@chromium.org, dfried...@chromium.org, khorimoto+wa...@chromium.org, kuragin+web-ap...@chromium.org, oshima...@chromium.org, tjohnsonkanu+...@google.com, elkuri...@chromium.org, fuzzin...@chromium.org, dtraino...@chromium.org, lcwu+...@chromium.org, zentaro+watch-a...@chromium.org, blink-rev...@chromium.org, jackshira+wa...@google.com, dewitt...@chromium.org, fmalit...@chromium.org, jackshira+wa...@google.com, dclasson+w...@google.com, drott+bl...@chromium.org, alandin...@chromium.org, philli...@chromium.org, bnc+...@chromium.org, jackshira+w...@google.com, harringt...@chromium.org, browser-comp...@chromium.org, khorimoto+w...@chromium.org, tluk+...@chromium.org, dougste...@chromium.org, asvitki...@chromium.org, wry+watc...@chromium.org, cc-...@chromium.org, azeemarshad+w...@chromium.org, blink-revie...@chromium.org, phoglun...@chromium.org, penghuan...@chromium.org, druber...@chromium.org, dibyapal+wa...@chromium.org, andysjl...@chromium.org, dmurph+watc...@chromium.org, kouhei...@chromium.org, jimmyxgong+wat...@chromium.org, zentaro+watch...@chromium.org, blink-reviews-p...@chromium.org, jkeitel+watch-...@google.com, rrsilva+wat...@google.com, prerenderi...@chromium.org, michaelcheco+wa...@google.com, nickdiego+wa...@igalia.com, pkotwic...@chromium.org, jdonnel...@chromium.org, print-revi...@chromium.org, npm+...@chromium.org, olesiamarukhno+wat...@google.com, tracing...@chromium.org, hashimo...@chromium.org, vasilii+watchlis...@chromium.org, ajayramamurt...@google.com, poscia...@chromium.org, toyosh...@chromium.org, wnwen...@chromium.org, joeantonetti+wa...@google.com, gogeral...@chromium.org, gangwu...@chromium.org, subresource-f...@chromium.org, jimmyxgong+watch...@chromium.org, zelin+watch-we...@chromium.org, jackshira+wa...@google.com, headless...@chromium.org, dpad+watch-input...@google.com, loading-re...@chromium.org, armalhotra+a...@google.com, csharrison+...@chromium.org, ukai+...@chromium.org, chfreme...@chromium.org, vakh+safe_br...@chromium.org, borealis-re...@google.com, wangdanny+watch-in...@google.com, dominickn+...@chromium.org, ajayramamurthy...@google.com, grt+...@chromium.org, francisjp...@google.com, ramyagopa...@google.com, gayane...@chromium.org, michaelcheco+...@google.com, jasonrhee+w...@google.com, gavinwill+watch-...@chromium.org, chrome-gr...@chromium.org, chadduffin+wa...@chromium.org, nyquis...@chromium.org, mar...@chromium.org, loading-rev...@chromium.org, android-web...@chromium.org, zhangwenyu+audi...@google.com, gordonseto+wa...@google.com, crisrael+wa...@google.com, scheduler...@chromium.org, cfredri...@chromium.org, toshikikikuch...@chromium.org, crisrael+w...@google.com, yhanad...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, chromeos-gfx-...@google.com, iwells...@chromium.org, gab+...@chromium.org, dmblac...@google.com, donnd...@chromium.org, thegreenf...@chromium.org, rtarpine+...@chromium.org, akingsb+wat...@google.com, keithle...@chromium.org, longbowei+watc...@google.com, max+watc...@igalia.com, cros-print...@google.com, xinghui...@chromium.org, hsuregan+wa...@chromium.org, telemetr...@chromium.org, polner+wat...@google.com, hais+wat...@google.com, lize...@chromium.org, jonmann+wat...@chromium.org, rousla...@chromium.org, crisrael+wa...@google.com, emircan+watch...@chromium.org, jinsukk...@chromium.org, jsaul+aut...@google.com, drott...@chromium.org, jonmann+w...@chromium.org, dmurph+watchi...@chromium.org, pushi+watc...@google.com, crostin...@chromium.org, suetfei+wa...@google.com, jdeblas...@chromium.org, croissant-...@chromium.org, fgal...@chromium.org, tommasin+watch-...@chromium.org, feliciac+au...@google.com, extension...@chromium.org, kaklilu+watch-...@chromium.org, network-ser...@chromium.org, hansenmichael...@google.com, hirokisa...@chromium.org, bmcquad...@chromium.org, binji...@chromium.org, gavinp...@chromium.org, phweis...@chromium.org, trewin...@google.com, jmedle...@chromium.org, security-...@chromium.org, cambickel+watc...@google.com, zentaro+wat...@chromium.org, djacob...@chromium.org, ozone-...@chromium.org, hansberry+wat...@chromium.org, navigation...@chromium.org, alancutter...@chromium.org, nikhilcn+wat...@google.com, rlp+...@chromium.org, mattsimm...@chromium.org, dominickn+wat...@chromium.org, andrewdear+wa...@google.com, yhanada+...@chromium.org, toshikikikuchi+...@chromium.org, njeunje+w...@chromium.org, crmulli...@chromium.org, ejcaruso+wa...@chromium.org, nicolas...@chromium.org, roblia...@chromium.org, hansberry+wa...@chromium.org, rginda...@chromium.org, nator...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, gordonseto+w...@google.com, ajayramamurth...@google.com, hansberry+w...@chromium.org, blink-rev...@chromium.org, siashah+au...@chromium.org, stevenjb+wa...@chromium.org, josiah...@chromium.org, dominickn+wat...@chromium.org, yusufo...@chromium.org, yhanada+...@chromium.org, dmblack+watc...@google.com, chromiumme...@microsoft.com, webapks-...@chromium.org, bici...@google.com, jophba...@chromium.org, hansberry+wa...@chromium.org, gcasto+w...@chromium.org, nwoked...@chromium.org, nektar...@chromium.org, blink-revi...@chromium.org, jorgel...@chromium.org, cblume...@chromium.org, apavlo...@chromium.org, jackshira+w...@google.com, michaelcheco+aud...@google.com, gordonseto+audi...@google.com, nikhilcn+wa...@google.com, odejesu...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, chrome-waff...@google.com, jonmann+wa...@chromium.org, ios-r...@chromium.org, rsleev...@chromium.org, erickun...@chromium.org, marimatthew+watc...@google.com, jackshira+w...@google.com, lizeb...@chromium.org, blundell+...@chromium.org, gogerald+pa...@chromium.org, ajayramamurth...@google.com, loading...@chromium.org, crisrael+...@google.com, zhangwen...@google.com, blink-re...@chromium.org, dullweb...@chromium.org, kouhe...@chromium.org, stevenj...@chromium.org, lwinston+watc...@google.com, marq+...@chromium.org, gavinp...@chromium.org, jshin...@chromium.org, azeemarshad+...@chromium.org, cros-ed...@google.com, arc-review...@google.com, tranbaod...@chromium.org, chromeos-kio...@google.com, gfhuan...@chromium.org, hansberry+wa...@chromium.org, yigu+...@chromium.org, ffred...@chromium.org, glider...@chromium.org, mac-r...@chromium.org, webauthn...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, tjohnsonkanu+w...@google.com, yhanada...@chromium.org, net-r...@chromium.org, michaelpg+w...@chromium.org, jonman...@chromium.org, dominickn+w...@chromium.org, gavin...@chromium.org, bhartmire+w...@google.com, ntp-dev...@chromium.org, owenzhang+audio...@google.com, kinuko...@chromium.org, lizeb+watch...@chromium.org, blink-re...@chromium.org, julietlevesque...@google.com, asumane...@google.com, amaliev+w...@chromium.org, cros-setti...@google.com, jsbell+ser...@chromium.org, jasonrobe...@google.com, shimazu...@chromium.org, mxcai+wat...@chromium.org, petewi...@chromium.org, mahmad...@chromium.org, chrome-intell...@chromium.org, kinuko+ser...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, zhangwenyu+wat...@google.com, jackshira+...@google.com, kyungjunle...@google.com, mfoltz...@chromium.org, fuchsia...@chromium.org, mreichhoff+watc...@chromium.org, mgiuca...@chromium.org, hsuregan+wat...@chromium.org, meilian...@chromium.org, rayanka...@chromium.org, andrewdear+w...@google.com, spang...@chromium.org, alemat...@chromium.org, penghu...@chromium.org, mickeybu...@chromium.org, mcasas+med...@chromium.org, filesapp...@chromium.org, chrome-b...@google.com, permissio...@chromium.org, eugeni...@chromium.org, gavin...@chromium.org, hiroshig...@chromium.org, srahim...@chromium.org, rouslan+au...@chromium.org, hanxi...@chromium.org, cros-system-ui-prod...@google.com, chromotin...@chromium.org, tgupta...@chromium.org, iclella...@chromium.org, translat...@chromium.org, sophey+wat...@chromium.org, jackshira+wa...@google.com, blink-re...@chromium.org, halliwe...@chromium.org, eme-r...@chromium.org, giovax...@chromium.org, jeffreycohen+watc...@chromium.org, dominickn+wat...@chromium.org, fserb...@chromium.org, chili...@chromium.org, jiajunz+wat...@google.com, ajayramamurthy+w...@google.com, blink-...@chromium.org
Attention needed from Olga Gerchikov and Sahir Vellani

Robert Flack voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olga Gerchikov
  • Sahir Vellani
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ecfc8f6577f3639739d32b2d34199ced420dd3f
Gerrit-Change-Number: 5445186
Gerrit-PatchSet: 6
Gerrit-Owner: Sahir Vellani <sahir....@microsoft.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Sahir Vellani <sahir....@microsoft.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Alvin Ji <alv...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Charlie Hu <chen...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Ilya Biryukov <ibir...@google.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nico Weber <tha...@chromium.org>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Collingbourne <p...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-CC: Reid Kleckner <r...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sam Clegg <s...@chromium.org>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sina Firoozabadi <sinaf...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: W. James Maclean <wjma...@chromium.org>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Sahir Vellani <sahir....@microsoft.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 14:37:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jan Keitel (Gerrit)

unread,
Apr 17, 2024, 10:39:07 AMApr 17
to Sahir Vellani, jkeitel+watch-...@google.com, Robert Flack, Christian Biesinger, Charlie Hu, Xida Chen, Chromium Metrics Reviews, Daniel Andersson, Peter Beverloo, Rijubrata Bhaumik, Nico Weber, Enterprise Policy Reviews, Sam Zackrisson, Nate Chapin, Per Åhgren, Henrique Ferreiro, Dirk Schulze, Peter Williamson, Sadrul Chowdhury, Hongchan Choi, Alexis Menard, Kentaro Hara, Ilya Biryukov, Jiewei Qian, Wanming Lin, Peter Collingbourne, James Su, Sam Clegg, David Bokan, Mathias Bynens, David Worsham, Robert Kroeger, Ale Bzk, Mirko Bonadei, Fredrik Söderquist, Jerome Jiang, Lei Zhang, Ian Vollick, Zijie He, Yoav Weiss (@Shopify), Sina Firoozabadi, Hans Wennborg, Hiroki Nakagawa, Tommy Li, Kaan Icer, W. James Maclean, Giovanni Ortuno Urquidi, Stephen Chenney, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Javier Fernandez, Simon Hangl, Alvin Ji, Mike Taylor, Raphael Kubo Da Costa, srirama chandra sekhar, Nektarios Paisios, Victor Tan, Nancy Wang, Kevin Babbitt, Reid Kleckner, Daniel Cheng, AyeAye, Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, rouslan+...@chromium.org, tburkar...@chromium.org, tsergea...@chromium.org, jz...@chromium.org, vinnypersky+...@google.com, anastas...@google.com, cclem+wat...@google.com, dominicc+...@chromium.org, performance-m...@chromium.org, fgorsk...@chromium.org, kinuko+...@chromium.org, ajayramamurthy...@google.com, rsesek...@chromium.org, robertshi...@chromium.org, yfriedm...@chromium.org, shimazu+se...@chromium.org, shend...@chromium.org, cros-essential...@chromium.org, blink-rev...@chromium.org, devtools...@chromium.org, dominickn+...@chromium.org, jiajunz+wa...@google.com, agriev...@chromium.org, pushi+wat...@google.com, dmurph+wat...@chromium.org, csharris...@chromium.org, andreaor...@chromium.org, katie...@chromium.org, siyua+aut...@chromium.org, caitkp...@chromium.org, eric.c...@apple.com, torne...@chromium.org, abigailbk...@google.com, blink-revie...@chromium.org, blink-revi...@chromium.org, dtseng+c...@chromium.org, jdh+wat...@chromium.org, chrome-mem...@google.com, dtapuska+ch...@chromium.org, tmartino+tran...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, chromeos-ca...@google.com, ryanchu...@chromium.org, crost...@chromium.org, wanderview...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, loyso...@chromium.org, yuezhang...@chromium.org, xlythe+wa...@google.com, cros-report...@google.com, dtseng...@chromium.org, ender...@chromium.org, michaelpg+wa...@chromium.org, video-networking...@google.com, jackshira+wat...@google.com, dimich...@chromium.org, pdf-r...@chromium.org, multipaste-...@google.com, shgar+aut...@google.com, asvitkine...@chromium.org, alexmo...@chromium.org, martijn...@martijnc.be, dmurph+watch...@chromium.org, pasko...@chromium.org, mattreyno...@chromium.org, tbarzi...@chromium.org, ios-revie...@chromium.org, xiaohui...@chromium.org, boujane+watch-...@google.com, dmurph+watching...@chromium.org, media-wi...@chromium.org, wychen...@chromium.org, blink-work...@chromium.org, scheduler-...@chromium.org, zentaro+sca...@chromium.org, ajayramamu...@google.com, chadduffin+w...@chromium.org, dullweber+watch...@chromium.org, mxcai+watch...@chromium.org, shannc...@chromium.org, rkgibso...@chromium.org, wfh+...@chromium.org, dpr...@google.com, tote-eng...@google.com, bcb+watch-pl...@chromium.org, emi...@google.com, jessemcke...@google.com, cclem+wat...@google.com, devtools-re...@chromium.org, droger+w...@chromium.org, steimel+...@chromium.org, chromium-...@engflow.com, wittma...@chromium.org, haoliu...@chromium.org, jonmann+watc...@chromium.org, pushi+wa...@google.com, chikamu...@chromium.org, aleventhal...@chromium.org, yuzo+...@chromium.org, gavinwill+sc...@chromium.org, glenro...@chromium.org, msrame...@chromium.org, wnwen+w...@chromium.org, blink-revie...@chromium.org, shuche...@chromium.org, ydago...@chromium.org, wiss+watc...@chromium.org, davidj...@chromium.org, hansberry+w...@chromium.org, feature-v...@chromium.org, olesiamaru...@google.com, andrewxu+wat...@google.com, minap+watch-p...@google.com, hidehik...@chromium.org, hayato...@chromium.org, nburris+pa...@chromium.org, creis...@chromium.org, michaelpg+wa...@chromium.org, sky+...@chromium.org, pdr+svgw...@chromium.org, alimariam+watch...@google.com, print-rev...@chromium.org, xhwang...@chromium.org, gbiv+...@chromium.org, tommyw+w...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, chasej...@chromium.org, twelling...@chromium.org, feature-me...@chromium.org, lingqi...@chromium.org, media-cro...@chromium.org, pmonett...@chromium.org, michaelcheco+watch-i...@google.com, zackha...@chromium.org, twifka...@chromium.org, gbb-cct...@google.com, dominickn+watch-...@chromium.org, core-web-vita...@chromium.org, ericwillige...@chromium.org, jeffreycohen+...@chromium.org, dfried...@chromium.org, khorimoto+wa...@chromium.org, kuragin+web-ap...@chromium.org, oshima...@chromium.org, tjohnsonkanu+...@google.com, elkuri...@chromium.org, fuzzin...@chromium.org, dtraino...@chromium.org, lcwu+...@chromium.org, zentaro+watch-a...@chromium.org, blink-rev...@chromium.org, jackshira+wa...@google.com, dewitt...@chromium.org, fmalit...@chromium.org, jackshira+wa...@google.com, dclasson+w...@google.com, drott+bl...@chromium.org, alandin...@chromium.org, philli...@chromium.org, bnc+...@chromium.org, jackshira+w...@google.com, harringt...@chromium.org, browser-comp...@chromium.org, khorimoto+w...@chromium.org, tluk+...@chromium.org, dougste...@chromium.org, asvitki...@chromium.org, wry+watc...@chromium.org, cc-...@chromium.org, azeemarshad+w...@chromium.org, blink-revie...@chromium.org, phoglun...@chromium.org, penghuan...@chromium.org, druber...@chromium.org, dibyapal+wa...@chromium.org, andysjl...@chromium.org, dmurph+watc...@chromium.org, kouhei...@chromium.org, jimmyxgong+wat...@chromium.org, zentaro+watch...@chromium.org, blink-reviews-p...@chromium.org, rrsilva+wat...@google.com, prerenderi...@chromium.org, michaelcheco+wa...@google.com, nickdiego+wa...@igalia.com, pkotwic...@chromium.org, jdonnel...@chromium.org, print-revi...@chromium.org, npm+...@chromium.org, olesiamarukhno+wat...@google.com, tracing...@chromium.org, hashimo...@chromium.org, vasilii+watchlis...@chromium.org, ajayramamurt...@google.com, poscia...@chromium.org, toyosh...@chromium.org, wnwen...@chromium.org, joeantonetti+wa...@google.com, gogeral...@chromium.org, gangwu...@chromium.org, subresource-f...@chromium.org, jimmyxgong+watch...@chromium.org, zelin+watch-we...@chromium.org, jackshira+wa...@google.com, headless...@chromium.org, dpad+watch-input...@google.com, loading-re...@chromium.org, armalhotra+a...@google.com, csharrison+...@chromium.org, ukai+...@chromium.org, chfreme...@chromium.org, vakh+safe_br...@chromium.org, borealis-re...@google.com, wangdanny+watch-in...@google.com, dominickn+...@chromium.org, ajayramamurthy...@google.com, grt+...@chromium.org, francisjp...@google.com, ramyagopa...@google.com, gayane...@chromium.org, michaelcheco+...@google.com, jasonrhee+w...@google.com, gavinwill+watch-...@chromium.org, chrome-gr...@chromium.org, chadduffin+wa...@chromium.org, nyquis...@chromium.org, mar...@chromium.org, loading-rev...@chromium.org, android-web...@chromium.org, zhangwenyu+audi...@google.com, gordonseto+wa...@google.com, crisrael+wa...@google.com, scheduler...@chromium.org, cfredri...@chromium.org, toshikikikuch...@chromium.org, crisrael+w...@google.com, yhanad...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, chromeos-gfx-...@google.com, iwells...@chromium.org, gab+...@chromium.org, dmblac...@google.com, donnd...@chromium.org, thegreenf...@chromium.org, rtarpine+...@chromium.org, akingsb+wat...@google.com, keithle...@chromium.org, longbowei+watc...@google.com, max+watc...@igalia.com, cros-print...@google.com, xinghui...@chromium.org, hsuregan+wa...@chromium.org, telemetr...@chromium.org, polner+wat...@google.com, hais+wat...@google.com, lize...@chromium.org, jonmann+wat...@chromium.org, rousla...@chromium.org, crisrael+wa...@google.com, emircan+watch...@chromium.org, jinsukk...@chromium.org, jsaul+aut...@google.com, drott...@chromium.org, jonmann+w...@chromium.org, dmurph+watchi...@chromium.org, pushi+watc...@google.com, crostin...@chromium.org, suetfei+wa...@google.com, jdeblas...@chromium.org, croissant-...@chromium.org, fgal...@chromium.org, tommasin+watch-...@chromium.org, feliciac+au...@google.com, extension...@chromium.org, kaklilu+watch-...@chromium.org, network-ser...@chromium.org, hansenmichael...@google.com, hirokisa...@chromium.org, bmcquad...@chromium.org, binji...@chromium.org, gavinp...@chromium.org, phweis...@chromium.org, trewin...@google.com, jmedle...@chromium.org, security-...@chromium.org, cambickel+watc...@google.com, zentaro+wat...@chromium.org, djacob...@chromium.org, ozone-...@chromium.org, hansberry+wat...@chromium.org, navigation...@chromium.org, alancutter...@chromium.org, nikhilcn+wat...@google.com, rlp+...@chromium.org, mattsimm...@chromium.org, dominickn+wat...@chromium.org, andrewdear+wa...@google.com, yhanada+...@chromium.org, toshikikikuchi+...@chromium.org, njeunje+w...@chromium.org, crmulli...@chromium.org, ejcaruso+wa...@chromium.org, nicolas...@chromium.org, roblia...@chromium.org, hansberry+wa...@chromium.org, rginda...@chromium.org, nator...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, gordonseto+w...@google.com, ajayramamurth...@google.com, hansberry+w...@chromium.org, blink-rev...@chromium.org, siashah+au...@chromium.org, stevenjb+wa...@chromium.org, josiah...@chromium.org, dominickn+wat...@chromium.org, yusufo...@chromium.org, yhanada+...@chromium.org, dmblack+watc...@google.com, chromiumme...@microsoft.com, webapks-...@chromium.org, bici...@google.com, jophba...@chromium.org, hansberry+wa...@chromium.org, gcasto+w...@chromium.org, nwoked...@chromium.org, nektar...@chromium.org, blink-revi...@chromium.org, jorgel...@chromium.org, cblume...@chromium.org, apavlo...@chromium.org, jackshira+w...@google.com, michaelcheco+aud...@google.com, gordonseto+audi...@google.com, nikhilcn+wa...@google.com, odejesu...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, chrome-waff...@google.com, jonmann+wa...@chromium.org, ios-r...@chromium.org, rsleev...@chromium.org, erickun...@chromium.org, marimatthew+watc...@google.com, jackshira+w...@google.com, lizeb...@chromium.org, blundell+...@chromium.org, gogerald+pa...@chromium.org, ajayramamurth...@google.com, loading...@chromium.org, crisrael+...@google.com, zhangwen...@google.com, blink-re...@chromium.org, dullweb...@chromium.org, kouhe...@chromium.org, stevenj...@chromium.org, lwinston+watc...@google.com, marq+...@chromium.org, gavinp...@chromium.org, jshin...@chromium.org, azeemarshad+...@chromium.org, cros-ed...@google.com, arc-review...@google.com, tranbaod...@chromium.org, chromeos-kio...@google.com, gfhuan...@chromium.org, hansberry+wa...@chromium.org, yigu+...@chromium.org, ffred...@chromium.org, glider...@chromium.org, mac-r...@chromium.org, webauthn...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, tjohnsonkanu+w...@google.com, yhanada...@chromium.org, net-r...@chromium.org, michaelpg+w...@chromium.org, jonman...@chromium.org, dominickn+w...@chromium.org, gavin...@chromium.org, bhartmire+w...@google.com, ntp-dev...@chromium.org, owenzhang+audio...@google.com, kinuko...@chromium.org, lizeb+watch...@chromium.org, blink-re...@chromium.org, julietlevesque...@google.com, asumane...@google.com, amaliev+w...@chromium.org, cros-setti...@google.com, jsbell+ser...@chromium.org, jasonrobe...@google.com, shimazu...@chromium.org, mxcai+wat...@chromium.org, petewi...@chromium.org, mahmad...@chromium.org, chrome-intell...@chromium.org, kinuko+ser...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, zhangwenyu+wat...@google.com, jackshira+...@google.com, kyungjunle...@google.com, mfoltz...@chromium.org, fuchsia...@chromium.org, mreichhoff+watc...@chromium.org, mgiuca...@chromium.org, hsuregan+wat...@chromium.org, meilian...@chromium.org, rayanka...@chromium.org, andrewdear+w...@google.com, spang...@chromium.org, alemat...@chromium.org, penghu...@chromium.org, mickeybu...@chromium.org, mcasas+med...@chromium.org, filesapp...@chromium.org, chrome-b...@google.com, permissio...@chromium.org, eugeni...@chromium.org, gavin...@chromium.org, hiroshig...@chromium.org, srahim...@chromium.org, rouslan+au...@chromium.org, hanxi...@chromium.org, cros-system-ui-prod...@google.com, chromotin...@chromium.org, tgupta...@chromium.org, iclella...@chromium.org, translat...@chromium.org, sophey+wat...@chromium.org, jackshira+wa...@google.com, blink-re...@chromium.org, halliwe...@chromium.org, eme-r...@chromium.org, giovax...@chromium.org, jeffreycohen+watc...@chromium.org, dominickn+wat...@chromium.org, fserb...@chromium.org, chili...@chromium.org, jiajunz+wat...@google.com, ajayramamurthy+w...@google.com, blink-...@chromium.org
Attention needed from Olga Gerchikov and Sahir Vellani

Jan Keitel removed jkeitel+watch-...@google.com from this change

Open in Gerrit

Related details

Attention is currently required from:
  • Olga Gerchikov
  • Sahir Vellani
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
satisfied_requirement
unsatisfied_requirement
open
diffy

Sahir Vellani (Gerrit)

unread,
Apr 17, 2024, 11:01:06 AMApr 17
to Robert Flack, Christian Biesinger, Charlie Hu, Xida Chen, Chromium Metrics Reviews, Daniel Andersson, Peter Beverloo, Rijubrata Bhaumik, Nico Weber, Enterprise Policy Reviews, Sam Zackrisson, Nate Chapin, Per Åhgren, Henrique Ferreiro, Dirk Schulze, Peter Williamson, Sadrul Chowdhury, Hongchan Choi, Alexis Menard, Kentaro Hara, Ilya Biryukov, Jiewei Qian, Wanming Lin, Peter Collingbourne, James Su, Sam Clegg, David Bokan, Mathias Bynens, David Worsham, Robert Kroeger, Ale Bzk, Mirko Bonadei, Fredrik Söderquist, Jerome Jiang, Lei Zhang, Ian Vollick, Zijie He, Yoav Weiss (@Shopify), Sina Firoozabadi, Hans Wennborg, Hiroki Nakagawa, Tommy Li, Kaan Icer, W. James Maclean, Giovanni Ortuno Urquidi, Stephen Chenney, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Javier Fernandez, Simon Hangl, Alvin Ji, Mike Taylor, Raphael Kubo Da Costa, srirama chandra sekhar, Nektarios Paisios, Victor Tan, Nancy Wang, Kevin Babbitt, Reid Kleckner, Daniel Cheng, AyeAye, Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, rouslan+...@chromium.org, tburkar...@chromium.org, tsergea...@chromium.org, jz...@chromium.org, vinnypersky+...@google.com, anastas...@google.com, cclem+wat...@google.com, dominicc+...@chromium.org, performance-m...@chromium.org, fgorsk...@chromium.org, kinuko+...@chromium.org, ajayramamurthy...@google.com, rsesek...@chromium.org, robertshi...@chromium.org, yfriedm...@chromium.org, shimazu+se...@chromium.org, shend...@chromium.org, cros-essential...@chromium.org, blink-rev...@chromium.org, devtools...@chromium.org, dominickn+...@chromium.org, jiajunz+wa...@google.com, agriev...@chromium.org, pushi+wat...@google.com, dmurph+wat...@chromium.org, csharris...@chromium.org, andreaor...@chromium.org, katie...@chromium.org, siyua+aut...@chromium.org, caitkp...@chromium.org, eric.c...@apple.com, torne...@chromium.org, abigailbk...@google.com, blink-revie...@chromium.org, blink-revi...@chromium.org, dtseng+c...@chromium.org, jdh+wat...@chromium.org, chrome-mem...@google.com, dtapuska+ch...@chromium.org, tmartino+tran...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, chromeos-ca...@google.com, ryanchu...@chromium.org, crost...@chromium.org, wanderview...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, loyso...@chromium.org, yuezhang...@chromium.org, xlythe+wa...@google.com, cros-report...@google.com, dtseng...@chromium.org, ender...@chromium.org, michaelpg+wa...@chromium.org, video-networking...@google.com, jackshira+wat...@google.com, dimich...@chromium.org, pdf-r...@chromium.org, multipaste-...@google.com, shgar+aut...@google.com, asvitkine...@chromium.org, alexmo...@chromium.org, martijn...@martijnc.be, dmurph+watch...@chromium.org, pasko...@chromium.org, mattreyno...@chromium.org, tbarzi...@chromium.org, ios-revie...@chromium.org, xiaohui...@chromium.org, boujane+watch-...@google.com, dmurph+watching...@chromium.org, media-wi...@chromium.org, wychen...@chromium.org, blink-work...@chromium.org, scheduler-...@chromium.org, zentaro+sca...@chromium.org, ajayramamu...@google.com, chadduffin+w...@chromium.org, dullweber+watch...@chromium.org, mxcai+watch...@chromium.org, shannc...@chromium.org, rkgibso...@chromium.org, wfh+...@chromium.org, dpr...@google.com, tote-eng...@google.com, bcb+watch-pl...@chromium.org, emi...@google.com, jessemcke...@google.com, cclem+wat...@google.com, devtools-re...@chromium.org, droger+w...@chromium.org, steimel+...@chromium.org, chromium-...@engflow.com, wittma...@chromium.org, haoliu...@chromium.org, jonmann+watc...@chromium.org, pushi+wa...@google.com, chikamu...@chromium.org, aleventhal...@chromium.org, yuzo+...@chromium.org, gavinwill+sc...@chromium.org, glenro...@chromium.org, msrame...@chromium.org, wnwen+w...@chromium.org, blink-revie...@chromium.org, shuche...@chromium.org, ydago...@chromium.org, wiss+watc...@chromium.org, davidj...@chromium.org, hansberry+w...@chromium.org, feature-v...@chromium.org, olesiamaru...@google.com, andrewxu+wat...@google.com, minap+watch-p...@google.com, hidehik...@chromium.org, hayato...@chromium.org, nburris+pa...@chromium.org, creis...@chromium.org, michaelpg+wa...@chromium.org, sky+...@chromium.org, pdr+svgw...@chromium.org, alimariam+watch...@google.com, print-rev...@chromium.org, xhwang...@chromium.org, gbiv+...@chromium.org, tommyw+w...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, chasej...@chromium.org, twelling...@chromium.org, feature-me...@chromium.org, lingqi...@chromium.org, media-cro...@chromium.org, pmonett...@chromium.org, michaelcheco+watch-i...@google.com, zackha...@chromium.org, twifka...@chromium.org, gbb-cct...@google.com, dominickn+watch-...@chromium.org, core-web-vita...@chromium.org, ericwillige...@chromium.org, jeffreycohen+...@chromium.org, dfried...@chromium.org, khorimoto+wa...@chromium.org, kuragin+web-ap...@chromium.org, oshima...@chromium.org, tjohnsonkanu+...@google.com, elkuri...@chromium.org, fuzzin...@chromium.org, dtraino...@chromium.org, lcwu+...@chromium.org, zentaro+watch-a...@chromium.org, blink-rev...@chromium.org, jackshira+wa...@google.com, dewitt...@chromium.org, fmalit...@chromium.org, jackshira+wa...@google.com, dclasson+w...@google.com, drott+bl...@chromium.org, alandin...@chromium.org, philli...@chromium.org, bnc+...@chromium.org, jackshira+w...@google.com, harringt...@chromium.org, browser-comp...@chromium.org, khorimoto+w...@chromium.org, tluk+...@chromium.org, dougste...@chromium.org, asvitki...@chromium.org, wry+watc...@chromium.org, cc-...@chromium.org, azeemarshad+w...@chromium.org, blink-revie...@chromium.org, phoglun...@chromium.org, penghuan...@chromium.org, druber...@chromium.org, dibyapal+wa...@chromium.org, andysjl...@chromium.org, dmurph+watc...@chromium.org, kouhei...@chromium.org, jimmyxgong+wat...@chromium.org, zentaro+watch...@chromium.org, blink-reviews-p...@chromium.org, rrsilva+wat...@google.com, prerenderi...@chromium.org, michaelcheco+wa...@google.com, nickdiego+wa...@igalia.com, pkotwic...@chromium.org, jdonnel...@chromium.org, print-revi...@chromium.org, npm+...@chromium.org, olesiamarukhno+wat...@google.com, tracing...@chromium.org, hashimo...@chromium.org, vasilii+watchlis...@chromium.org, ajayramamurt...@google.com, poscia...@chromium.org, toyosh...@chromium.org, wnwen...@chromium.org, joeantonetti+wa...@google.com, gogeral...@chromium.org, gangwu...@chromium.org, subresource-f...@chromium.org, jimmyxgong+watch...@chromium.org, zelin+watch-we...@chromium.org, jackshira+wa...@google.com, headless...@chromium.org, dpad+watch-input...@google.com, loading-re...@chromium.org, armalhotra+a...@google.com, csharrison+...@chromium.org, ukai+...@chromium.org, chfreme...@chromium.org, vakh+safe_br...@chromium.org, borealis-re...@google.com, wangdanny+watch-in...@google.com, dominickn+...@chromium.org, ajayramamurthy...@google.com, grt+...@chromium.org, francisjp...@google.com, ramyagopa...@google.com, gayane...@chromium.org, michaelcheco+...@google.com, jasonrhee+w...@google.com, gavinwill+watch-...@chromium.org, chrome-gr...@chromium.org, chadduffin+wa...@chromium.org, nyquis...@chromium.org, mar...@chromium.org, loading-rev...@chromium.org, android-web...@chromium.org, zhangwenyu+audi...@google.com, gordonseto+wa...@google.com, crisrael+wa...@google.com, scheduler...@chromium.org, cfredri...@chromium.org, toshikikikuch...@chromium.org, crisrael+w...@google.com, yhanad...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, chromeos-gfx-...@google.com, iwells...@chromium.org, gab+...@chromium.org, dmblac...@google.com, donnd...@chromium.org, thegreenf...@chromium.org, rtarpine+...@chromium.org, akingsb+wat...@google.com, keithle...@chromium.org, longbowei+watc...@google.com, max+watc...@igalia.com, cros-print...@google.com, xinghui...@chromium.org, hsuregan+wa...@chromium.org, telemetr...@chromium.org, polner+wat...@google.com, hais+wat...@google.com, lize...@chromium.org, jonmann+wat...@chromium.org, rousla...@chromium.org, crisrael+wa...@google.com, emircan+watch...@chromium.org, jinsukk...@chromium.org, jsaul+aut...@google.com, drott...@chromium.org, jonmann+w...@chromium.org, dmurph+watchi...@chromium.org, pushi+watc...@google.com, crostin...@chromium.org, suetfei+wa...@google.com, jdeblas...@chromium.org, croissant-...@chromium.org, fgal...@chromium.org, tommasin+watch-...@chromium.org, feliciac+au...@google.com, extension...@chromium.org, kaklilu+watch-...@chromium.org, network-ser...@chromium.org, hansenmichael...@google.com, hirokisa...@chromium.org, bmcquad...@chromium.org, binji...@chromium.org, gavinp...@chromium.org, phweis...@chromium.org, trewin...@google.com, jmedle...@chromium.org, security-...@chromium.org, cambickel+watc...@google.com, zentaro+wat...@chromium.org, djacob...@chromium.org, ozone-...@chromium.org, hansberry+wat...@chromium.org, navigation...@chromium.org, alancutter...@chromium.org, nikhilcn+wat...@google.com, rlp+...@chromium.org, mattsimm...@chromium.org, dominickn+wat...@chromium.org, andrewdear+wa...@google.com, yhanada+...@chromium.org, toshikikikuchi+...@chromium.org, njeunje+w...@chromium.org, crmulli...@chromium.org, ejcaruso+wa...@chromium.org, nicolas...@chromium.org, roblia...@chromium.org, hansberry+wa...@chromium.org, rginda...@chromium.org, nator...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, gordonseto+w...@google.com, ajayramamurth...@google.com, hansberry+w...@chromium.org, blink-rev...@chromium.org, siashah+au...@chromium.org, stevenjb+wa...@chromium.org, josiah...@chromium.org, dominickn+wat...@chromium.org, yusufo...@chromium.org, yhanada+...@chromium.org, dmblack+watc...@google.com, chromiumme...@microsoft.com, webapks-...@chromium.org, bici...@google.com, jophba...@chromium.org, hansberry+wa...@chromium.org, gcasto+w...@chromium.org, nwoked...@chromium.org, nektar...@chromium.org, blink-revi...@chromium.org, jorgel...@chromium.org, cblume...@chromium.org, apavlo...@chromium.org, jackshira+w...@google.com, michaelcheco+aud...@google.com, gordonseto+audi...@google.com, nikhilcn+wa...@google.com, odejesu...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, chrome-waff...@google.com, jonmann+wa...@chromium.org, ios-r...@chromium.org, rsleev...@chromium.org, erickun...@chromium.org, marimatthew+watc...@google.com, jackshira+w...@google.com, lizeb...@chromium.org, blundell+...@chromium.org, gogerald+pa...@chromium.org, ajayramamurth...@google.com, loading...@chromium.org, crisrael+...@google.com, zhangwen...@google.com, blink-re...@chromium.org, dullweb...@chromium.org, kouhe...@chromium.org, stevenj...@chromium.org, lwinston+watc...@google.com, marq+...@chromium.org, gavinp...@chromium.org, jshin...@chromium.org, azeemarshad+...@chromium.org, cros-ed...@google.com, arc-review...@google.com, tranbaod...@chromium.org, chromeos-kio...@google.com, gfhuan...@chromium.org, hansberry+wa...@chromium.org, yigu+...@chromium.org, ffred...@chromium.org, glider...@chromium.org, mac-r...@chromium.org, webauthn...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, tjohnsonkanu+w...@google.com, yhanada...@chromium.org, net-r...@chromium.org, michaelpg+w...@chromium.org, jonman...@chromium.org, dominickn+w...@chromium.org, gavin...@chromium.org, bhartmire+w...@google.com, ntp-dev...@chromium.org, owenzhang+audio...@google.com, kinuko...@chromium.org, lizeb+watch...@chromium.org, blink-re...@chromium.org, julietlevesque...@google.com, asumane...@google.com, amaliev+w...@chromium.org, cros-setti...@google.com, jsbell+ser...@chromium.org, jasonrobe...@google.com, shimazu...@chromium.org, mxcai+wat...@chromium.org, petewi...@chromium.org, mahmad...@chromium.org, chrome-intell...@chromium.org, kinuko+ser...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, zhangwenyu+wat...@google.com, jackshira+...@google.com, kyungjunle...@google.com, mfoltz...@chromium.org, fuchsia...@chromium.org, mreichhoff+watc...@chromium.org, mgiuca...@chromium.org, hsuregan+wat...@chromium.org, meilian...@chromium.org, rayanka...@chromium.org, andrewdear+w...@google.com, spang...@chromium.org, alemat...@chromium.org, penghu...@chromium.org, mickeybu...@chromium.org, mcasas+med...@chromium.org, filesapp...@chromium.org, chrome-b...@google.com, permissio...@chromium.org, eugeni...@chromium.org, gavin...@chromium.org, hiroshig...@chromium.org, srahim...@chromium.org, rouslan+au...@chromium.org, hanxi...@chromium.org, cros-system-ui-prod...@google.com, chromotin...@chromium.org, tgupta...@chromium.org, iclella...@chromium.org, translat...@chromium.org, sophey+wat...@chromium.org, jackshira+wa...@google.com, blink-re...@chromium.org, halliwe...@chromium.org, eme-r...@chromium.org, giovax...@chromium.org, jeffreycohen+watc...@chromium.org, dominickn+wat...@chromium.org, fserb...@chromium.org, chili...@chromium.org, jiajunz+wat...@google.com, ajayramamurthy+w...@google.com, blink-...@chromium.org
Attention needed from Olga Gerchikov

Sahir Vellani added 1 comment

Patchset-level comments
File-level comment, Patchset 4:
Robert Flack . resolved

Looks good though is there any wpt coverage for this?

Sahir Vellani

Not yet. I can add something like get-device-properties-uniqueid-from-pointer-event.tentative.html where the `uniqueId` for a mouse pointer will also be -1. Altenatively, I think it may be worthwhile to explore updating test-driver and related code to set a `uniqueId` on the device properties object. That way we can have stricter tests that guard the behaviour defined in the spec. WDYT?

Robert Flack

where the uniqueId for a mouse pointer will also be -1

I thought a mouse pointer always has the uniqueId initialized by GetBlinkDeviceId?

Sahir Vellani

Oh sorry, yes so it will be 0. But ideally the test would have the mouse pointer's device id compared to another pointer. We can do that right now, but the test would still pass if we maintained the old behaviour of mouse pointer having a uniqueId of 1 always.

Sahir Vellani

I think with testdriver support of deviceProperties, we will be able to capture the scenarios that are at the moment only tested in `PointerEventFactoryDevicePropertiesTest`.

Robert Flack

Would it make sense to have a manual test with instructions? What devices would someone need to test this?

Sahir Vellani

I don't see why not! The devices required would be a touch screen computer, a pen/stylus that can communicate its hardware id with the digitizer, and a mouse. The more pens the better. For example, a Surface Laptop, Surface Pen, and Mouse would be adequate. I understand that's very Microsoft specific, but I've tested this on an HP device as well- HP Pro x360 Fortis w/ a slim rechargeable pen.

Sahir Vellani

Mouse or trackpad would be fine.

Sahir Vellani

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Olga Gerchikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Comment-Date: Wed, 17 Apr 2024 15:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Flack <fla...@chromium.org>
Comment-In-Reply-To: Sahir Vellani <sahir....@microsoft.com>
satisfied_requirement
open
diffy

Sahir Vellani (Gerrit)

unread,
Apr 17, 2024, 11:01:13 AMApr 17
to Robert Flack, Christian Biesinger, Charlie Hu, Xida Chen, Chromium Metrics Reviews, Daniel Andersson, Peter Beverloo, Rijubrata Bhaumik, Nico Weber, Enterprise Policy Reviews, Sam Zackrisson, Nate Chapin, Per Åhgren, Henrique Ferreiro, Dirk Schulze, Peter Williamson, Sadrul Chowdhury, Hongchan Choi, Alexis Menard, Kentaro Hara, Ilya Biryukov, Jiewei Qian, Wanming Lin, Peter Collingbourne, James Su, Sam Clegg, David Bokan, Mathias Bynens, David Worsham, Robert Kroeger, Ale Bzk, Mirko Bonadei, Fredrik Söderquist, Jerome Jiang, Lei Zhang, Ian Vollick, Zijie He, Yoav Weiss (@Shopify), Sina Firoozabadi, Hans Wennborg, Hiroki Nakagawa, Tommy Li, Kaan Icer, W. James Maclean, Giovanni Ortuno Urquidi, Stephen Chenney, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Javier Fernandez, Simon Hangl, Alvin Ji, Mike Taylor, Raphael Kubo Da Costa, srirama chandra sekhar, Nektarios Paisios, Victor Tan, Nancy Wang, Kevin Babbitt, Reid Kleckner, Daniel Cheng, AyeAye, Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, rouslan+...@chromium.org, tburkar...@chromium.org, tsergea...@chromium.org, jz...@chromium.org, vinnypersky+...@google.com, anastas...@google.com, cclem+wat...@google.com, dominicc+...@chromium.org, performance-m...@chromium.org, fgorsk...@chromium.org, kinuko+...@chromium.org, ajayramamurthy...@google.com, rsesek...@chromium.org, robertshi...@chromium.org, yfriedm...@chromium.org, shimazu+se...@chromium.org, shend...@chromium.org, cros-essential...@chromium.org, blink-rev...@chromium.org, devtools...@chromium.org, dominickn+...@chromium.org, jiajunz+wa...@google.com, agriev...@chromium.org, pushi+wat...@google.com, dmurph+wat...@chromium.org, csharris...@chromium.org, andreaor...@chromium.org, katie...@chromium.org, siyua+aut...@chromium.org, caitkp...@chromium.org, eric.c...@apple.com, torne...@chromium.org, abigailbk...@google.com, blink-revie...@chromium.org, blink-revi...@chromium.org, dtseng+c...@chromium.org, jdh+wat...@chromium.org, chrome-mem...@google.com, dtapuska+ch...@chromium.org, tmartino+tran...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, chromeos-ca...@google.com, ryanchu...@chromium.org, crost...@chromium.org, wanderview...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, loyso...@chromium.org, yuezhang...@chromium.org, xlythe+wa...@google.com, cros-report...@google.com, dtseng...@chromium.org, ender...@chromium.org, michaelpg+wa...@chromium.org, video-networking...@google.com, jackshira+wat...@google.com, dimich...@chromium.org, pdf-r...@chromium.org, multipaste-...@google.com, shgar+aut...@google.com, asvitkine...@chromium.org, alexmo...@chromium.org, martijn...@martijnc.be, dmurph+watch...@chromium.org, pasko...@chromium.org, mattreyno...@chromium.org, tbarzi...@chromium.org, ios-revie...@chromium.org, xiaohui...@chromium.org, boujane+watch-...@google.com, dmurph+watching...@chromium.org, media-wi...@chromium.org, wychen...@chromium.org, blink-work...@chromium.org, scheduler-...@chromium.org, zentaro+sca...@chromium.org, ajayramamu...@google.com, chadduffin+w...@chromium.org, dullweber+watch...@chromium.org, mxcai+watch...@chromium.org, shannc...@chromium.org, rkgibso...@chromium.org, wfh+...@chromium.org, dpr...@google.com, tote-eng...@google.com, bcb+watch-pl...@chromium.org, emi...@google.com, jessemcke...@google.com, cclem+wat...@google.com, devtools-re...@chromium.org, droger+w...@chromium.org, steimel+...@chromium.org, chromium-...@engflow.com, wittma...@chromium.org, haoliu...@chromium.org, jonmann+watc...@chromium.org, pushi+wa...@google.com, chikamu...@chromium.org, aleventhal...@chromium.org, yuzo+...@chromium.org, gavinwill+sc...@chromium.org, glenro...@chromium.org, msrame...@chromium.org, wnwen+w...@chromium.org, blink-revie...@chromium.org, shuche...@chromium.org, ydago...@chromium.org, wiss+watc...@chromium.org, davidj...@chromium.org, hansberry+w...@chromium.org, feature-v...@chromium.org, olesiamaru...@google.com, andrewxu+wat...@google.com, minap+watch-p...@google.com, hidehik...@chromium.org, hayato...@chromium.org, nburris+pa...@chromium.org, creis...@chromium.org, michaelpg+wa...@chromium.org, sky+...@chromium.org, pdr+svgw...@chromium.org, alimariam+watch...@google.com, print-rev...@chromium.org, xhwang...@chromium.org, gbiv+...@chromium.org, tommyw+w...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, chasej...@chromium.org, twelling...@chromium.org, feature-me...@chromium.org, lingqi...@chromium.org, media-cro...@chromium.org, pmonett...@chromium.org, michaelcheco+watch-i...@google.com, zackha...@chromium.org, twifka...@chromium.org, gbb-cct...@google.com, dominickn+watch-...@chromium.org, core-web-vita...@chromium.org, ericwillige...@chromium.org, jeffreycohen+...@chromium.org, dfried...@chromium.org, khorimoto+wa...@chromium.org, kuragin+web-ap...@chromium.org, oshima...@chromium.org, tjohnsonkanu+...@google.com, elkuri...@chromium.org, fuzzin...@chromium.org, dtraino...@chromium.org, lcwu+...@chromium.org, zentaro+watch-a...@chromium.org, blink-rev...@chromium.org, jackshira+wa...@google.com, dewitt...@chromium.org, fmalit...@chromium.org, jackshira+wa...@google.com, dclasson+w...@google.com, drott+bl...@chromium.org, alandin...@chromium.org, philli...@chromium.org, bnc+...@chromium.org, jackshira+w...@google.com, harringt...@chromium.org, browser-comp...@chromium.org, khorimoto+w...@chromium.org, tluk+...@chromium.org, dougste...@chromium.org, asvitki...@chromium.org, wry+watc...@chromium.org, cc-...@chromium.org, azeemarshad+w...@chromium.org, blink-revie...@chromium.org, phoglun...@chromium.org, penghuan...@chromium.org, druber...@chromium.org, dibyapal+wa...@chromium.org, andysjl...@chromium.org, dmurph+watc...@chromium.org, kouhei...@chromium.org, jimmyxgong+wat...@chromium.org, zentaro+watch...@chromium.org, blink-reviews-p...@chromium.org, rrsilva+wat...@google.com, prerenderi...@chromium.org, michaelcheco+wa...@google.com, nickdiego+wa...@igalia.com, pkotwic...@chromium.org, jdonnel...@chromium.org, print-revi...@chromium.org, npm+...@chromium.org, olesiamarukhno+wat...@google.com, tracing...@chromium.org, hashimo...@chromium.org, vasilii+watchlis...@chromium.org, ajayramamurt...@google.com, poscia...@chromium.org, toyosh...@chromium.org, wnwen...@chromium.org, joeantonetti+wa...@google.com, gogeral...@chromium.org, gangwu...@chromium.org, subresource-f...@chromium.org, jimmyxgong+watch...@chromium.org, zelin+watch-we...@chromium.org, jackshira+wa...@google.com, headless...@chromium.org, dpad+watch-input...@google.com, loading-re...@chromium.org, armalhotra+a...@google.com, csharrison+...@chromium.org, ukai+...@chromium.org, chfreme...@chromium.org, vakh+safe_br...@chromium.org, borealis-re...@google.com, wangdanny+watch-in...@google.com, dominickn+...@chromium.org, ajayramamurthy...@google.com, grt+...@chromium.org, francisjp...@google.com, ramyagopa...@google.com, gayane...@chromium.org, michaelcheco+...@google.com, jasonrhee+w...@google.com, gavinwill+watch-...@chromium.org, chrome-gr...@chromium.org, chadduffin+wa...@chromium.org, nyquis...@chromium.org, mar...@chromium.org, loading-rev...@chromium.org, android-web...@chromium.org, zhangwenyu+audi...@google.com, gordonseto+wa...@google.com, crisrael+wa...@google.com, scheduler...@chromium.org, cfredri...@chromium.org, toshikikikuch...@chromium.org, crisrael+w...@google.com, yhanad...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, chromeos-gfx-...@google.com, iwells...@chromium.org, gab+...@chromium.org, dmblac...@google.com, donnd...@chromium.org, thegreenf...@chromium.org, rtarpine+...@chromium.org, akingsb+wat...@google.com, keithle...@chromium.org, longbowei+watc...@google.com, max+watc...@igalia.com, cros-print...@google.com, xinghui...@chromium.org, hsuregan+wa...@chromium.org, telemetr...@chromium.org, polner+wat...@google.com, hais+wat...@google.com, lize...@chromium.org, jonmann+wat...@chromium.org, rousla...@chromium.org, crisrael+wa...@google.com, emircan+watch...@chromium.org, jinsukk...@chromium.org, jsaul+aut...@google.com, drott...@chromium.org, jonmann+w...@chromium.org, dmurph+watchi...@chromium.org, pushi+watc...@google.com, crostin...@chromium.org, suetfei+wa...@google.com, jdeblas...@chromium.org, croissant-...@chromium.org, fgal...@chromium.org, tommasin+watch-...@chromium.org, feliciac+au...@google.com, extension...@chromium.org, kaklilu+watch-...@chromium.org, network-ser...@chromium.org, hansenmichael...@google.com, hirokisa...@chromium.org, bmcquad...@chromium.org, binji...@chromium.org, gavinp...@chromium.org, phweis...@chromium.org, trewin...@google.com, jmedle...@chromium.org, security-...@chromium.org, cambickel+watc...@google.com, zentaro+wat...@chromium.org, djacob...@chromium.org, ozone-...@chromium.org, hansberry+wat...@chromium.org, navigation...@chromium.org, alancutter...@chromium.org, nikhilcn+wat...@google.com, rlp+...@chromium.org, mattsimm...@chromium.org, dominickn+wat...@chromium.org, andrewdear+wa...@google.com, yhanada+...@chromium.org, toshikikikuchi+...@chromium.org, njeunje+w...@chromium.org, crmulli...@chromium.org, ejcaruso+wa...@chromium.org, nicolas...@chromium.org, roblia...@chromium.org, hansberry+wa...@chromium.org, rginda...@chromium.org, nator...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, gordonseto+w...@google.com, ajayramamurth...@google.com, hansberry+w...@chromium.org, blink-rev...@chromium.org, siashah+au...@chromium.org, stevenjb+wa...@chromium.org, josiah...@chromium.org, dominickn+wat...@chromium.org, yusufo...@chromium.org, yhanada+...@chromium.org, dmblack+watc...@google.com, chromiumme...@microsoft.com, webapks-...@chromium.org, bici...@google.com, jophba...@chromium.org, hansberry+wa...@chromium.org, gcasto+w...@chromium.org, nwoked...@chromium.org, nektar...@chromium.org, blink-revi...@chromium.org, jorgel...@chromium.org, cblume...@chromium.org, apavlo...@chromium.org, jackshira+w...@google.com, michaelcheco+aud...@google.com, gordonseto+audi...@google.com, nikhilcn+wa...@google.com, odejesu...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, chrome-waff...@google.com, jonmann+wa...@chromium.org, ios-r...@chromium.org, rsleev...@chromium.org, erickun...@chromium.org, marimatthew+watc...@google.com, jackshira+w...@google.com, lizeb...@chromium.org, blundell+...@chromium.org, gogerald+pa...@chromium.org, ajayramamurth...@google.com, loading...@chromium.org, crisrael+...@google.com, zhangwen...@google.com, blink-re...@chromium.org, dullweb...@chromium.org, kouhe...@chromium.org, stevenj...@chromium.org, lwinston+watc...@google.com, marq+...@chromium.org, gavinp...@chromium.org, jshin...@chromium.org, azeemarshad+...@chromium.org, cros-ed...@google.com, arc-review...@google.com, tranbaod...@chromium.org, chromeos-kio...@google.com, gfhuan...@chromium.org, hansberry+wa...@chromium.org, yigu+...@chromium.org, ffred...@chromium.org, glider...@chromium.org, mac-r...@chromium.org, webauthn...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, tjohnsonkanu+w...@google.com, yhanada...@chromium.org, net-r...@chromium.org, michaelpg+w...@chromium.org, jonman...@chromium.org, dominickn+w...@chromium.org, gavin...@chromium.org, bhartmire+w...@google.com, ntp-dev...@chromium.org, owenzhang+audio...@google.com, kinuko...@chromium.org, lizeb+watch...@chromium.org, blink-re...@chromium.org, julietlevesque...@google.com, asumane...@google.com, amaliev+w...@chromium.org, cros-setti...@google.com, jsbell+ser...@chromium.org, jasonrobe...@google.com, shimazu...@chromium.org, mxcai+wat...@chromium.org, petewi...@chromium.org, mahmad...@chromium.org, chrome-intell...@chromium.org, kinuko+ser...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, zhangwenyu+wat...@google.com, jackshira+...@google.com, kyungjunle...@google.com, mfoltz...@chromium.org, fuchsia...@chromium.org, mreichhoff+watc...@chromium.org, mgiuca...@chromium.org, hsuregan+wat...@chromium.org, meilian...@chromium.org, rayanka...@chromium.org, andrewdear+w...@google.com, spang...@chromium.org, alemat...@chromium.org, penghu...@chromium.org, mickeybu...@chromium.org, mcasas+med...@chromium.org, filesapp...@chromium.org, chrome-b...@google.com, permissio...@chromium.org, eugeni...@chromium.org, gavin...@chromium.org, hiroshig...@chromium.org, srahim...@chromium.org, rouslan+au...@chromium.org, hanxi...@chromium.org, cros-system-ui-prod...@google.com, chromotin...@chromium.org, tgupta...@chromium.org, iclella...@chromium.org, translat...@chromium.org, sophey+wat...@chromium.org, jackshira+wa...@google.com, blink-re...@chromium.org, halliwe...@chromium.org, eme-r...@chromium.org, giovax...@chromium.org, jeffreycohen+watc...@chromium.org, dominickn+wat...@chromium.org, fserb...@chromium.org, chili...@chromium.org, jiajunz+wat...@google.com, ajayramamurthy+w...@google.com, blink-...@chromium.org
Attention needed from Olga Gerchikov

Sahir Vellani voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Wed, 17 Apr 2024 15:00:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 17, 2024, 11:41:52 AMApr 17
to Sahir Vellani, Robert Flack, Christian Biesinger, Charlie Hu, Xida Chen, Chromium Metrics Reviews, Daniel Andersson, Peter Beverloo, Rijubrata Bhaumik, Nico Weber, Enterprise Policy Reviews, Sam Zackrisson, Nate Chapin, Per Åhgren, Henrique Ferreiro, Dirk Schulze, Peter Williamson, Sadrul Chowdhury, Hongchan Choi, Alexis Menard, Kentaro Hara, Ilya Biryukov, Jiewei Qian, Wanming Lin, Peter Collingbourne, James Su, Sam Clegg, David Bokan, Mathias Bynens, David Worsham, Robert Kroeger, Ale Bzk, Mirko Bonadei, Fredrik Söderquist, Jerome Jiang, Lei Zhang, Ian Vollick, Zijie He, Akihiro Ota, Yoav Weiss (@Shopify), Sina Firoozabadi, Hans Wennborg, Hiroki Nakagawa, Tommy Li, Kaan Icer, W. James Maclean, Giovanni Ortuno Urquidi, Stephen Chenney, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Javier Fernandez, Simon Hangl, Alvin Ji, Mike Taylor, Raphael Kubo Da Costa, srirama chandra sekhar, Nektarios Paisios, Victor Tan, Nancy Wang, Kevin Babbitt, Reid Kleckner, Daniel Cheng, AyeAye, Olga Gerchikov, chromium...@chromium.org, rouslan+...@chromium.org, tburkar...@chromium.org, tsergea...@chromium.org, jz...@chromium.org, vinnypersky+...@google.com, anastas...@google.com, cclem+wat...@google.com, dominicc+...@chromium.org, performance-m...@chromium.org, fgorsk...@chromium.org, kinuko+...@chromium.org, ajayramamurthy...@google.com, rsesek...@chromium.org, robertshi...@chromium.org, yfriedm...@chromium.org, shimazu+se...@chromium.org, shend...@chromium.org, cros-essential...@chromium.org, blink-rev...@chromium.org, devtools...@chromium.org, dominickn+...@chromium.org, jiajunz+wa...@google.com, agriev...@chromium.org, pushi+wat...@google.com, dmurph+wat...@chromium.org, csharris...@chromium.org, andreaor...@chromium.org, katie...@chromium.org, siyua+aut...@chromium.org, caitkp...@chromium.org, eric.c...@apple.com, torne...@chromium.org, abigailbk...@google.com, blink-revie...@chromium.org, blink-revi...@chromium.org, dtseng+c...@chromium.org, jdh+wat...@chromium.org, chrome-mem...@google.com, dtapuska+ch...@chromium.org, tmartino+tran...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, chromeos-ca...@google.com, ryanchu...@chromium.org, crost...@chromium.org, wanderview...@chromium.org, servicewor...@chromium.org, webap...@microsoft.com, loyso...@chromium.org, yuezhang...@chromium.org, xlythe+wa...@google.com, cros-report...@google.com, dtseng...@chromium.org, ender...@chromium.org, michaelpg+wa...@chromium.org, video-networking...@google.com, jackshira+wat...@google.com, dimich...@chromium.org, pdf-r...@chromium.org, multipaste-...@google.com, shgar+aut...@google.com, asvitkine...@chromium.org, alexmo...@chromium.org, martijn...@martijnc.be, dmurph+watch...@chromium.org, pasko...@chromium.org, mattreyno...@chromium.org, tbarzi...@chromium.org, ios-revie...@chromium.org, xiaohui...@chromium.org, boujane+watch-...@google.com, dmurph+watching...@chromium.org, media-wi...@chromium.org, wychen...@chromium.org, blink-work...@chromium.org, scheduler-...@chromium.org, zentaro+sca...@chromium.org, ajayramamu...@google.com, chadduffin+w...@chromium.org, dullweber+watch...@chromium.org, mxcai+watch...@chromium.org, shannc...@chromium.org, rkgibso...@chromium.org, wfh+...@chromium.org, dpr...@google.com, tote-eng...@google.com, bcb+watch-pl...@chromium.org, emi...@google.com, jessemcke...@google.com, cclem+wat...@google.com, devtools-re...@chromium.org, droger+w...@chromium.org, steimel+...@chromium.org, chromium-...@engflow.com, wittma...@chromium.org, haoliu...@chromium.org, jonmann+watc...@chromium.org, pushi+wa...@google.com, chikamu...@chromium.org, aleventhal...@chromium.org, yuzo+...@chromium.org, gavinwill+sc...@chromium.org, glenro...@chromium.org, msrame...@chromium.org, wnwen+w...@chromium.org, blink-revie...@chromium.org, shuche...@chromium.org, ydago...@chromium.org, wiss+watc...@chromium.org, davidj...@chromium.org, hansberry+w...@chromium.org, feature-v...@chromium.org, olesiamaru...@google.com, andrewxu+wat...@google.com, minap+watch-p...@google.com, hidehik...@chromium.org, hayato...@chromium.org, nburris+pa...@chromium.org, creis...@chromium.org, michaelpg+wa...@chromium.org, sky+...@chromium.org, pdr+svgw...@chromium.org, alimariam+watch...@google.com, print-rev...@chromium.org, xhwang...@chromium.org, gbiv+...@chromium.org, tommyw+w...@chromium.org, horo+...@chromium.org, nona+...@chromium.org, chasej...@chromium.org, twelling...@chromium.org, feature-me...@chromium.org, lingqi...@chromium.org, media-cro...@chromium.org, pmonett...@chromium.org, michaelcheco+watch-i...@google.com, zackha...@chromium.org, twifka...@chromium.org, gbb-cct...@google.com, dominickn+watch-...@chromium.org, core-web-vita...@chromium.org, ericwillige...@chromium.org, jeffreycohen+...@chromium.org, dfried...@chromium.org, khorimoto+wa...@chromium.org, kuragin+web-ap...@chromium.org, oshima...@chromium.org, tjohnsonkanu+...@google.com, elkuri...@chromium.org, fuzzin...@chromium.org, dtraino...@chromium.org, lcwu+...@chromium.org, zentaro+watch-a...@chromium.org, blink-rev...@chromium.org, jackshira+wa...@google.com, dewitt...@chromium.org, fmalit...@chromium.org, jackshira+wa...@google.com, dclasson+w...@google.com, drott+bl...@chromium.org, alandin...@chromium.org, philli...@chromium.org, bnc+...@chromium.org, jackshira+w...@google.com, harringt...@chromium.org, browser-comp...@chromium.org, khorimoto+w...@chromium.org, tluk+...@chromium.org, dougste...@chromium.org, asvitki...@chromium.org, wry+watc...@chromium.org, cc-...@chromium.org, azeemarshad+w...@chromium.org, blink-revie...@chromium.org, phoglun...@chromium.org, penghuan...@chromium.org, druber...@chromium.org, dibyapal+wa...@chromium.org, andysjl...@chromium.org, dmurph+watc...@chromium.org, kouhei...@chromium.org, jimmyxgong+wat...@chromium.org, zentaro+watch...@chromium.org, blink-reviews-p...@chromium.org, rrsilva+wat...@google.com, prerenderi...@chromium.org, michaelcheco+wa...@google.com, nickdiego+wa...@igalia.com, pkotwic...@chromium.org, jdonnel...@chromium.org, print-revi...@chromium.org, npm+...@chromium.org, olesiamarukhno+wat...@google.com, tracing...@chromium.org, hashimo...@chromium.org, vasilii+watchlis...@chromium.org, ajayramamurt...@google.com, poscia...@chromium.org, toyosh...@chromium.org, wnwen...@chromium.org, joeantonetti+wa...@google.com, gogeral...@chromium.org, gangwu...@chromium.org, subresource-f...@chromium.org, jimmyxgong+watch...@chromium.org, zelin+watch-we...@chromium.org, jackshira+wa...@google.com, headless...@chromium.org, dpad+watch-input...@google.com, loading-re...@chromium.org, armalhotra+a...@google.com, csharrison+...@chromium.org, ukai+...@chromium.org, chfreme...@chromium.org, vakh+safe_br...@chromium.org, borealis-re...@google.com, wangdanny+watch-in...@google.com, dominickn+...@chromium.org, ajayramamurthy...@google.com, grt+...@chromium.org, francisjp...@google.com, ramyagopa...@google.com, gayane...@chromium.org, michaelcheco+...@google.com, jasonrhee+w...@google.com, gavinwill+watch-...@chromium.org, chrome-gr...@chromium.org, chadduffin+wa...@chromium.org, nyquis...@chromium.org, mar...@chromium.org, loading-rev...@chromium.org, android-web...@chromium.org, zhangwenyu+audi...@google.com, gordonseto+wa...@google.com, crisrael+wa...@google.com, scheduler...@chromium.org, cfredri...@chromium.org, toshikikikuch...@chromium.org, crisrael+w...@google.com, yhanad...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, chromeos-gfx-...@google.com, iwells...@chromium.org, gab+...@chromium.org, dmblac...@google.com, donnd...@chromium.org, thegreenf...@chromium.org, rtarpine+...@chromium.org, akingsb+wat...@google.com, keithle...@chromium.org, longbowei+watc...@google.com, max+watc...@igalia.com, cros-print...@google.com, xinghui...@chromium.org, hsuregan+wa...@chromium.org, telemetr...@chromium.org, polner+wat...@google.com, hais+wat...@google.com, lize...@chromium.org, jonmann+wat...@chromium.org, rousla...@chromium.org, crisrael+wa...@google.com, emircan+watch...@chromium.org, jinsukk...@chromium.org, jsaul+aut...@google.com, drott...@chromium.org, jonmann+w...@chromium.org, dmurph+watchi...@chromium.org, pushi+watc...@google.com, crostin...@chromium.org, suetfei+wa...@google.com, jdeblas...@chromium.org, croissant-...@chromium.org, fgal...@chromium.org, tommasin+watch-...@chromium.org, feliciac+au...@google.com, extension...@chromium.org, kaklilu+watch-...@chromium.org, network-ser...@chromium.org, hansenmichael...@google.com, hirokisa...@chromium.org, bmcquad...@chromium.org, binji...@chromium.org, gavinp...@chromium.org, phweis...@chromium.org, trewin...@google.com, jmedle...@chromium.org, security-...@chromium.org, cambickel+watc...@google.com, zentaro+wat...@chromium.org, djacob...@chromium.org, ozone-...@chromium.org, hansberry+wat...@chromium.org, navigation...@chromium.org, alancutter...@chromium.org, nikhilcn+wat...@google.com, rlp+...@chromium.org, mattsimm...@chromium.org, dominickn+wat...@chromium.org, andrewdear+wa...@google.com, yhanada+...@chromium.org, toshikikikuchi+...@chromium.org, njeunje+w...@chromium.org, crmulli...@chromium.org, ejcaruso+wa...@chromium.org, nicolas...@chromium.org, roblia...@chromium.org, hansberry+wa...@chromium.org, rginda...@chromium.org, nator...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, gordonseto+w...@google.com, ajayramamurth...@google.com, hansberry+w...@chromium.org, blink-rev...@chromium.org, siashah+au...@chromium.org, stevenjb+wa...@chromium.org, josiah...@chromium.org, dominickn+wat...@chromium.org, yusufo...@chromium.org, yhanada+...@chromium.org, dmblack+watc...@google.com, chromiumme...@microsoft.com, webapks-...@chromium.org, bici...@google.com, jophba...@chromium.org, hansberry+wa...@chromium.org, gcasto+w...@chromium.org, nwoked...@chromium.org, nektar...@chromium.org, blink-revi...@chromium.org, jorgel...@chromium.org, cblume...@chromium.org, apavlo...@chromium.org, jackshira+w...@google.com, michaelcheco+aud...@google.com, gordonseto+audi...@google.com, nikhilcn+wa...@google.com, odejesu...@chromium.org, chromium-a...@chromium.org, dom+...@chromium.org, chrome-waff...@google.com, jonmann+wa...@chromium.org, ios-r...@chromium.org, rsleev...@chromium.org, erickun...@chromium.org, marimatthew+watc...@google.com, jackshira+w...@google.com, lizeb...@chromium.org, blundell+...@chromium.org, gogerald+pa...@chromium.org, ajayramamurth...@google.com, loading...@chromium.org, crisrael+...@google.com, zhangwen...@google.com, blink-re...@chromium.org, dullweb...@chromium.org, kouhe...@chromium.org, stevenj...@chromium.org, lwinston+watc...@google.com, marq+...@chromium.org, gavinp...@chromium.org, jshin...@chromium.org, azeemarshad+...@chromium.org, cros-ed...@google.com, arc-review...@google.com, tranbaod...@chromium.org, chromeos-kio...@google.com, gfhuan...@chromium.org, hansberry+wa...@chromium.org, yigu+...@chromium.org, ffred...@chromium.org, glider...@chromium.org, mac-r...@chromium.org, webauthn...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, tjohnsonkanu+w...@google.com, yhanada...@chromium.org, net-r...@chromium.org, michaelpg+w...@chromium.org, jonman...@chromium.org, dominickn+w...@chromium.org, gavin...@chromium.org, bhartmire+w...@google.com, ntp-dev...@chromium.org, owenzhang+audio...@google.com, kinuko...@chromium.org, lizeb+watch...@chromium.org, blink-re...@chromium.org, julietlevesque...@google.com, asumane...@google.com, amaliev+w...@chromium.org, cros-setti...@google.com, jsbell+ser...@chromium.org, jasonrobe...@google.com, shimazu...@chromium.org, mxcai+wat...@chromium.org, petewi...@chromium.org, mahmad...@chromium.org, chrome-intell...@chromium.org, kinuko+ser...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, zhangwenyu+wat...@google.com, jackshira+...@google.com, kyungjunle...@google.com, mfoltz...@chromium.org, fuchsia...@chromium.org, mreichhoff+watc...@chromium.org, mgiuca...@chromium.org, hsuregan+wat...@chromium.org, meilian...@chromium.org, rayanka...@chromium.org, andrewdear+w...@google.com, spang...@chromium.org, alemat...@chromium.org, penghu...@chromium.org, mickeybu...@chromium.org, mcasas+med...@chromium.org, filesapp...@chromium.org, chrome-b...@google.com, permissio...@chromium.org, eugeni...@chromium.org, gavin...@chromium.org, hiroshig...@chromium.org, srahim...@chromium.org, rouslan+au...@chromium.org, hanxi...@chromium.org, cros-system-ui-prod...@google.com, chromotin...@chromium.org, tgupta...@chromium.org, iclella...@chromium.org, translat...@chromium.org, sophey+wat...@chromium.org, jackshira+wa...@google.com, blink-re...@chromium.org, halliwe...@chromium.org, eme-r...@chromium.org, giovax...@chromium.org, jeffreycohen+watc...@chromium.org, dominickn+wat...@chromium.org, fserb...@chromium.org, chili...@chromium.org, jiajunz+wat...@google.com, ajayramamurthy+w...@google.com, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Assign unique id to mouse pointer

This changelist assigns a unique id to a mouse pointer, treating it like any other pointer event. However, since a web pointer event of type mouse does not come with a device id from the browser process, the assigned unique id is stored in a separate member rather than the BrowserDeviceIdToBlinkDeviceIdMap.

Additionally, 0 is added to the list of valid values for the pointer event. Context: https://github.com/w3c/pointerevents/pull/495
Change-Id: I8ecfc8f6577f3639739d32b2d34199ced420dd3f
Reviewed-by: Robert Flack <fla...@chromium.org>
Commit-Queue: Sahir Vellani <sahir....@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1288737}
Files:
  • M third_party/blink/renderer/core/events/pointer_event_factory.cc
  • M third_party/blink/renderer/core/events/pointer_event_factory.h
  • M third_party/blink/renderer/core/events/pointer_event_factory_test.cc
Change size: S
Delta: 3 files changed, 10 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Robert Flack
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ecfc8f6577f3639739d32b2d34199ced420dd3f
Gerrit-Change-Number: 5445186
Gerrit-PatchSet: 7
Gerrit-Owner: Sahir Vellani <sahir....@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Sahir Vellani <sahir....@microsoft.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Alvin Ji <alv...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Charlie Hu <chen...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages