Add ReuseMediaPlayer switch. [chromium/src : main]
Frank Liberato (Gerrit)
Attention is currently required from: Dan Sanders, Robert Flack.
Frank Liberato would like Dan Sanders and Robert Flack to review this change.
Add ReuseMediaPlayer switch.
When enabled, HTMLMediaElement will try to re-use the player across
document movement.
This is not at all safe to enable right now. It's intended to
allow incremental implementation of player reuse.
Bug: 1252550
Change-Id: I20ac59340e99fd02732174866fa5cfa27c0b53f8
---
M media/base/media_switches.cc
M media/base/media_switches.h
M third_party/blink/renderer/core/html/media/html_media_element.cc
3 files changed, 14 insertions(+), 1 deletion(-)
To view, visit change 3180280. To unsubscribe, or for help writing mail filters, visit settings.
Frank Liberato (Gerrit)
Attention is currently required from: Dan Sanders, Robert Flack.
1 comment:
Patchset:
thanks
-fl
To view, visit change 3180280. To unsubscribe, or for help writing mail filters, visit settings.
Dan Sanders (Gerrit)
Attention is currently required from: Robert Flack, Frank Liberato.
Patch set 2:Code-Review +1
Robert Flack (Gerrit)
Attention is currently required from: Frank Liberato.
Patch set 2:Code-Review +1
1 comment:
Patchset:
To view, visit change 3180280. To unsubscribe, or for help writing mail filters, visit settings.
Frank Liberato (Gerrit)
2 comments:
Patchset:
Patchset:
To view, visit change 3180280. To unsubscribe, or for help writing mail filters, visit settings.
Frank Liberato (Gerrit)
Attention is currently required from: Philip Rogers.
Frank Liberato would like Philip Rogers to review this change.
Add ReuseMediaPlayer switch.
When enabled, HTMLMediaElement will try to re-use the player across
document movement.
This is not at all safe to enable right now. It's intended to
allow incremental implementation of player reuse.
Bug: 1252550
Change-Id: I20ac59340e99fd02732174866fa5cfa27c0b53f8
---
M media/base/media_switches.cc
M media/base/media_switches.h
M third_party/blink/renderer/core/html/media/html_media_element.cc
M third_party/blink/renderer/core/html/media/html_media_element_test.cc
M third_party/blink/renderer/platform/testing/empty_web_media_player.h
5 files changed, 99 insertions(+), 3 deletions(-)
Frank Liberato (Gerrit)
Attention is currently required from: Philip Rogers.
1 comment:
Patchset:
pdr: PTAL @ empty_web_media_player.h . it doesn't look like anything depends on the old behavior, though i can implement it on the test-specific MockWebMediaPlayer if you have concerns.
thanks
-fl
To view, visit change 3180280. To unsubscribe, or for help writing mail filters, visit settings.
Philip Rogers (Gerrit)
Attention is currently required from: Frank Liberato.
Patch set 5:Code-Review +1
1 comment:
Patchset:
LGTM
To view, visit change 3180280. To unsubscribe, or for help writing mail filters, visit settings.
Frank Liberato (Gerrit)
Patch set 5:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Add ReuseMediaPlayer switch.
When enabled, HTMLMediaElement will try to re-use the player across
document movement.
This is not at all safe to enable right now. It's intended to
allow incremental implementation of player reuse.
Bug: 1252550
Change-Id: I20ac59340e99fd02732174866fa5cfa27c0b53f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180280
Reviewed-by: Philip Rogers <p...@chromium.org>
Reviewed-by: Dan Sanders <sand...@chromium.org>
Reviewed-by: Robert Flack <fla...@chromium.org>
Commit-Queue: Frank Liberato <libe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926851}
---
M media/base/media_switches.cc
M third_party/blink/renderer/core/html/media/html_media_element.cc
M media/base/media_switches.h
M third_party/blink/renderer/platform/testing/empty_web_media_player.h
M third_party/blink/renderer/core/html/media/html_media_element_test.cc
5 files changed, 121 insertions(+), 3 deletions(-)