Establish submenu relationships only with toggle-menu, not show/hide-menu. [chromium/src : main]
0 views
Skip to first unread message
David Baron (Gerrit)
Jan 23, 2026, 2:18:54 PMJan 23
to David Baron, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Jan 23, 2026, 7:13:21 PMJan 23
to David Baron, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Baron
Joey Arhar voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 23, 2026, 7:25:03 PMJan 23
to David Baron, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Baron
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57321.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jan 23, 2026, 8:11:55 PMJan 23
to David Baron, Blink W3C Test Autoroller, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
David Baron voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 23, 2026, 9:08:55 PMJan 23
to David Baron, Blink W3C Test Autoroller, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Establish submenu relationships only with toggle-menu, not show/hide-menu.
This makes submenu relationships be established only by the toggle-menu
command, and not also by the show-menu and hide-menu commands as before.
This is because submenu relationships create builtin behaviors that both
show and hide menus, so establishing them for show-menu and hide-menu
commands either doesn't fully make sense or requires a bunch of complex
behavior that nobody actually wants (for example, having submenus that
open-on-hover but then stay open).
Bug: 406566432
Change-Id: I9e467afa88eaf1ebacf37c83f2dc4bcf79c8d337
Commit-Queue: David Baron <dba...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1574094}
Files:
- M third_party/blink/renderer/core/html/html_menu_item_element.cc
- M third_party/blink/web_tests/external/wpt/html/semantics/menu/tentative/focus-menu-elements-nested-arrowoperations.html
Change size: S
Delta: 2 files changed, 25 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joey Arhar
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 23, 2026, 9:43:25 PMJan 23
to Chromium LUCI CQ, David Baron, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57321
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages