Attention is currently required from: Justin Novosad.
Aaron Krajeski would like Justin Novosad to review this change.
Remove canvas the HitRegions feature
It was proposed and implemented 3 years ago, but never fully shipped.
There's not enough developer interest to justify keeping this much
complexity in the code base.
Once this is gone we can also simplify calls in the MouseEventManager
crrev.com/c/3168812
Bug: 1249855
Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
---
M third_party/blink/renderer/bindings/idl_in_modules.gni
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/core/input/mouse_event_manager.cc
M third_party/blink/renderer/core/input/pointer_event_manager.cc
M third_party/blink/renderer/core/input/touch_event_manager.cc
M third_party/blink/renderer/modules/BUILD.gn
M third_party/blink/renderer/modules/canvas/BUILD.gn
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.idl
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_api_test.cc
D third_party/blink/renderer/modules/canvas/canvas2d/hit_region.cc
D third_party/blink/renderer/modules/canvas/canvas2d/hit_region.h
D third_party/blink/renderer/modules/canvas/canvas2d/hit_region_options.idl
D third_party/blink/renderer/modules/canvas/canvas2d/testing/internals_canvas_rendering_context_2d.cc
D third_party/blink/renderer/modules/canvas/canvas2d/testing/internals_canvas_rendering_context_2d.h
D third_party/blink/renderer/modules/canvas/canvas2d/testing/internals_canvas_rendering_context_2d.idl
D third_party/blink/web_tests/external/wpt/html/canvas/element/manual/hit-regions/addHitRegions-NotSupportedError-01.html
D third_party/blink/web_tests/external/wpt/html/canvas/element/manual/hit-regions/hitregions-members-exist.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-accessibility-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-basic-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-clear-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-clip-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-css-transform-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-device-pixel-ratio-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-event-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-exception-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fallback-element-test-1.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fallback-element-test-2.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fallback-element-test-3.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fill-rule-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-path2d-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-path2d-transform-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-scale-factor.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-transform-test.html
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
39 files changed, 1 insertion(+), 2,326 deletions(-)
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Justin Novosad.
Attention is currently required from: Justin Novosad.
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/30850.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Attention is currently required from: Aaron Krajeski, Justin Novosad.
Patch set 3:Code-Review +1
Attention is currently required from: Aaron Krajeski.
1 comment:
Patchset:
You missed the "region" attribute on the Touch interface.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/input/touch.idl;l=47
There is also a "region" attribute on the MouseEvent interface:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/events/mouse_event.idl;l=70
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Patchset:
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Aaron Krajeski.
Patch set 4:Code-Review +1
1 comment:
Patchset:
LGTM for changes to accessibility test
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 4:Code-Review +1
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
1 comment:
Patchset:
LGTM for changes to accessibility test
Thanks!
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Jeremy Roman.
Aaron Krajeski would like Jeremy Roman to review this change.
Remove canvas the HitRegions feature
It was proposed and implemented 3 years ago, but never fully shipped.
There's not enough developer interest to justify keeping this much
complexity in the code base.
Once this is gone we can also simplify calls in the MouseEventManager
crrev.com/c/3168812
Bug: 1249855
Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
---
M third_party/blink/renderer/bindings/generated_in_modules.gni
40 files changed, 1 insertion(+), 2,329 deletions(-)
Attention is currently required from: Jeremy Roman.
1 comment:
Patchset:
Hey Jeremy! Just need your +1 for the change to BUILD.gn
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Jeremy Roman.
2 comments:
Patchset:
Also, remove this: […]
Cool! I'll do this in the next CL since this one is already XL
You missed the "region" attribute on the Touch interface. […]
Cool! I'll do this in the next CL since this one is already XL
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Aaron Krajeski.
Patch set 4:Code-Review +1
1 comment:
Patchset:
BUILD.gn lgtm
Did you mean to self-CR+1 this? Gerrit is showing me this:
⚠ WARNING: The owner of this change has voted on the Code-Review label. Self-approving a change is not allowed and might prevent it from being submitted.
To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Aaron Krajeski.
Patch set 4:Commit-Queue +2
Patch set 5:Code-Review +1Commit-Queue +2
Chromium LUCI CQ submitted this change.
Remove canvas the HitRegions feature
It was proposed and implemented 3 years ago, but never fully shipped.
There's not enough developer interest to justify keeping this much
complexity in the code base.
Once this is gone we can also simplify calls in the MouseEventManager
crrev.com/c/3168812
Bug: 1249855
Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166851
Reviewed-by: Aaron Krajeski <aar...@chromium.org>
Reviewed-by: Nektarios Paisios <nek...@chromium.org>
Reviewed-by: Justin Novosad <ju...@chromium.org>
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Reviewed-by: Juanmi Huertas <juan...@chromium.org>
Commit-Queue: Aaron Krajeski <aar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923124}
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/30850