Remove canvas the HitRegions feature [chromium/src : main]

0 views
Skip to first unread message

Aaron Krajeski (Gerrit)

unread,
Sep 17, 2021, 3:09:21 PM9/17/21
to Justin Novosad, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org

Attention is currently required from: Justin Novosad.

Aaron Krajeski would like Justin Novosad to review this change.

View Change

Remove canvas the HitRegions feature

It was proposed and implemented 3 years ago, but never fully shipped.
There's not enough developer interest to justify keeping this much
complexity in the code base.

Once this is gone we can also simplify calls in the MouseEventManager
crrev.com/c/3168812

Bug: 1249855
Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
---
M third_party/blink/renderer/bindings/idl_in_modules.gni
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/core/input/mouse_event_manager.cc
M third_party/blink/renderer/core/input/pointer_event_manager.cc
M third_party/blink/renderer/core/input/touch_event_manager.cc
M third_party/blink/renderer/modules/BUILD.gn
M third_party/blink/renderer/modules/canvas/BUILD.gn
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.idl
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_api_test.cc
D third_party/blink/renderer/modules/canvas/canvas2d/hit_region.cc
D third_party/blink/renderer/modules/canvas/canvas2d/hit_region.h
D third_party/blink/renderer/modules/canvas/canvas2d/hit_region_options.idl
D third_party/blink/renderer/modules/canvas/canvas2d/testing/internals_canvas_rendering_context_2d.cc
D third_party/blink/renderer/modules/canvas/canvas2d/testing/internals_canvas_rendering_context_2d.h
D third_party/blink/renderer/modules/canvas/canvas2d/testing/internals_canvas_rendering_context_2d.idl
D third_party/blink/web_tests/external/wpt/html/canvas/element/manual/hit-regions/addHitRegions-NotSupportedError-01.html
D third_party/blink/web_tests/external/wpt/html/canvas/element/manual/hit-regions/hitregions-members-exist.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-accessibility-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-basic-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-clear-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-clip-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-css-transform-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-device-pixel-ratio-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-event-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-exception-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fallback-element-test-1.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fallback-element-test-2.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fallback-element-test-3.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-fill-rule-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-path2d-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-path2d-transform-test.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-scale-factor.html
D third_party/blink/web_tests/fast/canvas/canvas-hit-regions-transform-test.html
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
39 files changed, 1 insertion(+), 2,326 deletions(-)


To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
Gerrit-Change-Number: 3166851
Gerrit-PatchSet: 3
Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alice Boxhall <abox...@chromium.org>
Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Justin Novosad <ju...@chromium.org>
Gerrit-MessageType: newchange

Aaron Krajeski (Gerrit)

unread,
Sep 17, 2021, 3:09:32 PM9/17/21
to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Justin Novosad, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

Attention is currently required from: Justin Novosad.

View Change

    To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
    Gerrit-Change-Number: 3166851
    Gerrit-PatchSet: 3
    Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
    Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
    Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alice Boxhall <abox...@chromium.org>
    Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
    Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Justin Novosad <ju...@chromium.org>
    Gerrit-Comment-Date: Fri, 17 Sep 2021 19:09:16 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Blink WPT Bot (Gerrit)

    unread,
    Sep 17, 2021, 3:13:40 PM9/17/21
    to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Justin Novosad, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

    Attention is currently required from: Justin Novosad.

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/30850.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    View Change

      To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
      Gerrit-Change-Number: 3166851
      Gerrit-PatchSet: 3
      Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
      Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
      Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Alice Boxhall <abox...@chromium.org>
      Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
      Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
      Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
      Gerrit-Attention: Justin Novosad <ju...@chromium.org>
      Gerrit-Comment-Date: Fri, 17 Sep 2021 19:13:30 +0000

      Juanmi Huertas (Gerrit)

      unread,
      Sep 17, 2021, 3:18:09 PM9/17/21
      to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Blink WPT Bot, Justin Novosad, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

      Attention is currently required from: Aaron Krajeski, Justin Novosad.

      Patch set 3:Code-Review +1

      View Change

        To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
        Gerrit-Change-Number: 3166851
        Gerrit-PatchSet: 3
        Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
        Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Alice Boxhall <abox...@chromium.org>
        Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
        Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
        Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
        Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Attention: Justin Novosad <ju...@chromium.org>
        Gerrit-Comment-Date: Fri, 17 Sep 2021 19:17:58 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        Gerrit-MessageType: comment

        Justin Novosad (Gerrit)

        unread,
        Sep 17, 2021, 3:21:12 PM9/17/21
        to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

        Attention is currently required from: Aaron Krajeski.

        View Change

        1 comment:

        To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
        Gerrit-Change-Number: 3166851
        Gerrit-PatchSet: 3
        Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
        Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Alice Boxhall <abox...@chromium.org>
        Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
        Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
        Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
        Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Comment-Date: Fri, 17 Sep 2021 19:21:02 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Gerrit-MessageType: comment

        Justin Novosad (Gerrit)

        unread,
        Sep 17, 2021, 3:24:39 PM9/17/21
        to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

        Attention is currently required from: Aaron Krajeski.

        View Change

        1 comment:

        To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
        Gerrit-Change-Number: 3166851
        Gerrit-PatchSet: 3
        Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
        Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Alice Boxhall <abox...@chromium.org>
        Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
        Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
        Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
        Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Comment-Date: Fri, 17 Sep 2021 19:24:26 +0000

        Nektarios Paisios (Gerrit)

        unread,
        Sep 20, 2021, 9:46:52 AM9/20/21
        to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Juanmi Huertas, Blink WPT Bot, Justin Novosad, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

        Attention is currently required from: Aaron Krajeski.

        Patch set 4:Code-Review +1

        View Change

        1 comment:

        To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
        Gerrit-Change-Number: 3166851
        Gerrit-PatchSet: 4
        Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
        Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
        Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Alice Boxhall <abox...@chromium.org>
        Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
        Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
        Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
        Gerrit-Comment-Date: Mon, 20 Sep 2021 13:46:40 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Gerrit-MessageType: comment

        Justin Novosad (Gerrit)

        unread,
        Sep 20, 2021, 9:48:11 AM9/20/21
        to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

        Attention is currently required from: Aaron Krajeski.

        Patch set 4:Code-Review +1

        View Change

          To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
          Gerrit-Change-Number: 3166851
          Gerrit-PatchSet: 4
          Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
          Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
          Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
          Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
          Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Alice Boxhall <abox...@chromium.org>
          Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
          Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
          Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Kentaro Hara <har...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
          Gerrit-Comment-Date: Mon, 20 Sep 2021 13:47:59 +0000

          Aaron Krajeski (Gerrit)

          unread,
          Sep 20, 2021, 11:45:14 AM9/20/21
          to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

          Patch set 4:Code-Review +1

          View Change

            To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            Gerrit-Change-Number: 3166851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
            Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
            Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
            Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
            Gerrit-CC: Alice Boxhall <abox...@chromium.org>
            Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
            Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
            Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
            Gerrit-Comment-Date: Mon, 20 Sep 2021 15:44:59 +0000

            Aaron Krajeski (Gerrit)

            unread,
            Sep 20, 2021, 1:24:27 PM9/20/21
            to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

            View Change

            1 comment:

            • Patchset:

              • Thanks!

            To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            Gerrit-Change-Number: 3166851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
            Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
            Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
            Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
            Gerrit-CC: Alice Boxhall <abox...@chromium.org>
            Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
            Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
            Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
            Gerrit-Comment-Date: Mon, 20 Sep 2021 17:24:18 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Nektarios Paisios <nek...@chromium.org>
            Gerrit-MessageType: comment

            Aaron Krajeski (Gerrit)

            unread,
            Sep 20, 2021, 1:32:10 PM9/20/21
            to Jeremy Roman, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Justin Novosad, Nektarios Paisios, Juanmi Huertas

            Attention is currently required from: Jeremy Roman.

            Aaron Krajeski would like Jeremy Roman to review this change.

            View Change

            Remove canvas the HitRegions feature

            It was proposed and implemented 3 years ago, but never fully shipped.
            There's not enough developer interest to justify keeping this much
            complexity in the code base.

            Once this is gone we can also simplify calls in the MouseEventManager
            crrev.com/c/3168812

            Bug: 1249855
            Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            ---
            M third_party/blink/renderer/bindings/generated_in_modules.gni
            40 files changed, 1 insertion(+), 2,329 deletions(-)


            To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            Gerrit-Change-Number: 3166851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
            Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
            Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
            Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
            Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
            Gerrit-CC: Alice Boxhall <abox...@chromium.org>
            Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
            Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
            Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
            Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
            Gerrit-MessageType: newchange

            Aaron Krajeski (Gerrit)

            unread,
            Sep 20, 2021, 1:32:22 PM9/20/21
            to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

            Attention is currently required from: Jeremy Roman.

            View Change

            1 comment:

            • Patchset:

              • Patch Set #4:

                Hey Jeremy! Just need your +1 for the change to BUILD.gn

            To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            Gerrit-Change-Number: 3166851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
            Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
            Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
            Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
            Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
            Gerrit-CC: Alice Boxhall <abox...@chromium.org>
            Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
            Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
            Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
            Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
            Gerrit-Comment-Date: Mon, 20 Sep 2021 17:32:06 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Gerrit-MessageType: comment

            Aaron Krajeski (Gerrit)

            unread,
            Sep 20, 2021, 1:32:50 PM9/20/21
            to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

            Attention is currently required from: Jeremy Roman.

            View Change

            2 comments:

            • Patchset:

              • Patch Set #3:

                Also, remove this: […]

                Cool! I'll do this in the next CL since this one is already XL

              • Patch Set #3:

                You missed the "region" attribute on the Touch interface. […]

                Cool! I'll do this in the next CL since this one is already XL

            To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            Gerrit-Change-Number: 3166851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
            Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
            Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
            Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
            Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
            Gerrit-CC: Alice Boxhall <abox...@chromium.org>
            Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
            Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
            Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
            Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
            Gerrit-Comment-Date: Mon, 20 Sep 2021 17:32:40 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Justin Novosad <ju...@chromium.org>
            Gerrit-MessageType: comment

            Jeremy Roman (Gerrit)

            unread,
            Sep 20, 2021, 1:41:02 PM9/20/21
            to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

            Attention is currently required from: Aaron Krajeski.

            Patch set 4:Code-Review +1

            View Change

            1 comment:

            • Patchset:

              • Patch Set #4:

                BUILD.gn lgtm

                Did you mean to self-CR+1 this? Gerrit is showing me this:

                ⚠ WARNING: The owner of this change has voted on the Code-Review label. Self-approving a change is not allowed and might prevent it from being submitted.

            To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
            Gerrit-Change-Number: 3166851
            Gerrit-PatchSet: 4
            Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
            Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
            Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
            Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
            Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
            Gerrit-CC: Alice Boxhall <abox...@chromium.org>
            Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
            Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
            Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
            Gerrit-CC: Kentaro Hara <har...@chromium.org>
            Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
            Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
            Gerrit-Comment-Date: Mon, 20 Sep 2021 17:40:53 +0000

            Aaron Krajeski (Gerrit)

            unread,
            Sep 20, 2021, 3:54:27 PM9/20/21
            to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

            Attention is currently required from: Aaron Krajeski.

            Patch set 4:Commit-Queue +2

            View Change

              To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
              Gerrit-Change-Number: 3166851
              Gerrit-PatchSet: 4
              Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
              Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
              Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
              Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
              Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
              Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
              Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
              Gerrit-CC: Alice Boxhall <abox...@chromium.org>
              Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
              Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
              Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
              Gerrit-CC: Kentaro Hara <har...@chromium.org>
              Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
              Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
              Gerrit-Comment-Date: Mon, 20 Sep 2021 19:54:18 +0000

              Aaron Krajeski (Gerrit)

              unread,
              Sep 20, 2021, 7:04:27 PM9/20/21
              to abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Chromium LUCI CQ, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

              Patch set 5:Code-Review +1Commit-Queue +2

              View Change

                To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
                Gerrit-Change-Number: 3166851
                Gerrit-PatchSet: 5
                Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
                Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
                Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
                Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
                Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
                Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
                Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
                Gerrit-CC: Alice Boxhall <abox...@chromium.org>
                Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
                Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
                Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
                Gerrit-CC: Kentaro Hara <har...@chromium.org>
                Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
                Gerrit-Comment-Date: Mon, 20 Sep 2021 23:04:17 +0000

                Chromium LUCI CQ (Gerrit)

                unread,
                Sep 20, 2021, 7:09:11 PM9/20/21
                to Aaron Krajeski, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Blink WPT Bot, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

                Chromium LUCI CQ submitted this change.

                View Change


                Approvals: Jeremy Roman: Looks good to me Justin Novosad: Looks good to me Nektarios Paisios: Looks good to me Aaron Krajeski: Looks good to me; Commit Juanmi Huertas: Looks good to me
                Remove canvas the HitRegions feature

                It was proposed and implemented 3 years ago, but never fully shipped.
                There's not enough developer interest to justify keeping this much
                complexity in the code base.

                Once this is gone we can also simplify calls in the MouseEventManager
                crrev.com/c/3168812

                Bug: 1249855
                Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
                Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166851
                Reviewed-by: Aaron Krajeski <aar...@chromium.org>
                Reviewed-by: Nektarios Paisios <nek...@chromium.org>
                Reviewed-by: Justin Novosad <ju...@chromium.org>
                Reviewed-by: Jeremy Roman <jbr...@chromium.org>
                Reviewed-by: Juanmi Huertas <juan...@chromium.org>
                Commit-Queue: Aaron Krajeski <aar...@chromium.org>
                Cr-Commit-Position: refs/heads/main@{#923124}

                To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
                Gerrit-Change-Number: 3166851
                Gerrit-PatchSet: 6
                Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
                Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
                Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
                Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
                Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
                Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
                Gerrit-CC: Alice Boxhall <abox...@chromium.org>
                Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
                Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
                Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
                Gerrit-CC: Kentaro Hara <har...@chromium.org>
                Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
                Gerrit-MessageType: merged

                Blink WPT Bot (Gerrit)

                unread,
                Sep 20, 2021, 7:38:30 PM9/20/21
                to Aaron Krajeski, Chromium LUCI CQ, abigailbk...@google.com, aboxhal...@chromium.org, aleventhal...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dmazzon...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, hirokisa...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Jeremy Roman, Justin Novosad, Nektarios Paisios, Juanmi Huertas, Alice Boxhall, chromium...@chromium.org, Kentaro Hara, Jeongeun Kim, Kevin Babbitt

                The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/30850

                View Change

                  To view, visit change 3166851. To unsubscribe, or for help writing mail filters, visit settings.

                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: Iabd915be2c5f735ee007f863cbd4a2c39f1b192b
                  Gerrit-Change-Number: 3166851
                  Gerrit-PatchSet: 6
                  Gerrit-Owner: Aaron Krajeski <aar...@chromium.org>
                  Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
                  Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                  Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
                  Gerrit-Reviewer: Juanmi Huertas <juan...@chromium.org>
                  Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
                  Gerrit-Reviewer: Nektarios Paisios <nek...@chromium.org>
                  Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
                  Gerrit-CC: Alice Boxhall <abox...@chromium.org>
                  Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
                  Gerrit-CC: Dominic Mazzoni <dmaz...@chromium.org>
                  Gerrit-CC: Jeongeun Kim <je_jul...@chromium.org>
                  Gerrit-CC: Kentaro Hara <har...@chromium.org>
                  Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
                  Gerrit-Comment-Date: Mon, 20 Sep 2021 23:38:18 +0000
                  Gerrit-HasComments: No
                  Gerrit-Has-Labels: No
                  Gerrit-MessageType: comment
                  Reply all
                  Reply to author
                  Forward
                  0 new messages