[ios] Enable moar blink_unittests [chromium/src : main]

Antonio Gomes (Gerrit)

unread,

Mar 23, 2023, 12:59:21 PM3/23/23

to Antonio Gomes, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Chromium LUCI CQ, Dave Tapuska, Alexis Menard, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Dave Tapuska.

Patch set 2:Auto-Submit +1Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  dtapuska, PTAL
  (won't +2 it 'till ios-blink-dbg bot turns green)

To view, visit change 4366032. To unsubscribe, or for help writing mail filters, visit settings.

Antonio Gomes (Gerrit)

unread,

Mar 23, 2023, 12:59:41 PM3/23/23

to Antonio Gomes, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Chromium LUCI CQ, Dave Tapuska, Alexis Menard, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Dave Tapuska.

Patch set 2:-Auto-Submit

View Change

To view, visit change 4366032. To unsubscribe, or for help writing mail filters, visit settings.

Dave Tapuska (Gerrit)

unread,

Mar 23, 2023, 1:07:07 PM3/23/23

to Antonio Gomes, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Antonio Gomes.

Patch set 2:Code-Review +1

View Change

To view, visit change 4366032. To unsubscribe, or for help writing mail filters, visit settings.

Antonio Gomes (Gerrit)

unread,

Mar 23, 2023, 2:13:12 PM3/23/23

to Antonio Gomes, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Dave Tapuska, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Antonio Gomes.

Patch set 2:Commit-Queue +2

Chromium LUCI CQ (Gerrit)

unread,

Mar 23, 2023, 2:21:44 PM3/23/23

to Antonio Gomes, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, Dave Tapuska, Alexis Menard, chromium...@chromium.org, Daniel Cheng

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Dave Tapuska: Looks good to me
  Antonio Gomes: Commit

[ios] Enable moar blink_unittests

Namely the following tests pass:
- WebFrameTest.SiteForCookiesFromChildWithRemoteMainFrame
- StyleEngineTest.VideoControlsReject
- HTMLSrcsetParserTest.SaveDataEnabledBasic
- UseCounterImplBrowserReportTest.ReportOnlyHTTPFamily

BUG=1411478
R=dtap...@chromium.org

Change-Id: I9e97b76912cce1ec0b42ac6719131beef3a5e6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4366032
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Commit-Queue: Antonio Gomes <toni...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1121285}
---
M third_party/blink/renderer/core/css/style_engine_test.cc
M third_party/blink/renderer/core/frame/use_counter_impl_test.cc
M third_party/blink/renderer/core/frame/web_frame_test.cc
M third_party/blink/renderer/core/html/parser/html_srcset_parser_test.cc
4 files changed, 4 insertions(+), 24 deletions(-)

To view, visit change 4366032. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward