[focusgroup] Rename IDL reflections to camelCase [chromium/src : main]

0 views
Skip to first unread message

Jacques Newman (Gerrit)

unread,
May 8, 2026, 5:59:03 PM (4 days ago) May 8
to Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch...@chromium.org, chasej...@chromium.org, iclella...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Mason Freed

Jacques Newman voted and added 1 comment

Votes added by Jacques Newman

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Jacques Newman . resolved

This was raised by Zachy Ma who did the bulk of the microsoft polyfill, since these were added before I started on the new focusgroup effort, I didn't realize these weren't already following the convention. Let me know what you think!

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6015bc1d83daa409b2e98018759d568d73c10d95
Gerrit-Change-Number: 7823287
Gerrit-PatchSet: 5
Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 21:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
May 11, 2026, 3:39:56 PM (21 hours ago) May 11
to Jacques Newman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch...@chromium.org, chasej...@chromium.org, iclella...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Jacques Newman

Mason Freed voted and added 3 comments

Votes added by Mason Freed

Code-Review+1

3 comments

Commit Message
Line 7, Patchset 5 (Latest):[focusgroup] Rename IDL reflections to camelCase
Mason Freed . resolved

Sorry - I should have caught this in a prior review.

File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
Line 3514, Patchset 5 (Latest): kOBSOLETE_V8HTMLElement_Focusgroup_AttributeGetter = 4244,
kOBSOLETE_V8HTMLElement_Focusgroup_AttributeSetter = 4245,
kOBSOLETE_V8MathMLElement_Focusgroup_AttributeGetter = 4246,
kOBSOLETE_V8MathMLElement_Focusgroup_AttributeSetter = 4247,
kOBSOLETE_V8SVGElement_Focusgroup_AttributeGetter = 4248,
kOBSOLETE_V8SVGElement_Focusgroup_AttributeSetter = 4249,
Mason Freed . unresolved

I don't know if these have data, but this'll obviously disconnect it. These entries can be renamed, if you'd like to keep the history.

Line 5212, Patchset 5 (Latest): kV8HTMLElement_FocusGroup_AttributeGetter = 5895,
kV8HTMLElement_FocusGroup_AttributeSetter = 5896,
kV8MathMLElement_FocusGroup_AttributeGetter = 5897,
kV8MathMLElement_FocusGroup_AttributeSetter = 5898,
Mason Freed . unresolved

While we're here, do you care about the distinction between HTML, MathML, SVG? PErhaps you do. If not, you can use `MeasureAs=Something` to get them all together as one.

Open in Gerrit

Related details

Attention is currently required from:
  • Jacques Newman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6015bc1d83daa409b2e98018759d568d73c10d95
    Gerrit-Change-Number: 7823287
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
    Gerrit-Comment-Date: Mon, 11 May 2026 19:39:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jacques Newman (Gerrit)

    unread,
    May 11, 2026, 7:47:54 PM (17 hours ago) May 11
    to Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch...@chromium.org, chasej...@chromium.org, iclella...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org

    Jacques Newman added 2 comments

    File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
    Line 3514, Patchset 5: kOBSOLETE_V8HTMLElement_Focusgroup_AttributeGetter = 4244,

    kOBSOLETE_V8HTMLElement_Focusgroup_AttributeSetter = 4245,
    kOBSOLETE_V8MathMLElement_Focusgroup_AttributeGetter = 4246,
    kOBSOLETE_V8MathMLElement_Focusgroup_AttributeSetter = 4247,
    kOBSOLETE_V8SVGElement_Focusgroup_AttributeGetter = 4248,
    kOBSOLETE_V8SVGElement_Focusgroup_AttributeSetter = 4249,
    Mason Freed . resolved

    I don't know if these have data, but this'll obviously disconnect it. These entries can be renamed, if you'd like to keep the history.

    Jacques Newman

    That's much better, I wrongly assumed this was one of those places where you can't rename or it breaks things.

    Line 5212, Patchset 5: kV8HTMLElement_FocusGroup_AttributeGetter = 5895,

    kV8HTMLElement_FocusGroup_AttributeSetter = 5896,
    kV8MathMLElement_FocusGroup_AttributeGetter = 5897,
    kV8MathMLElement_FocusGroup_AttributeSetter = 5898,
    Mason Freed . resolved

    While we're here, do you care about the distinction between HTML, MathML, SVG? PErhaps you do. If not, you can use `MeasureAs=Something` to get them all together as one.

    Jacques Newman

    makes sense for this one, thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6015bc1d83daa409b2e98018759d568d73c10d95
      Gerrit-Change-Number: 7823287
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
      Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Fredrik Söderquist <f...@opera.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Mon, 11 May 2026 23:47:43 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jacques Newman (Gerrit)

      unread,
      May 11, 2026, 7:48:38 PM (17 hours ago) May 11
      to Dan Clark, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch...@chromium.org, chasej...@chromium.org, iclella...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
      Attention needed from Dan Clark

      Jacques Newman voted Auto-Submit+1

      Auto-Submit+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dan Clark
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6015bc1d83daa409b2e98018759d568d73c10d95
      Gerrit-Change-Number: 7823287
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
      Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
      Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Fredrik Söderquist <f...@opera.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Dan Clark <dan...@microsoft.com>
      Gerrit-Comment-Date: Mon, 11 May 2026 23:48:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dan Clark (Gerrit)

      unread,
      12:28 PM (5 minutes ago) 12:28 PM
      to Jacques Newman, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch...@chromium.org, chasej...@chromium.org, iclella...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
      Attention needed from Jacques Newman

      Dan Clark voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jacques Newman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6015bc1d83daa409b2e98018759d568d73c10d95
      Gerrit-Change-Number: 7823287
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
      Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
      Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Fredrik Söderquist <f...@opera.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
      Gerrit-Comment-Date: Tue, 12 May 2026 16:28:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages