Put UNSAFE_TODO around newly flagged printf-style function calls [chromium/src : main]

[Hans Wennborg (Gerrit)]

Attention needed from Nico Weber and Tom Sepez

Hans Wennborg voted and added 1 comment

Votes added by Hans Wennborg

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hans Wennborg . resolved

This doesn't feel great, but I don't have any other solutions at the moment. wdyt?

Open in Gerrit

Related details

Attention is currently required from:

• Nico Weber
• Tom Sepez

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9d68788f12315f6d623261cf77ebad9b54f6cd09

Gerrit-Change-Number: 7415251

Gerrit-PatchSet: 1

Gerrit-Owner: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>

Gerrit-CC: Alex Keng <shi...@microsoft.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Kaan Icer <ic...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 15:04:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Nico Weber (Gerrit)]

Attention needed from Hans Wennborg and Tom Sepez

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nico Weber . resolved

If this is all, I suppose this is at least fine to unblock things. Have you tried win/android/cros cross builds?

What's your local perfetto patch?

The reason we don't hit this in 3p code is because we suppress the warning there, right?

I do wonder what the path forward is for this. It's in the end "don't call printf() with %s, ever", right? Does printf support something like %.*s to include the string length in the args, and does that prevent the warning? If so, I suppose switching to that would work. (Not in this CL.) For our own functions, having a way to tell clang that something takes a span would be nice.

Open in Gerrit

Related details

Attention is currently required from:

• Hans Wennborg
• Tom Sepez

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9d68788f12315f6d623261cf77ebad9b54f6cd09

Gerrit-Change-Number: 7415251

Gerrit-PatchSet: 1

Gerrit-Owner: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>

Gerrit-CC: Alex Keng <shi...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Kaan Icer <ic...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Hans Wennborg <ha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 15:25:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hans Wennborg (Gerrit)]

Attention needed from Nico Weber and Tom Sepez

Hans Wennborg added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Nico Weber . resolved

If this is all, I suppose this is at least fine to unblock things. Have you tried win/android/cros cross builds?

What's your local perfetto patch?

The reason we don't hit this in 3p code is because we suppress the warning there, right?

I do wonder what the path forward is for this. It's in the end "don't call printf() with %s, ever", right? Does printf support something like %.*s to include the string length in the args, and does that prevent the warning? If so, I suppose switching to that would work. (Not in this CL.) For our own functions, having a way to tell clang that something takes a span would be nice.

Hans Wennborg

Have you tried win/android/cros cross builds?

No. I figured I'd land this and watch the ToT bots to see how much is left.

What's your local perfetto patch?

```
diff --git a/include/perfetto/base/logging.h b/include/perfetto/base/logging.h
index 6b87980973..2c882e2681 100644
--- a/include/perfetto/base/logging.h
+++ b/include/perfetto/base/logging.h
@@ -202,7 +202,7 @@ inline void MaybeSerializeLastLogsForCrashReporting() {}
 
 #if defined(__GNUC__) || defined(__clang__)
 #define PERFETTO_PLOG(x, ...) \
-  PERFETTO_ELOG(x " (errno: %d, %s)", ##__VA_ARGS__, errno, strerror(errno))
+  PERFETTO_ELOG(x " (errno: %d, %s)", ##__VA_ARGS__, errno, "foo")
 #else
 // MSVC expands __VA_ARGS__ in a different order. Give up, not worth it.
 #define PERFETTO_PLOG PERFETTO_ELOG
 ```
 
 obviously we need something better :-D

 
 > The reason we don't hit this in 3p code is because we suppress the warning there, right?

Right, this only fires in code that is opted in to the unsafe buffers warning, which I think is still a relatively small subset of the codebase.

I do wonder what the path forward is for this. It's in the end "don't call printf() with %s, ever", right?

Me too. The warning has carveouts for what it considers safe arguments. If `s` is a `std::string`, then using `%s` with `s.c_str()` is okay. (Maybe any type with `.c_str()`?) Also a literal like `"foo"` is fine, but it's not smart and will currently flag `b ? "foo" : "bar"`.

Open in Gerrit

Related details

Attention is currently required from:

• Nico Weber
• Tom Sepez

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9d68788f12315f6d623261cf77ebad9b54f6cd09

Gerrit-Change-Number: 7415251

Gerrit-PatchSet: 2

Gerrit-Owner: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>

Gerrit-CC: Alex Keng <shi...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Kaan Icer <ic...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 15:42:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nico Weber <tha...@chromium.org>

[Nico Weber (Gerrit)]

Attention needed from Hans Wennborg and Tom Sepez

Nico Weber added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Nico Weber

obviously we need something better :-D

Can we UNSAFE_TODO() all uses of that perfetto macro? Or are there tons?

Me too.

Maybe worth asking about upstream as well?

Open in Gerrit

Related details

Attention is currently required from:

• Hans Wennborg
• Tom Sepez

Gerrit-Attention: Hans Wennborg <ha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 16:34:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Hans Wennborg <ha...@chromium.org>

Comment-In-Reply-To: Nico Weber <tha...@chromium.org>

[Hans Wennborg (Gerrit)]

Attention needed from Nico Weber and Tom Sepez

Hans Wennborg added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Hans Wennborg

Can we UNSAFE_TODO() all uses of that perfetto macro? Or are there tons?

I think these are affected:

```
$ git grep -In -E "TRACE_EVENT_BEGIN[0-9]" | wc -l
129
```

So it seems doable, but ugly. And it's just because of this DCHECK: https://source.chromium.org/chromium/chromium/src/+/main:third_party/perfetto/include/perfetto/tracing/track_event_legacy.h;l=110 which happens to log strerror(errno) on failure.

Open in Gerrit

Related details

Attention is currently required from:

• Nico Weber
• Tom Sepez

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 16:43:58 +0000

[Nico Weber (Gerrit)]

Attention needed from Hans Wennborg and Tom Sepez

Nico Weber added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Nico Weber

If it's only on failure, could we move it out of line?

Open in Gerrit

Related details

Attention is currently required from:

• Hans Wennborg
• Tom Sepez

Gerrit-Attention: Hans Wennborg <ha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 16:55:51 +0000

[Hans Wennborg (Gerrit)]

Attention needed from Nico Weber and Tom Sepez

Hans Wennborg added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Hans Wennborg

Maybe. But it seems weird that Perfetto should have to work around this, given that it's not opted in to unsafe-buffers warnings.

If we're going to make Perfetto changes, we might as well use a pragma for disabling it there.

Open in Gerrit

Related details

Attention is currently required from:

• Nico Weber
• Tom Sepez

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 17:13:09 +0000

[Nico Weber (Gerrit)]

Attention needed from Hans Wennborg and Tom Sepez

Nico Weber added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Nico Weber

Hm, maybe the diag should be emitted pointing at the format string? Then the suppression would work, right?

Open in Gerrit

Related details

Attention is currently required from:

• Hans Wennborg
• Tom Sepez

Gerrit-Attention: Hans Wennborg <ha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 17:17:25 +0000

[Hans Wennborg (Gerrit)]

Attention needed from Nico Weber and Tom Sepez

Hans Wennborg added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Hans Wennborg

I don't think so. Both the format string, the argument (`strerror(errno)`) and the call to the logging function are defined in macros in Perfetto.

My current ideas are:

• Carve out an exception for strerror: https://github.com/llvm/llvm-project/pull/175208
• Put this behind a separate -Wno-unsafe-buffer-usage-format-attribute-calls or such
• Add pragmas to disable this in Perfetto

Open in Gerrit

Related details

Attention is currently required from:

• Nico Weber
• Tom Sepez

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 17:29:18 +0000

[Tom Sepez (Gerrit)]

Attention needed from Hans Wennborg and Nico Weber

Tom Sepez added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Tom Sepez

How much change can we put into perfetto?

You are correct that macros do not have file-based suppression based upon where they are defined, but only where they are used.

One way around this is to make the macro call an intermediate function which then invokes the printf(), keeping the offending printf() call in a file that is covered by suppression.

Open in Gerrit

Related details

Attention is currently required from:

• Hans Wennborg
• Nico Weber

Gerrit-Attention: Hans Wennborg <ha...@chromium.org>

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 17:33:17 +0000

[Hans Wennborg (Gerrit)]

Attention needed from Nico Weber and Tom Sepez

Hans Wennborg added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Hans Wennborg

We'd have to ask the perfetto maintainers. But it sounds like we have a few ideas at least.

thakis: Would you be comfortable giving owners-override for this so we can land it for now?

Open in Gerrit

Related details

Attention is currently required from:

• Nico Weber
• Tom Sepez

Gerrit-Attention: Nico Weber <tha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 19:17:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Hans Wennborg <ha...@chromium.org>

Comment-In-Reply-To: Nico Weber <tha...@chromium.org>

Comment-In-Reply-To: Tom Sepez <tse...@chromium.org>

[Nico Weber (Gerrit)]

Attention needed from Hans Wennborg and Tom Sepez

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Nico Weber . resolved

Oh yeah, I thought I had clicked that last time already. Must've missed the button, apologies!

Open in Gerrit

Related details

Attention is currently required from:

• Hans Wennborg
• Tom Sepez

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Gerrit-Attention: Hans Wennborg <ha...@chromium.org>

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 20:12:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hans Wennborg (Gerrit)]

Attention needed from Tom Sepez

Hans Wennborg voted and added 1 comment

Votes added by Hans Wennborg

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Hans Wennborg . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Tom Sepez

Gerrit-Attention: Tom Sepez <tse...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 20:27:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Put UNSAFE_TODO around newly flagged printf-style function calls

Recent Clang (see bug) started implicitly treating PRINTF_FORMAT
functions similar to printf for -Wunsafe-buffer-usage-in-libc-call.

This suppresses those warnings until they can be fixed.

Bug: 474474271

Change-Id: I9d68788f12315f6d623261cf77ebad9b54f6cd09

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415251

Reviewed-by: Nico Weber <tha...@chromium.org>

Commit-Queue: Hans Wennborg <ha...@chromium.org>

Owners-Override: Nico Weber <tha...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1567161}

Files:

• M base/strings/span_printf.h
• M base/strings/span_printf_nocompile.nc
• M base/strings/string_util.h
• M base/strings/stringprintf.cc
• M base/strings/stringprintf_unittest.cc
• M cc/animation/keyframe_model.cc
• M chrome/browser/sync_file_system/local/local_file_sync_service.cc
• M chrome/browser/sync_file_system/logger.cc
• M chrome/browser/sync_file_system/sync_file_system_service.cc
• M components/drive/event_logger.cc
• M components/update_client/protocol_parser.cc
• M extensions/common/extension_api.cc
• M gin/v8_initializer.cc
• M gpu/command_buffer/service/buffer_manager.cc
• M media/audio/audio_manager_base.cc
• M media/audio/pulse/pulse_input.cc
• M media/audio/pulse/pulse_output.cc
• M media/filters/dav1d_video_decoder.cc
• M services/audio/input_controller.cc
• M services/audio/input_stream.cc
• M services/audio/input_sync_writer.cc
• M services/audio/output_controller.cc
• M services/audio/output_stream.cc
• M services/data_decoder/xml_parser.cc
• M skia/ext/google_logging.cc
• M third_party/blink/renderer/bindings/core/v8/binding_security_test.cc
• M third_party/blink/renderer/core/animation/css/css_animations_test.cc
• M third_party/blink/renderer/core/css/check_pseudo_has_cache_scope_context_test.cc
• M third_party/blink/renderer/core/css/css_numeric_literal_value.cc
• M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
• M third_party/blink/renderer/core/css/style_engine_test.cc
• M third_party/blink/renderer/core/dom/document.cc
• M third_party/blink/renderer/core/dom/element.cc
• M third_party/blink/renderer/core/frame/ad_tracker_test.cc
• M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
• M third_party/blink/renderer/core/html/canvas/text_metrics.cc
• M third_party/blink/renderer/core/html/forms/input_type.cc
• M third_party/blink/renderer/core/html/forms/internal_popup_menu.cc
• M third_party/blink/renderer/core/html/html_plugin_element_test.cc
• M third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
• M third_party/blink/renderer/core/html/lazy_load_image_observer_test.cc
• M third_party/blink/renderer/core/html/media/html_media_element.cc
• M third_party/blink/renderer/core/html/media/media_video_visibility_tracker.cc
• M third_party/blink/renderer/core/inspector/invalidation_set_to_selector_map_test.cc
• M third_party/blink/renderer/core/layout/constraint_space.cc
• M third_party/blink/renderer/core/layout/inline/inline_caret_position_test.cc
• M third_party/blink/renderer/core/layout/inline/inline_item.cc
• M third_party/blink/renderer/core/layout/inline/inline_node_test.cc
• M third_party/blink/renderer/core/layout/inline/line_breaker_test.cc
• M third_party/blink/renderer/core/layout/inline/line_widths_test.cc
• M third_party/blink/renderer/core/layout/inline/score_line_breaker_test.cc
• M third_party/blink/renderer/core/layout/layout_text_fragment_test.cc
• M third_party/blink/renderer/core/layout/layout_text_test.cc
• M third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
• M third_party/blink/renderer/core/permissions_policy/document_policy_parser.cc
• M third_party/blink/renderer/core/permissions_policy/permissions_policy_parser.cc
• M third_party/blink/renderer/core/scheduler_integration_tests/throttling_test.cc
• M third_party/blink/renderer/core/speculation_rules/speculation_rule_set_test.cc
• M third_party/blink/renderer/core/streams/writable_stream.cc
• M third_party/blink/renderer/core/streams/writable_stream_default_writer.cc
• M third_party/blink/renderer/core/testing/internals.cc
• M third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
• M third_party/blink/renderer/core/xml/xslt_unicode_sort.cc
• M third_party/blink/renderer/modules/bluetooth/bluetooth_error.cc
• M third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
• M third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
• M third_party/blink/renderer/modules/canvas/canvas2d/canvas_2d_recorder_context.cc
• M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_factories.cc
• M third_party/blink/renderer/modules/clipboard/clipboard_item.cc
• M third_party/blink/renderer/modules/cookie_store/cookie_store.cc
• M third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
• M third_party/blink/renderer/modules/crypto/crypto.cc
• M third_party/blink/renderer/modules/media_controls/media_controls_shared_helper.cc
• M third_party/blink/renderer/modules/mediastream/media_stream_renderer_factory.cc
• M third_party/blink/renderer/modules/mediastream/media_stream_track_impl.cc
• M third_party/blink/renderer/modules/mediastream/user_media_request.cc
• M third_party/blink/renderer/modules/mediastream/web_media_player_ms.cc
• M third_party/blink/renderer/modules/ml/ml_context.cc
• M third_party/blink/renderer/modules/ml/webnn/ml_graph.cc
• M third_party/blink/renderer/modules/ml/webnn/ml_graph_utils.cc
• M third_party/blink/renderer/modules/payments/payment_request.cc
• M third_party/blink/renderer/modules/storage/cached_storage_area.cc
• M third_party/blink/renderer/modules/webaudio/audio_context.cc
• M third_party/blink/renderer/modules/webaudio/audio_handler.cc
• M third_party/blink/renderer/modules/webaudio/audio_node.cc
• M third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_handler.cc
• M third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
• M third_party/blink/renderer/modules/webaudio/media_stream_audio_source_handler.cc
• M third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.cc
• M third_party/blink/renderer/modules/webaudio/realtime_audio_destination_handler.cc
• M third_party/blink/renderer/modules/webcodecs/decoder_template.cc
• M third_party/blink/renderer/modules/webcodecs/encoder_base.cc
• M third_party/blink/renderer/modules/webcodecs/video_encoder.cc
• M third_party/blink/renderer/modules/webcodecs/video_frame_rect_util.cc
• M third_party/blink/renderer/modules/webgl/webgl_context_factory.cc
• M third_party/blink/renderer/modules/webgl/webgl_rendering_context_webgpu_base.cc
• M third_party/blink/renderer/modules/webgpu/gpu_adapter.cc
• M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
• M third_party/blink/renderer/modules/webgpu/gpu_command_encoder.cc
• M third_party/blink/renderer/modules/webgpu/gpu_compute_pass_encoder.cc
• M third_party/blink/renderer/modules/webgpu/gpu_device.cc
• M third_party/blink/renderer/modules/webgpu/gpu_render_pass_encoder.cc
• M third_party/blink/renderer/modules/webgpu/gpu_render_pipeline.cc
• M third_party/blink/renderer/modules/webrtc/webrtc_audio_renderer.cc
• M third_party/blink/renderer/modules/webtransport/outgoing_stream.cc
• M third_party/blink/renderer/modules/xr/xr_system.cc
• M third_party/blink/renderer/platform/audio/audio_destination.cc
• M third_party/blink/renderer/platform/bindings/enumeration_base.h
• M third_party/blink/renderer/platform/bindings/exception_messages.cc
• M third_party/blink/renderer/platform/bindings/runtime_call_stats.cc
• M third_party/blink/renderer/platform/fonts/font_description.cc
• M third_party/blink/renderer/platform/fonts/font_selection_types.cc
• M third_party/blink/renderer/platform/fonts/font_variant_east_asian.cc
• M third_party/blink/renderer/platform/fonts/script_run_iterator_test.cc
• M third_party/blink/renderer/platform/graphics/paint/display_item.cc
• M third_party/blink/renderer/platform/graphics/paint/paint_chunk.cc
• M third_party/blink/renderer/platform/mediastream/media_stream_component_impl.cc
• M third_party/blink/renderer/platform/mediastream/media_stream_source.cc
• M third_party/blink/renderer/platform/text/layout_locale_test.cc
• M third_party/blink/renderer/platform/transforms/affine_transform_test.cc
• M third_party/blink/renderer/platform/webrtc/webrtc_logging.cc
• M third_party/blink/renderer/platform/wtf/text/string_builder.cc
• M third_party/blink/renderer/platform/wtf/text/wtf_string.cc
• M ui/events/platform/wayland/wayland_event_watcher.cc

Change size: XL

Delta: 124 files changed, 575 insertions(+), 517 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Nico Weber

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9d68788f12315f6d623261cf77ebad9b54f6cd09

Gerrit-Change-Number: 7415251

Gerrit-PatchSet: 3

Gerrit-Owner: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>

Gerrit-Reviewer: Nico Weber <tha...@chromium.org>

Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>

Gerrit-CC: Alex Keng <shi...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>