[CE] Add onerror attribute and change error type for HTMLUserMediaElement. [chromium/src : main]
0 views
Skip to first unread message
Ravjit Uppal (Gerrit)
May 29, 2026, 10:12:34 AM (3 days ago) May 29
to Guido Urdaneta, Thomas Nguyen, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tommyw+w...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com
Attention needed from Guido Urdaneta and Thomas Nguyen
Ravjit Uppal voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Guido Urdaneta
- Thomas Nguyen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ravjit Uppal (Gerrit)
May 29, 2026, 10:53:13 AM (3 days ago) May 29
to Guido Urdaneta, Thomas Nguyen, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tommyw+w...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com
Attention needed from Guido Urdaneta and Thomas Nguyen
Ravjit Uppal voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Guido Urdaneta
- Thomas Nguyen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Nguyen (Gerrit)
5:54 AM (10 hours ago) 5:54 AM
to Ravjit Uppal, Guido Urdaneta, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tommyw+w...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com
Attention needed from Guido Urdaneta and Ravjit Uppal
Thomas Nguyen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Nguyen
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/mediastream/user_media_request_provider_impl.cc
Line 58, Patchset 4 (Latest):
dom_exception = error->GetAsOverconstrainedError();Thomas Nguyen . unresolved
While an OverconstrainedError is not anticipated (because we will filter the constraints before calling gUM), it might be possible since our behavior is entirely dependent on the gUM call.
Rather than using a harsh CHECK, we can include a note and a reasonable console log for this case. WDYT?
Related details
Attention is currently required from:
- Guido Urdaneta
- Ravjit Uppal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
11:35 AM (4 hours ago) 11:35 AM
to Ravjit Uppal, Thomas Nguyen, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tommyw+w...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com
Attention needed from Ravjit Uppal
Guido Urdaneta voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ravjit Uppal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ravjit Uppal (Gerrit)
12:25 PM (3 hours ago) 12:25 PM
to Guido Urdaneta, Thomas Nguyen, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, tommyw+w...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com
Attention needed from Thomas Nguyen
Ravjit Uppal added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/mediastream/user_media_request_provider_impl.cc
Line 58, Patchset 4 (Latest):
dom_exception = error->GetAsOverconstrainedError();Thomas Nguyen . unresolved
While an OverconstrainedError is not anticipated (because we will filter the constraints before calling gUM), it might be possible since our behavior is entirely dependent on the gUM call.
Rather than using a harsh CHECK, we can include a note and a reasonable console log for this case. WDYT?
Ravjit Uppal
Could you please clarify the comment? I might have misunderstood, but OverconsrainedError can still occur, for example the page sets an exact requirement that the user's webcam doesn't support.
`video: { width: { exact: 3840 } }` (demanding 4K) on a 1080p webcam.
Related details
Attention is currently required from:
- Thomas Nguyen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages