Rename/extend ElementAccessibilityIssue in devtools protocol for <summary>. [chromium/src : main]
David Baron (Gerrit)
David Baron added 1 comment![]( "Open in Gerrit")
This is a part of what I've written in the larger CL at https://chromium-review.googlesource.com/c/chromium/src/+/6477166 (see also the related CL at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6653379).
Based on some brief discussion with @jar...@chromium.org I think this might make sense as the first piece to land.
I'm interested in your feedback in terms of the landing process, in particular, is the the right piece to start with, and should there be an additional piece that I prepare on the devtools-frontend side that should immediately follow it?
If this does make sense as a unit of the landing process, I'm also interested in your review of this change.
Related details
- Alex Rudenko
- Joey Arhar
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar voted Code-Review+1![]( "Open in Gerrit")
- Alex Rudenko
- David Baron
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
This is a part of what I've written in the larger CL at https://chromium-review.googlesource.com/c/chromium/src/+/6477166 (see also the related CL at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6653379).
Based on some brief discussion with @jar...@chromium.org I think this might make sense as the first piece to land.
I'm interested in your feedback in terms of the landing process, in particular, is the the right piece to start with, and should there be an additional piece that I prepare on the devtools-frontend side that should immediately follow it?
If this does make sense as a unit of the landing process, I'm also interested in your review of this change.
Hi David, so after you land this, Chromium will be rolled into the DevTools repository once builds are available. We have a gardening rotation to try to deal with the breaking changes but if you can prepare a devtools CL for publishing ahead of time it would be great (after or together with the Chromium roll). Audits domain is experimental so any breaking changes are tolerable.
@chang...@chromium.org is the gardener this week.
Related details
- Changhao Han
- David Baron
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Changhao Han (Gerrit)
Changhao Han voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- David Baron
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
David Baron voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Baron
| Commit-Queue | +2 |
1 comment
Alex RudenkoThis is a part of what I've written in the larger CL at https://chromium-review.googlesource.com/c/chromium/src/+/6477166 (see also the related CL at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6653379).
Based on some brief discussion with @jar...@chromium.org I think this might make sense as the first piece to land.
I'm interested in your feedback in terms of the landing process, in particular, is the the right piece to start with, and should there be an additional piece that I prepare on the devtools-frontend side that should immediately follow it?
If this does make sense as a unit of the landing process, I'm also interested in your review of this change.
Hi David, so after you land this, Chromium will be rolled into the DevTools repository once builds are available. We have a gardening rotation to try to deal with the breaking changes but if you can prepare a devtools CL for publishing ahead of time it would be great (after or together with the Chromium roll). Audits domain is experimental so any breaking changes are tolerable.
@chang...@chromium.org is the gardener this week.
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Rename/extend ElementAccessibilityIssue in devtools protocol for <summary>.
This change renames SelectElementAccessibilityIssue to
ElementAccessibilityIssue in the devtools protocol, and makes
corresponding changes to other types and fields, so that it makes sense
to use for elements other than the <select> element, in particular, for
the <summary> element. This also adds a new
InteractiveContentSummaryDescendant reason for use with <summary>.
- M third_party/blink/public/devtools_protocol/browser_protocol.pdl
- M third_party/blink/renderer/core/html/forms/select_mutation_observer.cc
- M third_party/blink/renderer/core/html/forms/select_mutation_observer.h
- M third_party/blink/renderer/core/inspector/inspector_audits_issue.cc
- M third_party/blink/renderer/core/inspector/inspector_audits_issue.h
- M third_party/blink/web_tests/http/tests/inspector-protocol/issues/select-element-accessibility-issue-creation-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/issues/select-element-accessibility-issue-creation.js
- M tools/metrics/histograms/metadata/dev/enums.xml
Code-Review: +1 by Alex Rudenko, +1 by Joey Arhar, +1 by Changhao Han
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |