[PEPC] HTMLPermissionIconElement should not have icon choosing logic [chromium/src : main]

0 views
Skip to first unread message

Thomas Nguyen (Gerrit)

unread,
Jan 9, 2026, 9:14:13 AM (3 days ago) Jan 9
to Ravjit Uppal, Code Review Nudger, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ravjit Uppal

Thomas Nguyen added 1 comment

File third_party/blink/renderer/core/html/html_permission_element.cc
Line 645, Patchset 1 (Latest): case PermissionName::NOTIFICATIONS:
Thomas Nguyen . unresolved

It should be WEB_APP_INSTALLATION;

Open in Gerrit

Related details

Attention is currently required from:
  • Ravjit Uppal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9a0508bd28861296e1302ba96176dffe05516f71
Gerrit-Change-Number: 7391555
Gerrit-PatchSet: 1
Gerrit-Owner: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Ravjit Uppal <rav...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 14:14:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ravjit Uppal (Gerrit)

unread,
5:26 AM (13 hours ago) 5:26 AM
to Code Review Nudger, Thomas Nguyen, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Thomas Nguyen

Ravjit Uppal added 1 comment

File third_party/blink/renderer/core/html/html_permission_element.cc
Line 645, Patchset 1: case PermissionName::NOTIFICATIONS:
Thomas Nguyen . resolved

It should be WEB_APP_INSTALLATION;

Ravjit Uppal

Oops yeah. Gemini autocompletion :D

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Nguyen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a0508bd28861296e1302ba96176dffe05516f71
    Gerrit-Change-Number: 7391555
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 10:26:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Thomas Nguyen <tun...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages