[PEPC] HTMLPermissionIconElement should not have icon choosing logic [chromium/src : main]

0 views

Skip to first unread message

Thomas Nguyen (Gerrit)

unread,

Jan 9, 2026, 9:14:13 AM (3 days ago) Jan 9

to Ravjit Uppal, Code Review Nudger, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Ravjit Uppal

Thomas Nguyen added 1 comment

File third_party/blink/renderer/core/html/html_permission_element.cc

Line 645, Patchset 1 (Latest): case PermissionName::NOTIFICATIONS:

Thomas Nguyen . unresolved

It should be WEB_APP_INSTALLATION;

Open in Gerrit

Related details

Attention is currently required from:

Ravjit Uppal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ravjit Uppal (Gerrit)

unread,

5:26 AM (13 hours ago) 5:26 AM

to Code Review Nudger, Thomas Nguyen, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Thomas Nguyen

Ravjit Uppal added 1 comment

File third_party/blink/renderer/core/html/html_permission_element.cc

Line 645, Patchset 1: case PermissionName::NOTIFICATIONS:

Thomas Nguyen . resolved

It should be WEB_APP_INSTALLATION;

Ravjit Uppal

Oops yeah. Gemini autocompletion :D