Rename CSS top-layer property to overlay [chromium/src : main]

Rune Lillesveen (Gerrit)

unread,

Mar 23, 2023, 10:08:36 AMMar 23

to Tommy Steimel, Mason Freed, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, steimel+watch...@chromium.org, Rune Lillesveen

Attention is currently required from: Mason Freed, Tommy Steimel.

Rune Lillesveen would like Tommy Steimel and Mason Freed to review this change.

View Change

Rename CSS top-layer property to overlay

Per resolution:

https://github.com/w3c/csswg-drafts/issues/8189#issuecomment-1479815485

Bug: 1411264
Change-Id: I73fa4b8c1b65c54e097217dd93cc813b3b944f63
---
M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/fullscreen.css
M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
M third_party/blink/renderer/core/css/popover.css
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/dom/document.h
M third_party/blink/renderer/core/dom/element.cc
M third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc
M third_party/blink/renderer/core/html/resources/html.css
M third_party/blink/renderer/core/style/computed_style.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/renderer/modules/media_controls/resources/mediaControls.css
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
A third_party/blink/web_tests/wpt_internal/css/css-transitions/overlay-transition-property.html
A third_party/blink/web_tests/wpt_internal/css/css-transitions/parsing/overlay-computed.html
A third_party/blink/web_tests/wpt_internal/css/css-transitions/parsing/overlay-invalid.html
A third_party/blink/web_tests/wpt_internal/css/css-transitions/parsing/overlay-valid.html
D third_party/blink/web_tests/wpt_internal/css/css-transitions/parsing/top-layer-computed.html
D third_party/blink/web_tests/wpt_internal/css/css-transitions/parsing/top-layer-invalid.html
D third_party/blink/web_tests/wpt_internal/css/css-transitions/parsing/top-layer-valid.html
D third_party/blink/web_tests/wpt_internal/css/css-transitions/top-layer-transition-property.html
A third_party/blink/web_tests/wpt_internal/html/rendering/non-replaced-elements/flow-content-3/dialog-overlay.html
D third_party/blink/web_tests/wpt_internal/html/rendering/non-replaced-elements/flow-content-3/dialog-top-layer.html
A third_party/blink/web_tests/wpt_internal/html/rendering/non-replaced-elements/flow-content-3/popover-overlay.html
D third_party/blink/web_tests/wpt_internal/html/rendering/non-replaced-elements/flow-content-3/popover-top-layer.html
M tools/metrics/histograms/enums.xml
36 files changed, 193 insertions(+), 186 deletions(-)

To view, visit change 4366119. To unsubscribe, or for help writing mail filters, visit settings.

Rune Lillesveen (Gerrit)

unread,

Mar 23, 2023, 10:08:41 AMMar 23

to Rune Lillesveen, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, steimel+watch...@chromium.org, Mason Freed, Tommy Steimel, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, Alex Keng

Attention is currently required from: Mason Freed, Tommy Steimel.

View Change

1 comment:

Patchset:
- Patch Set #2:
  ptal
  steimel@ for mediaControls.css

To view, visit change 4366119. To unsubscribe, or for help writing mail filters, visit settings.

Tommy Steimel (Gerrit)

unread,

Mar 23, 2023, 11:48:43 AMMar 23

to Rune Lillesveen, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, steimel+watch...@chromium.org, Mason Freed, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, Alex Keng

Attention is currently required from: Mason Freed, Rune Lillesveen.

Patch set 3:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #3:
  mediaControls.css rslgtm

To view, visit change 4366119. To unsubscribe, or for help writing mail filters, visit settings.

Mason Freed (Gerrit)

unread,

Mar 23, 2023, 4:26:48 PMMar 23

to Rune Lillesveen, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, steimel+watch...@chromium.org, Tommy Steimel, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, Alex Keng

Attention is currently required from: Rune Lillesveen.

Patch set 3:Code-Review +1

View Change

2 comments:

Commit Message:
- Patch Set #3, Line 7: Rename CSS top-layer property to overlay
  nit: '...and also rename "browser" to "auto"'
Patchset:
- Patch Set #3:
  LGTM! Small nit, but otherwise great.

To view, visit change 4366119. To unsubscribe, or for help writing mail filters, visit settings.

Rune Lillesveen (Gerrit)

unread,

Mar 24, 2023, 4:14:31 AMMar 24

to Rune Lillesveen, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, steimel+watch...@chromium.org, Mason Freed, Tommy Steimel, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, Alex Keng

Attention is currently required from: Rune Lillesveen.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 4366119. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Mar 24, 2023, 4:49:38 AMMar 24

to Rune Lillesveen, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, steimel+watch...@chromium.org, Mason Freed, Tommy Steimel, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, Alex Keng

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Mason Freed: Looks good to me
  Tommy Steimel: Looks good to me
  Rune Lillesveen: Commit

Rename CSS top-layer property to overlay

Per resolution:

https://github.com/w3c/csswg-drafts/issues/8189#issuecomment-1479815485

Bug: 1411264
Change-Id: I73fa4b8c1b65c54e097217dd93cc813b3b944f63

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4366119
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Reviewed-by: Tommy Steimel <ste...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121580}

To view, visit change 4366119. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward