MediaElement doesn't wait for TextTracks if load fires during parsing [chromium/src : main]

0 views
Skip to first unread message

Brad Peters (Gerrit)

unread,
May 27, 2026, 5:54:24 PM (5 days ago) May 27
to Dale Curtis, Alex Keng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, steimel+watch...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis

Brad Peters added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Brad Peters . resolved

Hi Dale. We were seeing flaky track cue tests in Edge and after investigating, I believe this is the root cause. I linked this CL against an upstream bug I found with the same test failure but that was resolved as not reproducible. Also, let me know if the html test should go somewhere else. From the ReadMe, I got the impression I could add it here and it would get merged upstream with the WPT tests.

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c59d93ad631a7502aeb1a5607ebe15cb38987a5
Gerrit-Change-Number: 7877146
Gerrit-PatchSet: 3
Gerrit-Owner: Brad Peters <brpe...@microsoft.com>
Gerrit-Reviewer: Brad Peters <brpe...@microsoft.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Wed, 27 May 2026 21:54:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
May 27, 2026, 7:08:47 PM (5 days ago) May 27
to Brad Peters, Alex Keng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, steimel+watch...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Brad Peters

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Code-Review+1

1 comment

File third_party/blink/renderer/core/html/media/html_media_element.cc
Line 860, Patchset 3 (Latest): SetReadyState(static_cast<ReadyState>(web_media_player_->GetReadyState()));
Dale Curtis . unresolved

`SetReadyState(ready_state_)` would make it more clear this is a no-op unless `TextTracksAreReady()`. Do we need to query the WMP for this?

Open in Gerrit

Related details

Attention is currently required from:
  • Brad Peters
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3c59d93ad631a7502aeb1a5607ebe15cb38987a5
    Gerrit-Change-Number: 7877146
    Gerrit-PatchSet: 3
    Gerrit-Owner: Brad Peters <brpe...@microsoft.com>
    Gerrit-Reviewer: Brad Peters <brpe...@microsoft.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-CC: Alex Keng <shi...@microsoft.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Brad Peters <brpe...@microsoft.com>
    Gerrit-Comment-Date: Wed, 27 May 2026 23:08:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Brad Peters (Gerrit)

    unread,
    1:41 PM (2 hours ago) 1:41 PM
    to Tommy Steimel, Dale Curtis, Alex Keng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, steimel+watch...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
    Attention needed from Tommy Steimel

    Brad Peters added 2 comments

    Patchset-level comments
    Brad Peters . resolved

    Tommy, can you PTAL as owner of media_controls_impl_test.cc? Thanks!

    File third_party/blink/renderer/core/html/media/html_media_element.cc
    Line 860, Patchset 3 (Latest): SetReadyState(static_cast<ReadyState>(web_media_player_->GetReadyState()));
    Dale Curtis . resolved

    `SetReadyState(ready_state_)` would make it more clear this is a no-op unless `TextTracksAreReady()`. Do we need to query the WMP for this?

    Brad Peters

    We cannot do SetReadyState(ready_state_) here. In SetReadyState, the ready_state_ is only updated if tracks_are_ready. When the tracks are not ready, ready_state_ is limited to kHaveCurrentData (not the actual ready state of the WMP).

    This line matches the call to SetReadyState in TextTrackReadyStateChanged when the pending text tracks have finished loading.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tommy Steimel
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3c59d93ad631a7502aeb1a5607ebe15cb38987a5
      Gerrit-Change-Number: 7877146
      Gerrit-PatchSet: 3
      Gerrit-Owner: Brad Peters <brpe...@microsoft.com>
      Gerrit-Reviewer: Brad Peters <brpe...@microsoft.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
      Gerrit-Attention: Tommy Steimel <ste...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Jun 2026 17:40:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Tommy Steimel (Gerrit)

      unread,
      1:58 PM (2 hours ago) 1:58 PM
      to Brad Peters, Dale Curtis, Alex Keng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, steimel+watch...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
      Attention needed from Brad Peters

      Tommy Steimel voted and added 1 comment

      Votes added by Tommy Steimel

      Code-Review+1

      1 comment

      Patchset-level comments
      Tommy Steimel . resolved

      third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc lgtm

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Brad Peters
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3c59d93ad631a7502aeb1a5607ebe15cb38987a5
      Gerrit-Change-Number: 7877146
      Gerrit-PatchSet: 3
      Gerrit-Owner: Brad Peters <brpe...@microsoft.com>
      Gerrit-Reviewer: Brad Peters <brpe...@microsoft.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
      Gerrit-CC: Alex Keng <shi...@microsoft.com>
      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
      Gerrit-Attention: Brad Peters <brpe...@microsoft.com>
      Gerrit-Comment-Date: Mon, 01 Jun 2026 17:58:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Blink W3C Test Autoroller (Gerrit)

      unread,
      2:24 PM (1 hour ago) 2:24 PM
      to Brad Peters, Tommy Steimel, Dale Curtis, Alex Keng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, steimel+watch...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
      Attention needed from Brad Peters

      Message from Blink W3C Test Autoroller

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60324.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Brad Peters
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3c59d93ad631a7502aeb1a5607ebe15cb38987a5
      Gerrit-Change-Number: 7877146
      Gerrit-PatchSet: 3
      Gerrit-Owner: Brad Peters <brpe...@microsoft.com>
      Gerrit-Reviewer: Brad Peters <brpe...@microsoft.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>
      Gerrit-CC: Alex Keng <shi...@microsoft.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Jun 2026 18:24:01 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages