[cleanup] Remove individual margin accessors. [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
Apr 20, 2026, 7:20:40 PM (2 days ago) Apr 20
to Morten Stenshorne, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne

Ian Kilpatrick voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifb183fc57e381a759f4a88ab06a16dedcf5c1dd8
Gerrit-Change-Number: 7478009
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Apr 2026 23:20:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Morten Stenshorne (Gerrit)

unread,
Apr 21, 2026, 3:47:08 AM (yesterday) Apr 21
to Ian Kilpatrick, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

Morten Stenshorne voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifb183fc57e381a759f4a88ab06a16dedcf5c1dd8
    Gerrit-Change-Number: 7478009
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 07:46:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    Apr 21, 2026, 8:48:06 AM (23 hours ago) Apr 21
    to Morten Stenshorne, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

    Ian Kilpatrick voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifb183fc57e381a759f4a88ab06a16dedcf5c1dd8
    Gerrit-Change-Number: 7478009
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 12:47:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 21, 2026, 8:53:46 AM (23 hours ago) Apr 21
    to Ian Kilpatrick, Morten Stenshorne, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [cleanup] Remove individual margin accessors.

    Most accessors of the individual margin accessors use multiple of them,
    to convert them all to "MarginOutests".

    This patch is in preparation for accessing the margins directly off the
    fragments instead.

    There should be no behaviour change.
    Change-Id: Ifb183fc57e381a759f4a88ab06a16dedcf5c1dd8
    Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
    Reviewed-by: Morten Stenshorne <mste...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1618127}
    Files:
    • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
    • M third_party/blink/renderer/core/dom/geometry_utils.cc
    • M third_party/blink/renderer/core/html/forms/slider_thumb_element.cc
    • M third_party/blink/renderer/core/inspector/inspector_highlight.cc
    • M third_party/blink/renderer/core/layout/custom_scrollbar.cc
    • M third_party/blink/renderer/core/layout/layout_box.cc
    • M third_party/blink/renderer/core/layout/layout_box.h
    • M third_party/blink/renderer/core/layout/layout_box_model_object.h
    • M third_party/blink/renderer/core/layout/layout_custom_scrollbar_part.cc
    • M third_party/blink/renderer/core/layout/layout_custom_scrollbar_part.h
    • M third_party/blink/renderer/core/layout/layout_inline.cc
    • M third_party/blink/renderer/core/layout/layout_inline.h
    • M third_party/blink/renderer/core/layout/scrollbars_test.cc
    • M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
    Change size: M
    Delta: 14 files changed, 81 insertions(+), 157 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Morten Stenshorne
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifb183fc57e381a759f4a88ab06a16dedcf5c1dd8
    Gerrit-Change-Number: 7478009
    Gerrit-PatchSet: 6
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages