Revert "Remove unused Mojo ex-Supplementable members." [chromium/src : main]

[Steinar H Gunderson (Gerrit)]

Attention needed from Daniel Cheng

Steinar H Gunderson has uploaded the change for review

Steinar H Gunderson would like Daniel Cheng to review this change.

Commit message

Revert "Remove unused Mojo ex-Supplementable members."

This reverts commit c308805e6cedd429b479c6d5310d33e34c0f1775.
(See blink-dev for background.)

Bug: 460165754

Change-Id: Iddf14fa1a2668d8f9ec2cb4892e7a85c061a4a33

Change diff

diff --git a/third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc b/third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc
index 041efb9..69502fb 100644
--- a/third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc
+++ b/third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc
@@ -10,17 +10,21 @@
 
 namespace blink {
 
+MojoFileSystemAccess::MojoFileSystemAccess(Mojo& mojo) : mojo_(mojo) {}
+
 // static
 MojoFileSystemAccess& MojoFileSystemAccess::From(Mojo& mojo) {
   MojoFileSystemAccess* supplement = mojo.GetMojoFileSystemAccess();
   if (!supplement) {
-    supplement = MakeGarbageCollected<MojoFileSystemAccess>();
+    supplement = MakeGarbageCollected<MojoFileSystemAccess>(mojo);
     mojo.SetMojoFileSystemAccess(supplement);
   }
   return *supplement;
 }
 
-void MojoFileSystemAccess::Trace(Visitor* visitor) const {}
+void MojoFileSystemAccess::Trace(Visitor* visitor) const {
+  visitor->Trace(mojo_);
+}
 
 // static
 MojoHandle* MojoFileSystemAccess::getFileSystemAccessTransferToken(
diff --git a/third_party/blink/renderer/modules/mojo/mojo_file_system_access.h b/third_party/blink/renderer/modules/mojo/mojo_file_system_access.h
index e6317690b..3395acf7 100644
--- a/third_party/blink/renderer/modules/mojo/mojo_file_system_access.h
+++ b/third_party/blink/renderer/modules/mojo/mojo_file_system_access.h
@@ -19,7 +19,7 @@
     : public GarbageCollected<MojoFileSystemAccess>,
       public GarbageCollectedMixin {
  public:
-  MojoFileSystemAccess() = default;
+  explicit MojoFileSystemAccess(Mojo&);
   static MojoFileSystemAccess& From(Mojo&);
 
   // IDL interface methods:
@@ -27,6 +27,9 @@
       FileSystemFileHandle* fs_handle);
 
   void Trace(Visitor* visitor) const override;
+
+ private:
+  Member<Mojo> mojo_;
 };
 
 }  // namespace blink

Change information

Files:

• M third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc
• M third_party/blink/renderer/modules/mojo/mojo_file_system_access.h

Change size: S

Delta: 2 files changed, 10 insertions(+), 3 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iddf14fa1a2668d8f9ec2cb4892e7a85c061a4a33

Gerrit-Change-Number: 7246156

Gerrit-PatchSet: 1

Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Kaan Icer <ic...@chromium.org>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Wanming Lin <wanmi...@intel.com>

Gerrit-CC: Xida Chen <xida...@chromium.org>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

[Daniel Cheng (Gerrit)]

Attention needed from Steinar H Gunderson

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Steinar H Gunderson

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Dec 2025 20:20:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Revert "Remove unused Mojo ex-Supplementable members."

This reverts commit c308805e6cedd429b479c6d5310d33e34c0f1775.
(See blink-dev for background.)

Bug: 460165754

Change-Id: Iddf14fa1a2668d8f9ec2cb4892e7a85c061a4a33

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7246156

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Steinar H Gunderson <se...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1557895}

Files:

• M third_party/blink/renderer/modules/mojo/mojo_file_system_access.cc
• M third_party/blink/renderer/modules/mojo/mojo_file_system_access.h

Change size: S

Delta: 2 files changed, 10 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iddf14fa1a2668d8f9ec2cb4892e7a85c061a4a33

Gerrit-Change-Number: 7246156

Gerrit-PatchSet: 9

Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>