[html-in-canvas] Fix nested canvas invalidations [chromium/src : main]
0 views
Skip to first unread message
Philip Rogers (Gerrit)
Apr 17, 2026, 1:20:31 PM (13 days ago) Apr 17
to Stefan Zager, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org
Attention needed from Stefan Zager
Philip Rogers voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stefan Zager (Gerrit)
Apr 17, 2026, 2:19:59 PM (13 days ago) Apr 17
to Philip Rogers, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org
Attention needed from Philip Rogers
Stefan Zager voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Apr 17, 2026, 2:25:43 PM (13 days ago) Apr 17
to Stefan Zager, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org
Philip Rogers voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 17, 2026, 3:06:41 PM (13 days ago) Apr 17
to Philip Rogers, Stefan Zager, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[html-in-canvas] Fix nested canvas invalidations
This patch fixes a bug in `LayoutHTMLCanvas::InvalidatePaint` where
composited canvases would not invalidate under html-in-canvas. The
issue was that `HTMLCanvasElement::ShouldBeDirectComposited` would
return true, skipping paint invalidation. This function has been
renamed to `ShouldSkipPaintInvalidation` to reflect what it does, and
has been updated to return false for nested canvas. Some tests have
been renamed to clarify nested canvas vs nested layoutsubtree canvas.
Fixed: 503420419
Change-Id: I31a3bef05f49be9f1122a9a4f2ef28a6e122b920
Reviewed-by: Stefan Zager <sza...@chromium.org>
Commit-Queue: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1616744}
Files:
- M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
- M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
- M third_party/blink/renderer/core/layout/layout_html_canvas.cc
- R third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/moved-nested-layoutsubtree-canvas.html
- A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-canvas-invalidation-ref.html
- A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-canvas-invalidation.html
- R third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-div-layoutsubtree-canvas.html
- R third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-layoutsubtree-canvas.html
- R third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-webgl-layoutsubtree-canvas.html
Change size: S
Delta: 9 files changed, 42 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Stefan Zager
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages