[A11y] Expose MathML arg and intent string attributes [chromium/src : main]

0 views
Skip to first unread message

Peter Kotwicz (Gerrit)

unread,
May 25, 2026, 8:06:31 PM (7 days ago) May 25
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, bling-alchemy-eng+...@google.com, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, moqati-team+chr...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Peter Kotwicz voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifcc4e7136f3e58f2732aafaa23aa9c569b03f588
Gerrit-Change-Number: 7874532
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Comment-Date: Tue, 26 May 2026 00:06:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Kotwicz (Gerrit)

unread,
May 27, 2026, 10:16:54 AM (5 days ago) May 27
to David Tseng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, bling-alchemy-eng+...@google.com, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, moqati-team+chr...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from David Tseng

Peter Kotwicz added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Peter Kotwicz . resolved

dtseng@ can you please take a look?

Open in Gerrit

Related details

Attention is currently required from:
  • David Tseng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifcc4e7136f3e58f2732aafaa23aa9c569b03f588
Gerrit-Change-Number: 7874532
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: David Tseng <dts...@chromium.org>
Gerrit-Comment-Date: Wed, 27 May 2026 14:16:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Tseng (Gerrit)

unread,
May 28, 2026, 6:51:09 PM (4 days ago) May 28
to Peter Kotwicz, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, bling-alchemy-eng+...@google.com, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, moqati-team+chr...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Peter Kotwicz

David Tseng added 4 comments

File third_party/blink/renderer/modules/accessibility/ax_object.cc
Line 2005, Patchset 4 (Latest):
David Tseng . unresolved

Given we only have OS api mappings currently for Android, I would add
#elif BUILDFLAG(IS_ANDROID

Line 2007, Patchset 4 (Latest): TruncateAndAddStringAttribute(node_data,
David Tseng . unresolved

Let's break this down a little:

  • does getAttribute return "" if the value does not exist?
  • do we want to Truncate? What does that do?
  • AndAddStringAttribute, does this add unconditionally? e.g. if the string is empty. Is that what we want? (to differentiate between empty vs not set).
Line 2009, Patchset 4 (Latest): element->getAttribute(AtomicString("arg")));
David Tseng . unresolved

Is arg defined in Blink? Is this case sensitive?

Line 2012, Patchset 4 (Latest): element->getAttribute(AtomicString("intent")));
David Tseng . unresolved

Ditto.

Open in Gerrit

Related details

Attention is currently required from:
  • Peter Kotwicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifcc4e7136f3e58f2732aafaa23aa9c569b03f588
    Gerrit-Change-Number: 7874532
    Gerrit-PatchSet: 4
    Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 May 2026 22:50:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Peter Kotwicz (Gerrit)

    unread,
    May 29, 2026, 11:17:53 AM (3 days ago) May 29
    to David Tseng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, bling-alchemy-eng+...@google.com, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, moqati-team+chr...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from David Tseng

    Peter Kotwicz added 5 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Peter Kotwicz . resolved

    dtseng@ can you please take another look?

    File third_party/blink/renderer/modules/accessibility/ax_object.cc
    Line 2005, Patchset 4:
    David Tseng . resolved

    Given we only have OS api mappings currently for Android, I would add
    #elif BUILDFLAG(IS_ANDROID

    Peter Kotwicz

    Done

    Line 2007, Patchset 4: TruncateAndAddStringAttribute(node_data,
    David Tseng . unresolved

    Let's break this down a little:

    • does getAttribute return "" if the value does not exist?
    • do we want to Truncate? What does that do?
    • AndAddStringAttribute, does this add unconditionally? e.g. if the string is empty. Is that what we want? (to differentiate between empty vs not set).
    Peter Kotwicz
    • Added a comment documenting that we are only adding the value if it is non-empty
    • We most definitely want to truncate. Truncation prevents Chrome from storing a super long attributes. TruncateAndAddStringAttribute() currently truncates attributes which are over 3 million characters long.
    • No TruncateAndAddStringAttribute() does not add unconditionally.
    Line 2009, Patchset 4: element->getAttribute(AtomicString("arg")));
    David Tseng . unresolved

    Is arg defined in Blink? Is this case sensitive?

    Peter Kotwicz
    • Switched to using `mathml_names::intent` Thank you for catching this!
    Line 2012, Patchset 4: element->getAttribute(AtomicString("intent")));
    David Tseng . resolved

    Ditto.

    Peter Kotwicz

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Tseng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifcc4e7136f3e58f2732aafaa23aa9c569b03f588
    Gerrit-Change-Number: 7874532
    Gerrit-PatchSet: 5
    Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: David Tseng <dts...@chromium.org>
    Gerrit-Comment-Date: Fri, 29 May 2026 15:17:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Tseng <dts...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Tseng (Gerrit)

    unread,
    May 29, 2026, 2:46:22 PM (3 days ago) May 29
    to Peter Kotwicz, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, bling-alchemy-eng+...@google.com, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, moqati-team+chr...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Peter Kotwicz

    David Tseng added 1 comment

    Message

    Mostly lg; just checking on one thing.

    1 comment

    File third_party/blink/renderer/modules/accessibility/ax_object.cc
    Line 2005, Patchset 5 (Latest): if (ui::IsMath(node_data->role)) {
    David Tseng . unresolved

    It's worth thinking about if we want to use
    Node::IsMathMLElement
    instead.

    THis somewhat dpeends on if we're going to use htmlTag to do the final conversion.
    1. Node.IsMathMLElement, htmlTag (browser side): will always identify DOM nodes which are math regardless of ARIA role additions that content authors place
    2. native/aria roles in Blink and browser side: the only thing I could think of is if an author wants to override the math for whatever reason e.g. <mn role="button">1</mn>.

    I think I maybe favor 1 because it would also encode the role button in the example and also the math info whereas 2 would drop the math info.

    WDYT?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Peter Kotwicz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifcc4e7136f3e58f2732aafaa23aa9c569b03f588
    Gerrit-Change-Number: 7874532
    Gerrit-PatchSet: 5
    Gerrit-Owner: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Peter Kotwicz <pkot...@chromium.org>
    Gerrit-Comment-Date: Fri, 29 May 2026 18:46:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages