David Baron (Gerrit)

unread,

Jun 20, 2025, 1:16:55 PM6/20/25

to David Baron, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Joey Arhar

David Baron voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Joey Arhar

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joey Arhar (Gerrit)

unread,

Jun 24, 2025, 5:35:41 PM6/24/25

to David Baron, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Joey Arhar voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 24, 2025, 6:25:15 PM6/24/25

to David Baron, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Simplify option's select tracking during mutations

This patch simplifies the logic in HTMLOptionElement::InsertedInto and
HTMLOptionElement::RemovedFrom and removes calls to
SetOwnerSelectElement outside of those two methods.

Bug: 41483940, 398887837

Change-Id: I80fcad0704f339502fc374cb3f92233cc65a75b3

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6644003

Commit-Queue: Joey Arhar <jar...@chromium.org>

Reviewed-by: David Baron <dba...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1478228}

Files:

M third_party/blink/renderer/core/html/forms/html_opt_group_element.cc
M third_party/blink/renderer/core/html/forms/html_option_element.cc
M third_party/blink/renderer/core/html/forms/html_option_element.h
M third_party/blink/renderer/core/html/forms/html_select_element.cc
M third_party/blink/renderer/core/html/forms/html_select_element.h
M third_party/blink/renderer/core/html/forms/option_list.cc

Change size: M

Delta: 6 files changed, 48 insertions(+), 114 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by David Baron

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Simplify option's select tracking during mutations [chromium/src : main]

David Baron (Gerrit)

David Baron voted Code-Review+1

Related details

Joey Arhar (Gerrit)

Joey Arhar voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information