Revert "Skip field disabled checks in DateTimeEditElement" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Oct 18, 2025, 3:25:20 PM (23 hours ago) Oct 18
to luci-bi...@appspot.gserviceaccount.com, Mason Freed, Chromium LUCI CQ, Peng Zhou, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, blink-...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org, francisjp...@google.com, kyungjunle...@google.com, josiah...@chromium.org, abigailbk...@google.com, nektar...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, dtseng...@chromium.org, jmedle...@chromium.org, yuzo+...@chromium.org
Attention needed from Mason Freed and Peng Zhou

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
  • Peng Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iff75373dc4f5755bd06c567ba7221e5f5bda0030
Gerrit-Change-Number: 7057440
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Comment-Date: Sat, 18 Oct 2025 19:25:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peng Zhou (Gerrit)

unread,
4:47 AM (10 hours ago) 4:47 AM
to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, blink-...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org, francisjp...@google.com, kyungjunle...@google.com, josiah...@chromium.org, abigailbk...@google.com, nektar...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, dtseng...@chromium.org, jmedle...@chromium.org, yuzo+...@chromium.org
Attention needed from Mason Freed

Peng Zhou added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Peng Zhou . resolved

I’ve submitted the commit(Icc1b271d0fca8d9c5cb15f0957d3fe07e73c14b1) to fix this issue, so it should be fine to land the current change without reverting the previous commit.

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iff75373dc4f5755bd06c567ba7221e5f5bda0030
Gerrit-Change-Number: 7057440
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Sun, 19 Oct 2025 08:47:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Peng Zhou (Gerrit)

unread,
9:49 AM (5 hours ago) 9:49 AM
to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, blink-...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org, francisjp...@google.com, kyungjunle...@google.com, josiah...@chromium.org, abigailbk...@google.com, nektar...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, dtseng...@chromium.org, jmedle...@chromium.org, yuzo+...@chromium.org
Attention needed from Mason Freed

Peng Zhou added 1 comment

Patchset-level comments
Peng Zhou . resolved

The commit(Icc1b271d0fca8d9c5cb15f0957d3fe07e73c14b1) has already landed, so no revert is needed.

Gerrit-Comment-Date: Sun, 19 Oct 2025 13:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Peng Zhou (Gerrit)

unread,
9:49 AM (5 hours ago) 9:49 AM
to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, blink-...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org, francisjp...@google.com, kyungjunle...@google.com, josiah...@chromium.org, abigailbk...@google.com, nektar...@chromium.org, jshin...@chromium.org, blink-rev...@chromium.org, dtseng...@chromium.org, jmedle...@chromium.org, yuzo+...@chromium.org

Peng Zhou abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages