Zhou, Shuangshuang (Gerrit)

unread,

Apr 27, 2026, 3:31:04 AMApr 27

to srirama chandra sekhar, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Mason Freed

Zhou, Shuangshuang added 3 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Zhou, Shuangshuang . resolved

Hi Mason&Joey，in the current patch, I only addressed the cases in `renderer/core` to minimize the risk of bugs and ensure we don’t introduce any side effects before extending to other scopes in `blink/`. PTAL!
Then we can

Commit Message

Line 11, Patchset 2:AtomicString comparison intead of character-by-character comparison.

Mason Freed . resolved

Please fix this WARNING reported by Spellchecker: "intead" is a possible misspelling of "instead".
To bypass Spellchecker, add a ...
"intead" is a possible misspelling of "instead".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

Zhou, Shuangshuang

Done

File third_party/blink/renderer/core/clipboard/data_transfer.cc

Line 182, Patchset 2:

  if (op == "copy")
    return kDragOperationCopy;
  if (op == "link")
    return kDragOperationLink;
  if (op == "move")
    return kDragOperationMove;
  if (op == "copyLink") {
    return static_cast<DragOperationsMask>(kDragOperationCopy |
                                           kDragOperationLink);
  }
  if (op == "copyMove") {
    return static_cast<DragOperationsMask>(kDragOperationCopy |
                                           kDragOperationMove);
  }
  if (op == "linkMove") {
    return static_cast<DragOperationsMask>(kDragOperationLink |
                                           kDragOperationMove);
  }
  if (op == "all")
    return kDragOperationEvery;
  return std::nullopt;

Mason Freed . resolved

Perhaps while you're here, you could move all of the other values to keywords?

Zhou, Shuangshuang

Done

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Apr 27, 2026, 5:30:28 PMApr 27

to Zhou, Shuangshuang, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Zhou, Shuangshuang

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mason Freed . resolved

Nice cleanup! Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Zhou, Shuangshuang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Zhou, Shuangshuang (Gerrit)

unread,

Apr 29, 2026, 7:02:43 PM (13 days ago) Apr 29

to Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Zhou, Shuangshuang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Zhou, Shuangshuang . resolved

friendly ping! Thanks!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Zhou, Shuangshuang (Gerrit)

unread,

May 5, 2026, 8:59:44 AM (7 days ago) May 5

to Xiaocheng Hu, Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Xiaocheng Hu

Zhou, Shuangshuang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Zhou, Shuangshuang . resolved

Friendly ping, thanks!

Hi Philip, also add you in reviewers, PTAL when you have time. This is a clean-up patch. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Xiaocheng Hu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Zhou, Shuangshuang (Gerrit)

unread,

May 5, 2026, 10:42:58 PM (7 days ago) May 5

to Philip Rogers, Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Philip Rogers

Zhou, Shuangshuang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Zhou, Shuangshuang . resolved

Hi Philip, also add you in reviewers, PTAL when you have time. This is a clean-up patch. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Zhou, Shuangshuang (Gerrit)

unread,

May 10, 2026, 8:55:45 PM (2 days ago) May 10

to Philip Rogers, Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Philip Rogers

Zhou, Shuangshuang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Zhou, Shuangshuang . resolved

friendly ping! Thanks! Hey Philip and Joey, would you like to take a look on this?

satisfied_requirement

unsatisfied_requirement

open

diffy

Philip Rogers (Gerrit)

unread,

May 11, 2026, 2:54:53 PM (23 hours ago) May 11

to Zhou, Shuangshuang, Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Zhou, Shuangshuang

Philip Rogers voted and added 2 comments

Votes added by Philip Rogers

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Philip Rogers . resolved

LGTM

File third_party/blink/renderer/core/clipboard/data_transfer.cc

Line 31, Patchset 4 (Latest):#include "build/build_config.h"

Philip Rogers . unresolved

Do you need to include keywords.h?

Open in Gerrit

Related details

Attention is currently required from:

Zhou, Shuangshuang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Zhou, Shuangshuang (Gerrit)

unread,

6:09 AM (8 hours ago) 6:09 AM

to Philip Rogers, Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Mason Freed and Philip Rogers

Zhou, Shuangshuang added 2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Zhou, Shuangshuang . resolved

Hi Philip&Mason&Jeoy, thanks for the comments, PTAL!

File third_party/blink/renderer/core/clipboard/data_transfer.cc

Line 31, Patchset 4:#include "build/build_config.h"

Philip Rogers . resolved

Do you need to include keywords.h?

Zhou, Shuangshuang

Good catch! Thanks for the reminder!

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed
Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Philip Rogers (Gerrit)

unread,

10:57 AM (3 hours ago) 10:57 AM

to Zhou, Shuangshuang, Mason Freed, srirama chandra sekhar, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org

Attention needed from Mason Freed and Zhou, Shuangshuang

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Philip Rogers . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed
Zhou, Shuangshuang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[cleanup] Use keywords:: constants instead of string literals in renderer/core [chromium/src : main]

Zhou, Shuangshuang (Gerrit)

Zhou, Shuangshuang added 3 comments

Related details

Mason Freed (Gerrit)

Mason Freed voted and added 1 comment

Votes added by Mason Freed

1 comment

Related details

Zhou, Shuangshuang (Gerrit)

Zhou, Shuangshuang added 1 comment

Related details

Zhou, Shuangshuang (Gerrit)

Zhou, Shuangshuang added 1 comment

Related details

Zhou, Shuangshuang (Gerrit)

Zhou, Shuangshuang added 1 comment

Related details

Zhou, Shuangshuang (Gerrit)

Zhou, Shuangshuang added 1 comment

Philip Rogers (Gerrit)

Philip Rogers voted and added 2 comments

Votes added by Philip Rogers

2 comments

Related details

Zhou, Shuangshuang (Gerrit)

Zhou, Shuangshuang added 2 comments

Related details

Philip Rogers (Gerrit)

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

1 comment

Related details