[FormControlRange] Programmatic updates for value changes [chromium/src : main]

0 views
Skip to first unread message

Stephanie Zhang (Gerrit)

unread,
Oct 2, 2025, 4:21:20 PMOct 2
to AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Message from Stephanie Zhang

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia8bda2e60196dcfc0ca63b90841243efb08055f2
Gerrit-Change-Number: 7004105
Gerrit-PatchSet: 5
Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Comment-Date: Thu, 02 Oct 2025 20:21:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephanie Zhang (Gerrit)

unread,
Oct 2, 2025, 4:29:07 PMOct 2
to Dan Clark, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Dan Clark

Stephanie Zhang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia8bda2e60196dcfc0ca63b90841243efb08055f2
Gerrit-Change-Number: 7004105
Gerrit-PatchSet: 6
Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Comment-Date: Thu, 02 Oct 2025 20:28:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephanie Zhang (Gerrit)

unread,
Oct 17, 2025, 2:11:14 PM (2 days ago) Oct 17
to Ana Sollano Kim, Leo Lee, Dan Clark, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ana Sollano Kim and Mason Freed

Stephanie Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Stephanie Zhang . resolved

PTAL - thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Ana Sollano Kim
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia8bda2e60196dcfc0ca63b90841243efb08055f2
    Gerrit-Change-Number: 7004105
    Gerrit-PatchSet: 10
    Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
    Gerrit-CC: Dan Clark <dan...@microsoft.com>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Comment-Date: Fri, 17 Oct 2025 18:11:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ana Sollano Kim (Gerrit)

    unread,
    Oct 17, 2025, 5:09:07 PM (2 days ago) Oct 17
    to Stephanie Zhang, Leo Lee, Dan Clark, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Mason Freed and Stephanie Zhang

    Ana Sollano Kim added 2 comments

    File third_party/blink/renderer/core/html/forms/html_text_area_element.cc
    Line 531, Patchset 10 (Latest): String old_value = Value();
    Ana Sollano Kim . unresolved
    ```suggestion
      const String old_value = Value();
    ```
    File third_party/blink/renderer/core/html/forms/text_field_input_type.cc
    Line 162, Patchset 10 (Latest): String old_value = GetElement().Value();
    Ana Sollano Kim . unresolved
    ```suggestion
      const String old_value = GetElement().Value();
    ```
    here as well?
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mason Freed
    • Stephanie Zhang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia8bda2e60196dcfc0ca63b90841243efb08055f2
      Gerrit-Change-Number: 7004105
      Gerrit-PatchSet: 10
      Gerrit-Owner: Stephanie Zhang <stephan...@microsoft.com>
      Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Stephanie Zhang <stephan...@microsoft.com>
      Gerrit-CC: Dan Clark <dan...@microsoft.com>
      Gerrit-CC: Leo Lee <leo...@microsoft.com>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Stephanie Zhang <stephan...@microsoft.com>
      Gerrit-Comment-Date: Fri, 17 Oct 2025 21:08:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages