Autoplay: Allow audio playback without user gesture when explicitly allowed [chromium/src : main]
0 views
Skip to first unread message
Evan Liu (Gerrit)
Mar 30, 2026, 3:07:13 PM (3 days ago) Mar 30
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis
Evan Liu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Mar 30, 2026, 4:08:43 PM (3 days ago) Mar 30
to Evan Liu, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Evan Liu
Dale Curtis added 3 comments![]( "Open in Gerrit")
File chrome/test/data/media/audio_autoplay.html
Line 1, Patchset 5 (Latest):
<!DOCTYPE html>Dale Curtis . unresolved
Add a brief comment on what this is testing
File chrome/test/data/media/muted_video_autoplay.html
File third_party/blink/renderer/core/html/media/autoplay_policy.cc
Line 75, Patchset 5 (Parent):
if (DocumentHasUserExceptionFlag(document))Dale Curtis . unresolved
This is used directly in a couple places:
- https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webaudio/audio_context.cc;l=1269;drc=3c88b7a724526e59f2603286d0144e5cc9a58905
- https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/speech/speech_synthesis.cc;l=367;drc=926943cad55d11056856e35487b1a0d19af4d579
Are both those usages still okay? Should those usages be replaced with an existing boolean helper?
Related details
Attention is currently required from:
- Evan Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Liu (Gerrit)
Apr 1, 2026, 8:06:03 PM (10 hours ago) Apr 1
to Hongchan Choi, AyeAye, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis
Evan Liu voted and added 3 comments![]( "Open in Gerrit")
Votes added by Evan Liu
| Commit-Queue | +1 |
3 comments
File chrome/test/data/media/audio_autoplay.html
Add a brief comment on what this is testing
Evan Liu
Done
File chrome/test/data/media/muted_video_autoplay.html
File third_party/blink/renderer/core/html/media/autoplay_policy.cc
Line 75, Patchset 5 (Parent):
if (DocumentHasUserExceptionFlag(document))Dale Curtis . resolved
This is used directly in a couple places:
- https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webaudio/audio_context.cc;l=1269;drc=3c88b7a724526e59f2603286d0144e5cc9a58905
- https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/speech/speech_synthesis.cc;l=367;drc=926943cad55d11056856e35487b1a0d19af4d579
Are both those usages still okay? Should those usages be replaced with an existing boolean helper?
Evan Liu
Oh good catch! The speech synthesis usage is fine since falls back to `IsDocumentAllowedToPlay()` immediately afterwards which contains the same check that was just moved. The AudioContext usage needs to be updated to accommodate the prerendering edge case.
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Apr 1, 2026, 8:19:33 PM (10 hours ago) Apr 1
to Evan Liu, Hongchan Choi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Evan Liu and Hongchan Choi
Dale Curtis added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webaudio/audio_context.cc
Line 634, Patchset 11 (Latest):
}Dale Curtis . unresolved
Does this need an else to avoid the switch below?
Related details
Attention is currently required from:
- Evan Liu
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Liu (Gerrit)
Apr 1, 2026, 8:33:53 PM (10 hours ago) Apr 1
to Hongchan Choi, AyeAye, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis and Hongchan Choi
Evan Liu added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webaudio/audio_context.cc
Dale Curtis . unresolved
Does this need an else to avoid the switch below?
Evan Liu
I believe the lack of an `else` statement here is required to fix b/498258317. Perhaps Hongchan can confirm.
Related details
Attention is currently required from:
- Dale Curtis
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages