Implement autofill preview for appearance:base-select [chromium/src : main]

0 views

Skip to first unread message

Joey Arhar (Gerrit)

unread,

Jul 24, 2024, 1:27:29 PM (3 days ago) Jul 24

to Aaron Leventhal, Peter Kotwicz, (Julie)Jeongeun Kim, Kevin Babbitt, AyeAye, Chromium LUCI CQ, josiah...@chromium.org, abigailbk...@google.com, francisjp...@google.com, aleventhal...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, kyungjunle...@google.com, hirokisa...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Aaron Leventhal and Peter Kotwicz

Joey Arhar added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Joey Arhar . resolved

+aleventhal for the one question I have in an unresolved comment.
+pkotwicz for the whole patch.

File third_party/blink/web_tests/accessibility/native-select-activedescendant.html

File-level comment, Patchset 2:

Joey Arhar . unresolved

Hey Aaron, do you think this new element I'm adding should be included in the accessibility tree? I had to change some tests for it and now I'm wondering if I should instead add accessibility code to prevent it from being included in the accessibility tree.

It's a secret popover in the UA shadowroot which are going to use as an autofill preview. In appearance:auto mode, <select> and other form controls have a "preview" mode for autofill where they change their values to show the user what autofill will fill them with before the user actually commits to autofilling.

During this state, we don't want to let the page know anything about the autofilled value, so we can't just set the select's value to the new thing. Instead, we will have this popover to show the new value which the page shouldn't be able to tell exists.

Open in Gerrit

Related details

Attention is currently required from:

Aaron Leventhal
Peter Kotwicz

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Peter Kotwicz (Gerrit)

unread,

Jul 26, 2024, 3:57:55 PM (19 hours ago) Jul 26

to Joey Arhar, Aaron Leventhal, (Julie)Jeongeun Kim, Kevin Babbitt, AyeAye, Chromium LUCI CQ, josiah...@chromium.org, abigailbk...@google.com, francisjp...@google.com, aleventhal...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, kyungjunle...@google.com, hirokisa...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Aaron Leventhal and Joey Arhar

Peter Kotwicz added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Peter Kotwicz . resolved

I am reviewing this CL but its taking me a while to re-learn how selectlist works