inline-script-cache: plumb cachehint info to ClassicPendingScript [chromium/src : main]
0 views
Skip to first unread message
Takashi Nakayama (Gerrit)
Apr 20, 2026, 12:09:40 PM (2 days ago) Apr 20
to Kouhei Ueno, Hiroshige Hayashizaki, chromium...@chromium.org, Chromium LUCI CQ, Fredrik Söderquist, Stephen Chenney, Dirk Schulze, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, pdr+svgw...@chromium.org, kouhei...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, hiroshig...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
Apr 21, 2026, 12:25:38 AM (yesterday) Apr 21
to Takashi Nakayama, Kouhei Ueno, chromium...@chromium.org, Chromium LUCI CQ, Fredrik Söderquist, Stephen Chenney, Dirk Schulze, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, pdr+svgw...@chromium.org, kouhei...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, hiroshig...@chromium.org
Attention needed from Kouhei Ueno and Takashi Nakayama
Hiroshige Hayashizaki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hiroshige Hayashizaki
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/script/classic_pending_script.cc
Line 135, Patchset 5 (Latest):
CacheHintAttributeValue /*unused*/) {Hiroshige Hayashizaki . unresolved
nit optional: Adding a
```
// TODO(crbug.com/488755561): Actually use `CacheHintAttributeValue`.
```
might be helpful.
Related details
Attention is currently required from:
- Kouhei Ueno
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Nakayama (Gerrit)
Apr 21, 2026, 1:25:17 AM (yesterday) Apr 21
to Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Chromium LUCI CQ, Fredrik Söderquist, Stephen Chenney, Dirk Schulze, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, pdr+svgw...@chromium.org, kouhei...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, hiroshig...@chromium.org
Attention needed from Kouhei Ueno
Takashi Nakayama voted and added 1 comment![]( "Open in Gerrit")
Votes added by Takashi Nakayama
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/core/script/classic_pending_script.cc
Line 135, Patchset 5 (Latest):
CacheHintAttributeValue /*unused*/) {Hiroshige Hayashizaki . resolved
nit optional: Adding a
```
// TODO(crbug.com/488755561): Actually use `CacheHintAttributeValue`.
```might be helpful.
Takashi Nakayama
Ack. But let me do it in the next CL that I will upload soon
Related details
Attention is currently required from:
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Nakayama (Gerrit)
Apr 21, 2026, 3:47:06 AM (yesterday) Apr 21
to Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Chromium LUCI CQ, Fredrik Söderquist, Stephen Chenney, Dirk Schulze, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, pdr+svgw...@chromium.org, kouhei...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, hiroshig...@chromium.org
Attention needed from Kouhei Ueno
Takashi Nakayama voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 4:53:45 AM (yesterday) Apr 21
to Takashi Nakayama, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Fredrik Söderquist, Stephen Chenney, Dirk Schulze, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, pdr+svgw...@chromium.org, kouhei...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, hiroshig...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
inline-script-cache: plumb cachehint info to ClassicPendingScript
This CL adds support for retrieving and propagating the `cachehint`
attribute from script elements into the inline script creation
path in `ClassicPendingScript`. This introduces a typed representation
for cache hints extends `CreateInline()` signature to accept the cache
hint (currently unused) to enable future behavior changes without
changing the existing behaviors.
Bug: 488755561
Change-Id: If1386c7e61edc639b8938f746833f7e402a693de
Reviewed-by: Hiroshige Hayashizaki <hiro...@chromium.org>
Commit-Queue: Takashi Nakayama <tn...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618045}
Files:
- M third_party/blink/renderer/core/html/html_script_element.cc
- M third_party/blink/renderer/core/html/html_script_element.h
- M third_party/blink/renderer/core/script/build.gni
- A third_party/blink/renderer/core/script/cache_hint_attribute_value.cc
- A third_party/blink/renderer/core/script/cache_hint_attribute_value.h
- M third_party/blink/renderer/core/script/classic_pending_script.cc
- M third_party/blink/renderer/core/script/classic_pending_script.h
- M third_party/blink/renderer/core/script/mock_script_element_base.h
- M third_party/blink/renderer/core/script/script_element_base.h
- M third_party/blink/renderer/core/script/script_loader.cc
- M third_party/blink/renderer/core/svg/svg_script_element.h
Change size: M
Delta: 11 files changed, 61 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hiroshige Hayashizaki
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages