[code health] Remove StrictVideoWakeLock [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Apr 19, 2024, 4:03:25 PMApr 19
to Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo Da Costa, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mattreyno...@chromium.org, poscia...@chromium.org
Attention needed from Dave Tapuska

Dale Curtis voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id5354232a2717f9e3b09b31d7e8b5663379b806f
Gerrit-Change-Number: 5467547
Gerrit-PatchSet: 1
Gerrit-Owner: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Apr 2024 20:03:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Apr 19, 2024, 4:09:58 PMApr 19
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo Da Costa, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mattreyno...@chromium.org, poscia...@chromium.org

Dave Tapuska voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id5354232a2717f9e3b09b31d7e8b5663379b806f
Gerrit-Change-Number: 5467547
Gerrit-PatchSet: 1
Gerrit-Owner: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 20:09:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 19, 2024, 4:16:06 PMApr 19
to Dave Tapuska, Dale Curtis, chromium...@chromium.org, Raphael Kubo Da Costa, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, mattreyno...@chromium.org, poscia...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[code health] Remove StrictVideoWakeLock

This feature was the default for some time now. Remove feature flag.
Bug: 40850348
Change-Id: Id5354232a2717f9e3b09b31d7e8b5663379b806f
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: Dave Tapuska <dtap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290148}
Files:
  • M third_party/blink/renderer/core/html/media/video_wake_lock.cc
  • M third_party/blink/renderer/core/html/media/video_wake_lock_test.cc
Change size: M
Delta: 2 files changed, 24 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dale Curtis
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id5354232a2717f9e3b09b31d7e8b5663379b806f
Gerrit-Change-Number: 5467547
Gerrit-PatchSet: 2
Gerrit-Owner: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages