[SxS] Support dragging a link to SplitView to open [chromium/src : main]

0 views

Skip to first unread message

Alison Gale (Gerrit)

unread,

Oct 17, 2025, 4:13:07 PM (2 days ago) Oct 17

to AI Code Reviewer, Chromium LUCI CQ, AyeAye, Avi Drissman, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, blink-rev...@chromium.org, ajwong...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org

Alison Gale added 1 comment

File third_party/blink/renderer/core/page/drag_data.h

Line 58, Patchset 3: bool open_link_in_same_tab);

AI Code Reviewer . resolved

Blink Style Guide: Prefer enums or StrongAliases to bare bools for function parameters. The meaning of the `open_link_in_same_tab` boolean is not obvious at call sites, especially when multiple booleans are present. Please consider using a `base::StrongAlias<class OpenLinkInSameTabTag, bool>` to improve readability.
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Alison Gale

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages