Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[A11y] Remove AXObject::CachedParentObject() [chromium/src : main]

0 views
Skip to first unread message

Dominique Fauteux-Chapleau (Gerrit)

unread,
Apr 19, 2024, 9:20:56 AM4/19/24
to Aaron Leventhal, dpr...@google.com, Rijubrata Bhaumik, Peter Beverloo, Andrew Rayskiy, Kentaro Hara, Jiewei Qian, Enterprise Policy Reviews, Peter Collingbourne, Luna Lu, Nancy Wang, Kaan Icer, Christian Biesinger, Simon Hangl, Lei Zhang, Nico Weber, Zijie He, Reid Kleckner, Stephen Chenney, Nate Chapin, Hiroki Nakagawa, Ilya Biryukov, W. James Maclean, Giovanni Ortuno Urquidi, Avi Drissman, Chromium Metrics Reviews, Hans Wennborg, Olga Gerchikov, Charlie Hu, Alexis Menard, Mathias Bynens, Dirk Schulze, Daniel Cheng, Urvang Joshi, Peter Williamson, David Bokan, Kenneth Rohde Christiansen, Fredrik Söderquist, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios, fserb...@chromium.org, wychen...@chromium.org, jsaul+aut...@google.com, bhartmire+w...@google.com, apavlo...@chromium.org, browser-comp...@chromium.org, xhwang...@chromium.org, geoffla...@chromium.org, media-wi...@chromium.org, tsergea...@chromium.org, fuchsia...@chromium.org, mxcai+watch...@chromium.org, tbarzi...@chromium.org, blink-revi...@chromium.org, jmedle...@chromium.org, jkeitel+watch-...@google.com, michaelcheco+...@google.com, native-cli...@googlegroups.com, scheduler-...@chromium.org, chadduffin+w...@chromium.org, marimatthew+watc...@google.com, blink-revi...@chromium.org, spang...@chromium.org, yhanada+...@chromium.org, armalhotra+a...@google.com, feliciac+au...@google.com, antoniosarto...@chromium.org, ios-revie...@chromium.org, chromeos-en...@google.com, filesapp...@chromium.org, dominickn+...@chromium.org, mkwst+w...@chromium.org, keithle...@chromium.org, agriev...@chromium.org, kaklilu+watch-...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, achuit...@chromium.org, fuzzin...@chromium.org, shuche...@chromium.org, anastas...@google.com, michaelpg+wa...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, shannc...@chromium.org, zelin+watch-we...@chromium.org, katie...@chromium.org, gogerald+pa...@chromium.org, gavinp...@chromium.org, network-ser...@chromium.org, dullweb...@chromium.org, mickeybu...@chromium.org, cassiewang+w...@google.com, dominickn+w...@chromium.org, vakh+safe_br...@chromium.org, penghu...@chromium.org, blink-reviews-p...@chromium.org, jinsukk...@chromium.org, speed-metr...@chromium.org, rouslan+au...@chromium.org, druber...@chromium.org, dmurph+watchin...@chromium.org, eugeni...@chromium.org, chromium-...@engflow.com, andysjl...@chromium.org, alimariam+watch...@google.com, dmurph+watchi...@chromium.org, webap...@microsoft.com, tmartino+tran...@chromium.org, kinuko+...@chromium.org, blink-revie...@chromium.org, hansberry+w...@chromium.org, cclem+wat...@google.com, gcasto+w...@chromium.org, wangdanny+watch-in...@google.com, webapks-...@chromium.org, toshikikikuchi+...@chromium.org, jessemcke...@google.com, olesiamarukhno+wat...@google.com, yuezhang...@chromium.org, ender...@chromium.org, devtools-re...@chromium.org, hidehik...@chromium.org, loading-re...@chromium.org, jdonnel...@chromium.org, iclella...@chromium.org, cros-ed...@google.com, jasongustaman...@chromium.org, michaelcheco+watch-i...@google.com, stevenjb+wa...@chromium.org, permissio...@chromium.org, shimazu...@chromium.org, jackshira+w...@google.com, tjohnsonkanu+...@google.com, dominickn+watc...@chromium.org, hanxi...@chromium.org, hsuregan+wa...@chromium.org, shgar+aut...@google.com, mtomas...@chromium.org, alexmo...@chromium.org, blink-rev...@chromium.org, extension...@chromium.org, blink-re...@chromium.org, print-rev...@chromium.org, mac-r...@chromium.org, alancutter...@chromium.org, nona+...@chromium.org, jasonrhee+w...@google.com, apaselti...@chromium.org, blink-rev...@chromium.org, tedcho...@chromium.org, jonmann+wa...@chromium.org, longbowei+watc...@google.com, davidj...@chromium.org, scheduler...@chromium.org, tranbaod...@chromium.org, csharrison+...@chromium.org, grt+...@chromium.org, feature-me...@chromium.org, trewin...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, dom+...@chromium.org, yusufo...@chromium.org, blink-re...@chromium.org, jsbell+ser...@chromium.org, blink-re...@chromium.org, olesiamaru...@google.com, hugobenichi+...@google.com, steimel+...@chromium.org, lcwu+...@chromium.org, dibyapal+wa...@chromium.org, arc-review...@google.com, loyso...@chromium.org, rouslan+...@chromium.org, nicolas...@chromium.org, jimmyxgong+wat...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, ajwong...@chromium.org, rrsilva+wat...@google.com, dpad+watch-input...@google.com, lwinston+watc...@google.com, zhangwenyu+wat...@google.com, penghuan...@chromium.org, cblume...@chromium.org, csharris...@chromium.org, ejcaruso+wa...@chromium.org, chromeos-gfx-...@google.com, lize...@chromium.org, bcb+watch-pl...@chromium.org, jimmyxgong+watch...@chromium.org, vasilii+watchlis...@chromium.org, cc-...@chromium.org, philli...@chromium.org, pdf-r...@chromium.org, feature-v...@chromium.org, pdr+svgw...@chromium.org, tracing...@chromium.org, nikhilcn+wa...@google.com, kinuko...@chromium.org, chromium-a...@chromium.org, azeemarshad+...@chromium.org, wittma...@chromium.org, webauthn...@chromium.org, michaelpg+wa...@chromium.org, blink-re...@chromium.org, ukai+...@chromium.org, ajayramamurth...@google.com, ydago...@chromium.org, thegreenf...@chromium.org, elkuri...@chromium.org, chrome-os-ga...@google.com, croissant-...@chromium.org, cambickel+watc...@google.com, dominickn+wat...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org, estali...@chromium.org, mreichhoff+watc...@chromium.org, servicewor...@chromium.org, dmurph+wat...@chromium.org, arthursonzog...@chromium.org, nburris+pa...@chromium.org, xinghui...@chromium.org, chrome-b...@google.com, nwoked...@chromium.org, zhangwen...@google.com, marq+...@chromium.org, chromeos-ca...@google.com, wnwen+w...@chromium.org, navigation...@chromium.org, dmurph+watc...@chromium.org, michaelcheco+wa...@google.com, alemat...@chromium.org, droger+w...@chromium.org, cros-print...@google.com, drott+bl...@chromium.org, siyua+aut...@chromium.org, shimazu+se...@chromium.org, ffred...@chromium.org, dullweber+watch...@chromium.org, jimmyxgong+w...@chromium.org, cros-setti...@google.com, npm+...@chromium.org, telemetr...@chromium.org, bnc+...@chromium.org, wfh+...@chromium.org, loading-rev...@chromium.org, creis...@chromium.org, crostin...@chromium.org, gogeral...@chromium.org, chrome-intell...@chromium.org, dmurph+watch...@chromium.org, tluk+...@chromium.org, mgiuca...@chromium.org, lizeb...@chromium.org, dfried...@chromium.org, gab+...@chromium.org, zol...@webkit.org, net-r...@chromium.org, dewitt...@chromium.org, bmcquad...@chromium.org, tommasin+watch-...@chromium.org, srahim...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, kyungjun...@google.com, roblia...@chromium.org, blink-revie...@chromium.org, mattreyno...@chromium.org, siashah+au...@chromium.org, thefro...@chromium.org, fdoray...@chromium.org, blundell+...@chromium.org, dominickn+wat...@chromium.org, gbiv+...@chromium.org, andrewdear+w...@google.com, pkotwic...@chromium.org, dtseng+c...@chromium.org, zentaro+wat...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, gordonseto+w...@google.com, ericwillige...@chromium.org, asumane...@google.com, chfreme...@chromium.org, jiajunz+wa...@google.com, kenjibah...@chromium.org, kuragin+web-ap...@chromium.org, dominickn+...@chromium.org, gfhuan...@chromium.org, glenro...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, hiroshig...@chromium.org, ozone-...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, dominickn+watch-...@chromium.org, loading...@chromium.org, chuweih+wa...@google.com, jz...@chromium.org, dtraino...@chromium.org, mahmad...@chromium.org, drott...@chromium.org, vinnypersky+...@google.com, zackha...@chromium.org, dominickn+wat...@chromium.org, yyhyyh+watch-inpu...@google.com, cros-enterpris...@chromium.org, video-networking...@google.com, kinuko+ser...@chromium.org, yhanad...@chromium.org, zentaro+watch-a...@chromium.org, chromiumme...@microsoft.com, haoliu...@chromium.org, khorimoto+w...@chromium.org, glider...@chromium.org, horo+...@chromium.org, rhalava...@chromium.org, minap+watch-p...@google.com, chikamu...@chromium.org, gavinwill+watch-...@chromium.org, zentaro+watch...@chromium.org, yigu+...@chromium.org, ios-rev...@chromium.org, michaelpg+w...@chromium.org, chrome-waff...@google.com, halliwe...@chromium.org, hashimo...@chromium.org, sky+...@chromium.org, fmalit...@chromium.org, meilian...@chromium.org, chrome-mem...@google.com, msrame...@chromium.org, android-web...@chromium.org, poscia...@chromium.org, asvitkine...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal

Dominique Fauteux-Chapleau removed dpr...@google.com from this change

Deleted Reviewers:
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I004be17732acd7333cb63970711ec576cef759e3
Gerrit-Change-Number: 5464203
Gerrit-PatchSet: 7
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: Charlie Hu <chen...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Ilya Biryukov <ibir...@google.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nancy Wang <nancyl...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nico Weber <tha...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Collingbourne <p...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Reid Kleckner <r...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Urvang Joshi <urv...@chromium.org>
Gerrit-CC: W. James Maclean <wjma...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Aaron Leventhal <aleve...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Schillaci (Gerrit)

unread,
Apr 19, 2024, 11:02:36 AM4/19/24
to Aaron Leventhal, Rijubrata Bhaumik, Peter Beverloo, Andrew Rayskiy, Kentaro Hara, Jiewei Qian, Enterprise Policy Reviews, Peter Collingbourne, Luna Lu, Nancy Wang, Kaan Icer, Christian Biesinger, Simon Hangl, Lei Zhang, Nico Weber, Zijie He, Reid Kleckner, Stephen Chenney, Nate Chapin, Hiroki Nakagawa, Ilya Biryukov, W. James Maclean, Giovanni Ortuno Urquidi, Avi Drissman, Chromium Metrics Reviews, Hans Wennborg, Olga Gerchikov, Charlie Hu, Alexis Menard, Mathias Bynens, Dirk Schulze, Daniel Cheng, Urvang Joshi, Peter Williamson, David Bokan, Kenneth Rohde Christiansen, Fredrik Söderquist, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios, fserb...@chromium.org, wychen...@chromium.org, jsaul+aut...@google.com, bhartmire+w...@google.com, apavlo...@chromium.org, browser-comp...@chromium.org, xhwang...@chromium.org, geoffla...@chromium.org, media-wi...@chromium.org, tsergea...@chromium.org, fuchsia...@chromium.org, mxcai+watch...@chromium.org, tbarzi...@chromium.org, blink-revi...@chromium.org, jmedle...@chromium.org, jkeitel+watch-...@google.com, michaelcheco+...@google.com, native-cli...@googlegroups.com, scheduler-...@chromium.org, chadduffin+w...@chromium.org, marimatthew+watc...@google.com, blink-revi...@chromium.org, spang...@chromium.org, yhanada+...@chromium.org, armalhotra+a...@google.com, feliciac+au...@google.com, antoniosarto...@chromium.org, ios-revie...@chromium.org, chromeos-en...@google.com, filesapp...@chromium.org, dominickn+...@chromium.org, mkwst+w...@chromium.org, keithle...@chromium.org, agriev...@chromium.org, kaklilu+watch-...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, achuit...@chromium.org, fuzzin...@chromium.org, shuche...@chromium.org, anastas...@google.com, michaelpg+wa...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, shannc...@chromium.org, zelin+watch-we...@chromium.org, katie...@chromium.org, gogerald+pa...@chromium.org, gavinp...@chromium.org, network-ser...@chromium.org, dullweb...@chromium.org, mickeybu...@chromium.org, cassiewang+w...@google.com, dominickn+w...@chromium.org, vakh+safe_br...@chromium.org, penghu...@chromium.org, blink-reviews-p...@chromium.org, jinsukk...@chromium.org, speed-metr...@chromium.org, rouslan+au...@chromium.org, druber...@chromium.org, dmurph+watchin...@chromium.org, eugeni...@chromium.org, chromium-...@engflow.com, andysjl...@chromium.org, alimariam+watch...@google.com, dmurph+watchi...@chromium.org, webap...@microsoft.com, tmartino+tran...@chromium.org, kinuko+...@chromium.org, blink-revie...@chromium.org, hansberry+w...@chromium.org, cclem+wat...@google.com, gcasto+w...@chromium.org, wangdanny+watch-in...@google.com, webapks-...@chromium.org, toshikikikuchi+...@chromium.org, jessemcke...@google.com, olesiamarukhno+wat...@google.com, yuezhang...@chromium.org, ender...@chromium.org, devtools-re...@chromium.org, hidehik...@chromium.org, loading-re...@chromium.org, jdonnel...@chromium.org, iclella...@chromium.org, cros-ed...@google.com, jasongustaman...@chromium.org, michaelcheco+watch-i...@google.com, stevenjb+wa...@chromium.org, permissio...@chromium.org, shimazu...@chromium.org, jackshira+w...@google.com, tjohnsonkanu+...@google.com, dominickn+watc...@chromium.org, hanxi...@chromium.org, hsuregan+wa...@chromium.org, shgar+aut...@google.com, mtomas...@chromium.org, alexmo...@chromium.org, blink-rev...@chromium.org, extension...@chromium.org, blink-re...@chromium.org, print-rev...@chromium.org, mac-r...@chromium.org, alancutter...@chromium.org, nona+...@chromium.org, jasonrhee+w...@google.com, apaselti...@chromium.org, blink-rev...@chromium.org, tedcho...@chromium.org, jonmann+wa...@chromium.org, longbowei+watc...@google.com, davidj...@chromium.org, scheduler...@chromium.org, tranbaod...@chromium.org, csharrison+...@chromium.org, grt+...@chromium.org, feature-me...@chromium.org, trewin...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, dom+...@chromium.org, yusufo...@chromium.org, blink-re...@chromium.org, jsbell+ser...@chromium.org, blink-re...@chromium.org, olesiamaru...@google.com, hugobenichi+...@google.com, steimel+...@chromium.org, lcwu+...@chromium.org, dibyapal+wa...@chromium.org, arc-review...@google.com, loyso...@chromium.org, rouslan+...@chromium.org, nicolas...@chromium.org, jimmyxgong+wat...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, ajwong...@chromium.org, rrsilva+wat...@google.com, dpad+watch-input...@google.com, lwinston+watc...@google.com, zhangwenyu+wat...@google.com, penghuan...@chromium.org, cblume...@chromium.org, csharris...@chromium.org, ejcaruso+wa...@chromium.org, chromeos-gfx-...@google.com, lize...@chromium.org, bcb+watch-pl...@chromium.org, jimmyxgong+watch...@chromium.org, vasilii+watchlis...@chromium.org, cc-...@chromium.org, philli...@chromium.org, pdf-r...@chromium.org, feature-v...@chromium.org, pdr+svgw...@chromium.org, tracing...@chromium.org, nikhilcn+wa...@google.com, kinuko...@chromium.org, chromium-a...@chromium.org, azeemarshad+...@chromium.org, wittma...@chromium.org, webauthn...@chromium.org, michaelpg+wa...@chromium.org, blink-re...@chromium.org, ukai+...@chromium.org, ajayramamurth...@google.com, ydago...@chromium.org, thegreenf...@chromium.org, elkuri...@chromium.org, chrome-os-ga...@google.com, croissant-...@chromium.org, cambickel+watc...@google.com, dominickn+wat...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org, estali...@chromium.org, mreichhoff+watc...@chromium.org, servicewor...@chromium.org, dmurph+wat...@chromium.org, arthursonzog...@chromium.org, nburris+pa...@chromium.org, xinghui...@chromium.org, chrome-b...@google.com, nwoked...@chromium.org, zhangwen...@google.com, marq+...@chromium.org, chromeos-ca...@google.com, wnwen+w...@chromium.org, navigation...@chromium.org, dmurph+watc...@chromium.org, michaelcheco+wa...@google.com, alemat...@chromium.org, droger+w...@chromium.org, cros-print...@google.com, drott+bl...@chromium.org, siyua+aut...@chromium.org, shimazu+se...@chromium.org, ffred...@chromium.org, dullweber+watch...@chromium.org, jimmyxgong+w...@chromium.org, cros-setti...@google.com, npm+...@chromium.org, telemetr...@chromium.org, bnc+...@chromium.org, wfh+...@chromium.org, loading-rev...@chromium.org, creis...@chromium.org, crostin...@chromium.org, gogeral...@chromium.org, chrome-intell...@chromium.org, dmurph+watch...@chromium.org, tluk+...@chromium.org, mgiuca...@chromium.org, lizeb...@chromium.org, dfried...@chromium.org, gab+...@chromium.org, zol...@webkit.org, net-r...@chromium.org, dewitt...@chromium.org, bmcquad...@chromium.org, tommasin+watch-...@chromium.org, srahim...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, kyungjun...@google.com, roblia...@chromium.org, blink-revie...@chromium.org, mattreyno...@chromium.org, siashah+au...@chromium.org, thefro...@chromium.org, fdoray...@chromium.org, blundell+...@chromium.org, dominickn+wat...@chromium.org, gbiv+...@chromium.org, andrewdear+w...@google.com, pkotwic...@chromium.org, dtseng+c...@chromium.org, zentaro+wat...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, gordonseto+w...@google.com, ericwillige...@chromium.org, asumane...@google.com, chfreme...@chromium.org, jiajunz+wa...@google.com, kenjibah...@chromium.org, kuragin+web-ap...@chromium.org, dominickn+...@chromium.org, gfhuan...@chromium.org, glenro...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, hiroshig...@chromium.org, ozone-...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, dominickn+watch-...@chromium.org, loading...@chromium.org, chuweih+wa...@google.com, jz...@chromium.org, dtraino...@chromium.org, mahmad...@chromium.org, drott...@chromium.org, vinnypersky+...@google.com, zackha...@chromium.org, dominickn+wat...@chromium.org, yyhyyh+watch-inpu...@google.com, cros-enterpris...@chromium.org, video-networking...@google.com, kinuko+ser...@chromium.org, yhanad...@chromium.org, zentaro+watch-a...@chromium.org, chromiumme...@microsoft.com, haoliu...@chromium.org, khorimoto+w...@chromium.org, glider...@chromium.org, horo+...@chromium.org, rhalava...@chromium.org, minap+watch-p...@google.com, chikamu...@chromium.org, gavinwill+watch-...@chromium.org, zentaro+watch...@chromium.org, yigu+...@chromium.org, ios-rev...@chromium.org, michaelpg+w...@chromium.org, chrome-waff...@google.com, halliwe...@chromium.org, hashimo...@chromium.org, sky+...@chromium.org, fmalit...@chromium.org, meilian...@chromium.org, chrome-mem...@google.com, msrame...@chromium.org, android-web...@chromium.org, poscia...@chromium.org, asvitkine...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Aaron Leventhal

Mark Schillaci voted and added 1 comment

Votes added by Mark Schillaci

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Mark Schillaci . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I004be17732acd7333cb63970711ec576cef759e3
Gerrit-Change-Number: 5464203
Gerrit-PatchSet: 9
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 15:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Apr 19, 2024, 12:14:47 PM4/19/24
to Mark Schillaci, Rijubrata Bhaumik, Peter Beverloo, Andrew Rayskiy, Kentaro Hara, Jiewei Qian, Enterprise Policy Reviews, Peter Collingbourne, Luna Lu, Nancy Wang, Kaan Icer, Christian Biesinger, Simon Hangl, Lei Zhang, Nico Weber, Zijie He, Reid Kleckner, Stephen Chenney, Nate Chapin, Hiroki Nakagawa, Ilya Biryukov, W. James Maclean, Giovanni Ortuno Urquidi, Avi Drissman, Chromium Metrics Reviews, Hans Wennborg, Olga Gerchikov, Charlie Hu, Alexis Menard, Mathias Bynens, Dirk Schulze, Daniel Cheng, Urvang Joshi, Peter Williamson, David Bokan, Kenneth Rohde Christiansen, Fredrik Söderquist, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios, fserb...@chromium.org, wychen...@chromium.org, jsaul+aut...@google.com, bhartmire+w...@google.com, apavlo...@chromium.org, browser-comp...@chromium.org, xhwang...@chromium.org, geoffla...@chromium.org, media-wi...@chromium.org, tsergea...@chromium.org, fuchsia...@chromium.org, mxcai+watch...@chromium.org, tbarzi...@chromium.org, blink-revi...@chromium.org, jmedle...@chromium.org, jkeitel+watch-...@google.com, michaelcheco+...@google.com, native-cli...@googlegroups.com, scheduler-...@chromium.org, chadduffin+w...@chromium.org, marimatthew+watc...@google.com, blink-revi...@chromium.org, spang...@chromium.org, yhanada+...@chromium.org, armalhotra+a...@google.com, feliciac+au...@google.com, antoniosarto...@chromium.org, ios-revie...@chromium.org, chromeos-en...@google.com, filesapp...@chromium.org, dominickn+...@chromium.org, mkwst+w...@chromium.org, keithle...@chromium.org, agriev...@chromium.org, kaklilu+watch-...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, achuit...@chromium.org, fuzzin...@chromium.org, shuche...@chromium.org, anastas...@google.com, michaelpg+wa...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, shannc...@chromium.org, zelin+watch-we...@chromium.org, katie...@chromium.org, gogerald+pa...@chromium.org, gavinp...@chromium.org, network-ser...@chromium.org, dullweb...@chromium.org, mickeybu...@chromium.org, cassiewang+w...@google.com, dominickn+w...@chromium.org, vakh+safe_br...@chromium.org, penghu...@chromium.org, blink-reviews-p...@chromium.org, jinsukk...@chromium.org, speed-metr...@chromium.org, rouslan+au...@chromium.org, druber...@chromium.org, dmurph+watchin...@chromium.org, eugeni...@chromium.org, chromium-...@engflow.com, andysjl...@chromium.org, alimariam+watch...@google.com, dmurph+watchi...@chromium.org, webap...@microsoft.com, tmartino+tran...@chromium.org, kinuko+...@chromium.org, blink-revie...@chromium.org, hansberry+w...@chromium.org, cclem+wat...@google.com, gcasto+w...@chromium.org, wangdanny+watch-in...@google.com, webapks-...@chromium.org, toshikikikuchi+...@chromium.org, jessemcke...@google.com, olesiamarukhno+wat...@google.com, yuezhang...@chromium.org, ender...@chromium.org, devtools-re...@chromium.org, hidehik...@chromium.org, loading-re...@chromium.org, jdonnel...@chromium.org, iclella...@chromium.org, cros-ed...@google.com, jasongustaman...@chromium.org, michaelcheco+watch-i...@google.com, stevenjb+wa...@chromium.org, permissio...@chromium.org, shimazu...@chromium.org, jackshira+w...@google.com, tjohnsonkanu+...@google.com, dominickn+watc...@chromium.org, hanxi...@chromium.org, hsuregan+wa...@chromium.org, shgar+aut...@google.com, mtomas...@chromium.org, alexmo...@chromium.org, blink-rev...@chromium.org, extension...@chromium.org, blink-re...@chromium.org, print-rev...@chromium.org, mac-r...@chromium.org, alancutter...@chromium.org, nona+...@chromium.org, jasonrhee+w...@google.com, apaselti...@chromium.org, blink-rev...@chromium.org, tedcho...@chromium.org, jonmann+wa...@chromium.org, longbowei+watc...@google.com, davidj...@chromium.org, scheduler...@chromium.org, tranbaod...@chromium.org, csharrison+...@chromium.org, grt+...@chromium.org, feature-me...@chromium.org, trewin...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, dom+...@chromium.org, yusufo...@chromium.org, blink-re...@chromium.org, jsbell+ser...@chromium.org, blink-re...@chromium.org, olesiamaru...@google.com, hugobenichi+...@google.com, steimel+...@chromium.org, lcwu+...@chromium.org, dibyapal+wa...@chromium.org, arc-review...@google.com, loyso...@chromium.org, rouslan+...@chromium.org, nicolas...@chromium.org, jimmyxgong+wat...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, ajwong...@chromium.org, rrsilva+wat...@google.com, dpad+watch-input...@google.com, lwinston+watc...@google.com, zhangwenyu+wat...@google.com, penghuan...@chromium.org, cblume...@chromium.org, csharris...@chromium.org, ejcaruso+wa...@chromium.org, chromeos-gfx-...@google.com, lize...@chromium.org, bcb+watch-pl...@chromium.org, jimmyxgong+watch...@chromium.org, vasilii+watchlis...@chromium.org, cc-...@chromium.org, philli...@chromium.org, pdf-r...@chromium.org, feature-v...@chromium.org, pdr+svgw...@chromium.org, tracing...@chromium.org, nikhilcn+wa...@google.com, kinuko...@chromium.org, chromium-a...@chromium.org, azeemarshad+...@chromium.org, wittma...@chromium.org, webauthn...@chromium.org, michaelpg+wa...@chromium.org, blink-re...@chromium.org, ukai+...@chromium.org, ajayramamurth...@google.com, ydago...@chromium.org, thegreenf...@chromium.org, elkuri...@chromium.org, chrome-os-ga...@google.com, croissant-...@chromium.org, cambickel+watc...@google.com, dominickn+wat...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org, estali...@chromium.org, mreichhoff+watc...@chromium.org, servicewor...@chromium.org, dmurph+wat...@chromium.org, arthursonzog...@chromium.org, nburris+pa...@chromium.org, xinghui...@chromium.org, chrome-b...@google.com, nwoked...@chromium.org, zhangwen...@google.com, marq+...@chromium.org, chromeos-ca...@google.com, wnwen+w...@chromium.org, navigation...@chromium.org, dmurph+watc...@chromium.org, michaelcheco+wa...@google.com, alemat...@chromium.org, droger+w...@chromium.org, cros-print...@google.com, drott+bl...@chromium.org, siyua+aut...@chromium.org, shimazu+se...@chromium.org, ffred...@chromium.org, dullweber+watch...@chromium.org, jimmyxgong+w...@chromium.org, cros-setti...@google.com, npm+...@chromium.org, telemetr...@chromium.org, bnc+...@chromium.org, wfh+...@chromium.org, loading-rev...@chromium.org, creis...@chromium.org, crostin...@chromium.org, gogeral...@chromium.org, chrome-intell...@chromium.org, dmurph+watch...@chromium.org, tluk+...@chromium.org, mgiuca...@chromium.org, lizeb...@chromium.org, dfried...@chromium.org, gab+...@chromium.org, zol...@webkit.org, net-r...@chromium.org, dewitt...@chromium.org, bmcquad...@chromium.org, tommasin+watch-...@chromium.org, srahim...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, kyungjun...@google.com, roblia...@chromium.org, blink-revie...@chromium.org, mattreyno...@chromium.org, siashah+au...@chromium.org, thefro...@chromium.org, fdoray...@chromium.org, blundell+...@chromium.org, dominickn+wat...@chromium.org, gbiv+...@chromium.org, andrewdear+w...@google.com, pkotwic...@chromium.org, dtseng+c...@chromium.org, zentaro+wat...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, gordonseto+w...@google.com, ericwillige...@chromium.org, asumane...@google.com, chfreme...@chromium.org, jiajunz+wa...@google.com, kenjibah...@chromium.org, kuragin+web-ap...@chromium.org, dominickn+...@chromium.org, gfhuan...@chromium.org, glenro...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, hiroshig...@chromium.org, ozone-...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, dominickn+watch-...@chromium.org, loading...@chromium.org, chuweih+wa...@google.com, jz...@chromium.org, dtraino...@chromium.org, mahmad...@chromium.org, drott...@chromium.org, vinnypersky+...@google.com, zackha...@chromium.org, dominickn+wat...@chromium.org, yyhyyh+watch-inpu...@google.com, cros-enterpris...@chromium.org, video-networking...@google.com, kinuko+ser...@chromium.org, yhanad...@chromium.org, zentaro+watch-a...@chromium.org, chromiumme...@microsoft.com, haoliu...@chromium.org, khorimoto+w...@chromium.org, glider...@chromium.org, horo+...@chromium.org, rhalava...@chromium.org, minap+watch-p...@google.com, chikamu...@chromium.org, gavinwill+watch-...@chromium.org, zentaro+watch...@chromium.org, yigu+...@chromium.org, ios-rev...@chromium.org, michaelpg+w...@chromium.org, chrome-waff...@google.com, halliwe...@chromium.org, hashimo...@chromium.org, sky+...@chromium.org, fmalit...@chromium.org, meilian...@chromium.org, chrome-mem...@google.com, msrame...@chromium.org, android-web...@chromium.org, poscia...@chromium.org, asvitkine...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Aaron Leventhal voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Fri, 19 Apr 2024 16:14:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 19, 2024, 12:18:16 PM4/19/24
to Aaron Leventhal, Mark Schillaci, Rijubrata Bhaumik, Peter Beverloo, Andrew Rayskiy, Kentaro Hara, Jiewei Qian, Enterprise Policy Reviews, Peter Collingbourne, Luna Lu, Nancy Wang, Kaan Icer, Christian Biesinger, Simon Hangl, Lei Zhang, Nico Weber, Zijie He, Reid Kleckner, Stephen Chenney, Nate Chapin, Hiroki Nakagawa, Ilya Biryukov, W. James Maclean, Giovanni Ortuno Urquidi, Avi Drissman, Chromium Metrics Reviews, Hans Wennborg, Olga Gerchikov, Charlie Hu, Alexis Menard, Mathias Bynens, Dirk Schulze, Daniel Cheng, Urvang Joshi, Peter Williamson, David Bokan, Kenneth Rohde Christiansen, Fredrik Söderquist, Kevin McNee, AyeAye, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios, fserb...@chromium.org, wychen...@chromium.org, jsaul+aut...@google.com, bhartmire+w...@google.com, apavlo...@chromium.org, browser-comp...@chromium.org, xhwang...@chromium.org, geoffla...@chromium.org, media-wi...@chromium.org, tsergea...@chromium.org, fuchsia...@chromium.org, mxcai+watch...@chromium.org, tbarzi...@chromium.org, blink-revi...@chromium.org, jmedle...@chromium.org, jkeitel+watch-...@google.com, michaelcheco+...@google.com, native-cli...@googlegroups.com, scheduler-...@chromium.org, chadduffin+w...@chromium.org, marimatthew+watc...@google.com, blink-revi...@chromium.org, spang...@chromium.org, yhanada+...@chromium.org, armalhotra+a...@google.com, feliciac+au...@google.com, antoniosarto...@chromium.org, ios-revie...@chromium.org, chromeos-en...@google.com, filesapp...@chromium.org, dominickn+...@chromium.org, mkwst+w...@chromium.org, keithle...@chromium.org, agriev...@chromium.org, kaklilu+watch-...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, achuit...@chromium.org, fuzzin...@chromium.org, shuche...@chromium.org, anastas...@google.com, michaelpg+wa...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, shannc...@chromium.org, zelin+watch-we...@chromium.org, katie...@chromium.org, gogerald+pa...@chromium.org, gavinp...@chromium.org, network-ser...@chromium.org, dullweb...@chromium.org, mickeybu...@chromium.org, cassiewang+w...@google.com, dominickn+w...@chromium.org, vakh+safe_br...@chromium.org, penghu...@chromium.org, blink-reviews-p...@chromium.org, jinsukk...@chromium.org, speed-metr...@chromium.org, rouslan+au...@chromium.org, druber...@chromium.org, dmurph+watchin...@chromium.org, eugeni...@chromium.org, chromium-...@engflow.com, andysjl...@chromium.org, alimariam+watch...@google.com, dmurph+watchi...@chromium.org, webap...@microsoft.com, tmartino+tran...@chromium.org, kinuko+...@chromium.org, blink-revie...@chromium.org, hansberry+w...@chromium.org, cclem+wat...@google.com, gcasto+w...@chromium.org, wangdanny+watch-in...@google.com, webapks-...@chromium.org, toshikikikuchi+...@chromium.org, jessemcke...@google.com, olesiamarukhno+wat...@google.com, yuezhang...@chromium.org, ender...@chromium.org, devtools-re...@chromium.org, hidehik...@chromium.org, loading-re...@chromium.org, jdonnel...@chromium.org, iclella...@chromium.org, cros-ed...@google.com, jasongustaman...@chromium.org, michaelcheco+watch-i...@google.com, stevenjb+wa...@chromium.org, permissio...@chromium.org, shimazu...@chromium.org, jackshira+w...@google.com, tjohnsonkanu+...@google.com, dominickn+watc...@chromium.org, hanxi...@chromium.org, hsuregan+wa...@chromium.org, shgar+aut...@google.com, mtomas...@chromium.org, alexmo...@chromium.org, blink-rev...@chromium.org, extension...@chromium.org, blink-re...@chromium.org, print-rev...@chromium.org, mac-r...@chromium.org, alancutter...@chromium.org, nona+...@chromium.org, jasonrhee+w...@google.com, apaselti...@chromium.org, blink-rev...@chromium.org, tedcho...@chromium.org, jonmann+wa...@chromium.org, longbowei+watc...@google.com, davidj...@chromium.org, scheduler...@chromium.org, tranbaod...@chromium.org, csharrison+...@chromium.org, grt+...@chromium.org, feature-me...@chromium.org, trewin...@google.com, jackshira+w...@google.com, kinuko...@chromium.org, dom+...@chromium.org, yusufo...@chromium.org, blink-re...@chromium.org, jsbell+ser...@chromium.org, blink-re...@chromium.org, olesiamaru...@google.com, hugobenichi+...@google.com, steimel+...@chromium.org, lcwu+...@chromium.org, dibyapal+wa...@chromium.org, arc-review...@google.com, loyso...@chromium.org, rouslan+...@chromium.org, nicolas...@chromium.org, jimmyxgong+wat...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, ajwong...@chromium.org, rrsilva+wat...@google.com, dpad+watch-input...@google.com, lwinston+watc...@google.com, zhangwenyu+wat...@google.com, penghuan...@chromium.org, cblume...@chromium.org, csharris...@chromium.org, ejcaruso+wa...@chromium.org, chromeos-gfx-...@google.com, lize...@chromium.org, bcb+watch-pl...@chromium.org, jimmyxgong+watch...@chromium.org, vasilii+watchlis...@chromium.org, cc-...@chromium.org, philli...@chromium.org, pdf-r...@chromium.org, feature-v...@chromium.org, pdr+svgw...@chromium.org, tracing...@chromium.org, nikhilcn+wa...@google.com, kinuko...@chromium.org, chromium-a...@chromium.org, azeemarshad+...@chromium.org, wittma...@chromium.org, webauthn...@chromium.org, michaelpg+wa...@chromium.org, blink-re...@chromium.org, ukai+...@chromium.org, ajayramamurth...@google.com, ydago...@chromium.org, thegreenf...@chromium.org, elkuri...@chromium.org, chrome-os-ga...@google.com, croissant-...@chromium.org, cambickel+watc...@google.com, dominickn+wat...@chromium.org, performance-m...@chromium.org, yhanada+...@chromium.org, estali...@chromium.org, mreichhoff+watc...@chromium.org, servicewor...@chromium.org, dmurph+wat...@chromium.org, arthursonzog...@chromium.org, nburris+pa...@chromium.org, xinghui...@chromium.org, chrome-b...@google.com, nwoked...@chromium.org, zhangwen...@google.com, marq+...@chromium.org, chromeos-ca...@google.com, wnwen+w...@chromium.org, navigation...@chromium.org, dmurph+watc...@chromium.org, michaelcheco+wa...@google.com, alemat...@chromium.org, droger+w...@chromium.org, cros-print...@google.com, drott+bl...@chromium.org, siyua+aut...@chromium.org, shimazu+se...@chromium.org, ffred...@chromium.org, dullweber+watch...@chromium.org, jimmyxgong+w...@chromium.org, cros-setti...@google.com, npm+...@chromium.org, telemetr...@chromium.org, bnc+...@chromium.org, wfh+...@chromium.org, loading-rev...@chromium.org, creis...@chromium.org, crostin...@chromium.org, gogeral...@chromium.org, chrome-intell...@chromium.org, dmurph+watch...@chromium.org, tluk+...@chromium.org, mgiuca...@chromium.org, lizeb...@chromium.org, dfried...@chromium.org, gab+...@chromium.org, zol...@webkit.org, net-r...@chromium.org, dewitt...@chromium.org, bmcquad...@chromium.org, tommasin+watch-...@chromium.org, srahim...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, rginda...@chromium.org, kyungjun...@google.com, roblia...@chromium.org, blink-revie...@chromium.org, mattreyno...@chromium.org, siashah+au...@chromium.org, thefro...@chromium.org, fdoray...@chromium.org, blundell+...@chromium.org, dominickn+wat...@chromium.org, gbiv+...@chromium.org, andrewdear+w...@google.com, pkotwic...@chromium.org, dtseng+c...@chromium.org, zentaro+wat...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, gordonseto+w...@google.com, ericwillige...@chromium.org, asumane...@google.com, chfreme...@chromium.org, jiajunz+wa...@google.com, kenjibah...@chromium.org, kuragin+web-ap...@chromium.org, dominickn+...@chromium.org, gfhuan...@chromium.org, glenro...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, hiroshig...@chromium.org, ozone-...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, dominickn+watch-...@chromium.org, loading...@chromium.org, chuweih+wa...@google.com, jz...@chromium.org, dtraino...@chromium.org, mahmad...@chromium.org, drott...@chromium.org, vinnypersky+...@google.com, zackha...@chromium.org, dominickn+wat...@chromium.org, yyhyyh+watch-inpu...@google.com, cros-enterpris...@chromium.org, video-networking...@google.com, kinuko+ser...@chromium.org, yhanad...@chromium.org, zentaro+watch-a...@chromium.org, chromiumme...@microsoft.com, haoliu...@chromium.org, khorimoto+w...@chromium.org, glider...@chromium.org, horo+...@chromium.org, rhalava...@chromium.org, minap+watch-p...@google.com, chikamu...@chromium.org, gavinwill+watch-...@chromium.org, zentaro+watch...@chromium.org, yigu+...@chromium.org, ios-rev...@chromium.org, michaelpg+w...@chromium.org, chrome-waff...@google.com, halliwe...@chromium.org, hashimo...@chromium.org, sky+...@chromium.org, fmalit...@chromium.org, meilian...@chromium.org, chrome-mem...@google.com, msrame...@chromium.org, android-web...@chromium.org, poscia...@chromium.org, asvitkine...@chromium.org, devtools...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[A11y] Remove AXObject::CachedParentObject()

The parent is always cached, so in general we can just use
ParentObject().

However, there are some cases where we don't want to assert that the
parent is missing, for example, when building or tearing down
parent-child relationships. In these few cases, use
ParentObjectIfPresent(), which is basically the same as
CachedParentObject() was, but with a more appropriate name,
and used less. Most callers should just use ParentObject() because
in most code paths all parents should exist.
Bug: none
Change-Id: I004be17732acd7333cb63970711ec576cef759e3
Commit-Queue: Aaron Leventhal <aleve...@chromium.org>
Reviewed-by: Mark Schillaci <mschi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1289980}
Files:
  • M third_party/blink/renderer/modules/accessibility/ax_debug_utils.cc
  • M third_party/blink/renderer/modules/accessibility/ax_inline_text_box.cc
  • M third_party/blink/renderer/modules/accessibility/ax_menu_list.cc
  • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object.h
  • M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
  • M third_party/blink/renderer/modules/accessibility/ax_relation_cache.cc
  • M third_party/blink/renderer/modules/accessibility/ax_validation_message.cc
Change size: M
Delta: 9 files changed, 73 insertions(+), 72 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Schillaci
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I004be17732acd7333cb63970711ec576cef759e3
Gerrit-Change-Number: 5464203
Gerrit-PatchSet: 10
Gerrit-Owner: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Aaron Leventhal <aleve...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: Charlie Hu <chen...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages