Parse declarative shadow roots in stream*HTML [chromium/src : main]

0 views
Skip to first unread message

Noam Rosenthal (Gerrit)

unread,
Apr 14, 2026, 9:35:40 AMApr 14
to Philip Jägenstedt, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal and Philip Jägenstedt

Message from Noam Rosenthal

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
  • Philip Jägenstedt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
Gerrit-Change-Number: 7711816
Gerrit-PatchSet: 5
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Tue, 14 Apr 2026 13:35:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Jägenstedt (Gerrit)

unread,
Apr 14, 2026, 11:03:40 AMApr 14
to Noam Rosenthal, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal

Philip Jägenstedt added 1 comment

File third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-declarative-shadow-root.html
Line 3, Patchset 5 (Latest):<title>HTML partial updates - streaming with sanitizer</title>
Philip Jägenstedt . unresolved

Title is copypasta? And should there be a test that doesn't involve sanitizer, just DSD?

Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
    Gerrit-Change-Number: 7711816
    Gerrit-PatchSet: 5
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 15:03:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Noam Rosenthal (Gerrit)

    unread,
    Apr 14, 2026, 12:39:44 PMApr 14
    to Philip Jägenstedt, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Philip Jägenstedt

    Noam Rosenthal added 1 comment

    File third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-declarative-shadow-root.html
    Line 3, Patchset 5:<title>HTML partial updates - streaming with sanitizer</title>
    Philip Jägenstedt . resolved

    Title is copypasta? And should there be a test that doesn't involve sanitizer, just DSD?

    Noam Rosenthal

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Philip Jägenstedt
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Gerrit-Change-Number: 7711816
      Gerrit-PatchSet: 5
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Comment-Date: Tue, 14 Apr 2026 16:39:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Philip Jägenstedt <foo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Philip Jägenstedt (Gerrit)

      unread,
      Apr 17, 2026, 10:27:22 AM (13 days ago) Apr 17
      to Noam Rosenthal, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Noam Rosenthal

      Philip Jägenstedt voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Noam Rosenthal
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Gerrit-Change-Number: 7711816
      Gerrit-PatchSet: 6
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 14:27:04 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Apr 17, 2026, 10:50:49 AM (13 days ago) Apr 17
      to Noam Rosenthal, Philip Jägenstedt, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Noam Rosenthal

      Message from Blink W3C Test Autoroller

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59316.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Noam Rosenthal
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Gerrit-Change-Number: 7711816
      Gerrit-PatchSet: 6
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 14:50:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Noam Rosenthal (Gerrit)

      unread,
      Apr 17, 2026, 2:42:38 PM (13 days ago) Apr 17
      to Blink W3C Test Autoroller, Philip Jägenstedt, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Noam Rosenthal voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Gerrit-Change-Number: 7711816
      Gerrit-PatchSet: 6
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 18:42:16 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Noam Rosenthal (Gerrit)

      unread,
      Apr 17, 2026, 4:12:45 PM (13 days ago) Apr 17
      to Blink W3C Test Autoroller, Philip Jägenstedt, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Gerrit-Comment-Date: Fri, 17 Apr 2026 20:12:20 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 17, 2026, 5:25:51 PM (12 days ago) Apr 17
      to Noam Rosenthal, Blink W3C Test Autoroller, Philip Jägenstedt, Code Review Nudger, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Parse declarative shadow roots in stream*HTML
      Bug: 491743369
      Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
      Commit-Queue: Noam Rosenthal <nrose...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1616858}
      Files:
      • M third_party/blink/renderer/core/html/html_stream.cc
      • A third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-declarative-shadow-root.html
      Change size: M
      Delta: 2 files changed, 77 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Philip Jägenstedt
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Gerrit-Change-Number: 7711816
      Gerrit-PatchSet: 7
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Apr 17, 2026, 9:24:04 PM (12 days ago) Apr 17
      to Chromium LUCI CQ, Noam Rosenthal, Philip Jägenstedt, Code Review Nudger, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59316

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
      Gerrit-Change-Number: 7711816
      Gerrit-PatchSet: 7
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Comment-Date: Sat, 18 Apr 2026 01:23:59 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages