Parse declarative shadow roots in stream*HTML [chromium/src : main]
0 views
Skip to first unread message
Noam Rosenthal (Gerrit)
Apr 14, 2026, 9:35:40 AMApr 14
to Philip Jägenstedt, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal and Philip Jägenstedt
Message from Noam Rosenthal![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Noam Rosenthal
- Philip Jägenstedt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Jägenstedt (Gerrit)
Apr 14, 2026, 11:03:40 AMApr 14
to Noam Rosenthal, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Philip Jägenstedt added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-declarative-shadow-root.html
Line 3, Patchset 5 (Latest):
<title>HTML partial updates - streaming with sanitizer</title>Philip Jägenstedt . unresolved
Title is copypasta? And should there be a test that doesn't involve sanitizer, just DSD?
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Apr 14, 2026, 12:39:44 PMApr 14
to Philip Jägenstedt, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Philip Jägenstedt
Noam Rosenthal added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-declarative-shadow-root.html
Line 3, Patchset 5:
<title>HTML partial updates - streaming with sanitizer</title>Philip Jägenstedt . resolved
Title is copypasta? And should there be a test that doesn't involve sanitizer, just DSD?
Attention is currently required from:
- Philip Jägenstedt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Jägenstedt (Gerrit)
Apr 17, 2026, 10:27:22 AM (13 days ago) Apr 17
to Noam Rosenthal, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Philip Jägenstedt voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 17, 2026, 10:50:49 AM (13 days ago) Apr 17
to Noam Rosenthal, Philip Jägenstedt, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59316.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Apr 17, 2026, 2:42:38 PM (13 days ago) Apr 17
to Blink W3C Test Autoroller, Philip Jägenstedt, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Noam Rosenthal voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 17, 2026, 5:25:51 PM (12 days ago) Apr 17
to Noam Rosenthal, Blink W3C Test Autoroller, Philip Jägenstedt, Code Review Nudger, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Parse declarative shadow roots in stream*HTML
Bug: 491743369
Change-Id: Ia7b922c90920bbdd2212e9385f2657eb4cf5d187
Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
Commit-Queue: Noam Rosenthal <nrose...@google.com>
Cr-Commit-Position: refs/heads/main@{#1616858}
Files:
- M third_party/blink/renderer/core/html/html_stream.cc
- A third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-html-with-declarative-shadow-root.html
Change size: M
Delta: 2 files changed, 77 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Jägenstedt
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 17, 2026, 9:24:04 PM (12 days ago) Apr 17
to Chromium LUCI CQ, Noam Rosenthal, Philip Jägenstedt, Code Review Nudger, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59316
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages