Remove PreconnectInNetworkService and PreconnectOnRedirect features. [chromium/src : main]
0 views
Skip to first unread message
John Abd-El-Malek (Gerrit)
Mar 21, 2023, 12:41:31 AM3/21/23
to android-web...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention is currently required from: John Abd-El-Malek.
John Abd-El-Malek uploaded patch set #8 to this change.
Remove PreconnectInNetworkService and PreconnectOnRedirect features.
They didn't have a performance improvement. Also:
1) keep the fix for link tag/header dns-prefetch using the wrong
scheme for https links
2) remove the code to pre-resolve DNS for all links in frames loaded
over http, since stopping that didn't show any performance regression
3) keep dns-prefetch and preconnect enabled for WebView for
compatibility with Chrome
Bug: 1357161, 1374109
Change-Id: Iee502a1248248fd017539097cf5dd02f330cd052
---
M android_webview/browser/aw_content_browser_client_receiver_bindings.cc
M android_webview/common/aw_features.cc
M android_webview/common/aw_features.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/renderer/aw_content_renderer_client.cc
M chrome/browser/chrome_content_browser_client.cc
M chrome/browser/chrome_content_browser_client.h
M chrome/browser/net/profile_network_context_service.cc
M chrome/browser/net/profile_network_context_service.h
M chrome/browser/predictors/loading_predictor_browsertest.cc
M components/BUILD.gn
M components/network_hints/renderer/BUILD.gn
D components/network_hints/renderer/dns_prefetch_queue.cc
D components/network_hints/renderer/dns_prefetch_queue.h
D components/network_hints/renderer/dns_prefetch_queue_unittest.cc
D components/network_hints/renderer/renderer_dns_prefetch.cc
D components/network_hints/renderer/renderer_dns_prefetch.h
D components/network_hints/renderer/renderer_dns_prefetch_unittest.cc
M components/network_hints/renderer/web_prescient_networking_impl.cc
M components/network_hints/renderer/web_prescient_networking_impl.h
M services/network/cors/cors_url_loader.cc
M services/network/network_context.cc
M services/network/network_context.h
M services/network/public/cpp/features.cc
M services/network/public/cpp/features.h
M services/network/public/mojom/network_context.mojom
M services/network/test/test_network_context.h
M testing/variations/fieldtrial_testing_config.json
M third_party/blink/renderer/core/html/html_anchor_element.cc
29 files changed, 8 insertions(+), 1,165 deletions(-)
To view, visit change 4278823. To unsubscribe, or for help writing mail filters, visit settings.
John Abd-El-Malek (Gerrit)
Mar 21, 2023, 12:41:47 AM3/21/23
to android-web...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, Richard Coles, Scott Violet, Adam Rice, Will Harris, Nate Chapin, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Patch set 8:Auto-Submit +1Commit-Queue +2
2 comments:
Commit Message:
Patch Set #4, Line 9:
Keep the fix for link tag/header dns-prefetch using the wrong scheme for https links. Also remove the code to pre-resolve DNS for all links in frames loaded over http, since stopping that didn't show any performance regression.Please wrap commit messages to 72 characters so they look nice in git log.
Done
File android_webview/common/aw_features.cc:
Patch Set #4, Line 70:
// Enable dns-prefetch and preconnect in link tags and HTTP header.I couldn't see where the removal of this feature was mentioned in the commit message. […]
Done
To view, visit change 4278823. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Mar 21, 2023, 1:45:30 AM3/21/23
to John Abd-El-Malek, android-web...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, Richard Coles, Scott Violet, Adam Rice, Will Harris, Nate Chapin, Chromium IPC Reviews, Chromium Metrics Reviews, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Approvals:
Richard Coles: Looks good to me
Scott Violet: Looks good to me
Will Harris: Looks good to me
Adam Rice: Looks good to me
Nate Chapin: Looks good to me
John Abd-El-Malek: Send CL to CQ automatically after approval; Commit
Remove PreconnectInNetworkService and PreconnectOnRedirect features.
They didn't have a performance improvement. Also:
1) keep the fix for link tag/header dns-prefetch using the wrong
scheme for https links
2) remove the code to pre-resolve DNS for all links in frames loaded
over http, since stopping that didn't show any performance regression
3) keep dns-prefetch and preconnect enabled for WebView for
compatibility with Chrome
Bug: 1357161, 1374109
Change-Id: Iee502a1248248fd017539097cf5dd02f330cd052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278823
Reviewed-by: Adam Rice <ri...@chromium.org>
Commit-Queue: John Abd-El-Malek <j...@chromium.org>
Reviewed-by: Will Harris <w...@chromium.org>
Auto-Submit: John Abd-El-Malek <j...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Reviewed-by: Scott Violet <s...@chromium.org>
Reviewed-by: Richard Coles <to...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119785}
Reply all
Reply to author
Forward
0 new messages