Revert "Remove some leftover references to Supplement." [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Dec 10, 2025, 7:23:55 AM (3 days ago) Dec 10
to Arnaud Mandy, Permissions Reviews, Rijubrata Bhaumik, Kaan Icer, Nate Chapin, Raphael Kubo da Costa, Simon Hangl, Hiroki Nakagawa, Luna Lu, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Gyuyoung Kim, Daniel Cheng, Wanming Lin, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Wang, Wei4, Andrew Rayskiy, Xida Chen, Kenneth R Christiansen, prerendering-reviews, Stephen Chenney, David Bokan, Christian Biesinger, Hongchan Choi, Yoav Weiss (@Shopify), Dirk Schulze, Peter Beverloo, iclella...@chromium.org, blink-rev...@chromium.org, nator...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, npm+...@chromium.org, dtapuska+...@chromium.org, storage...@chromium.org, blink-...@chromium.org, blink-revi...@chromium.org, dmurph+watch...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, kinuko...@chromium.org, giovax...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, tommyw+w...@chromium.org, kinuko+...@chromium.org, kainin...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, servicewor...@chromium.org, dcheng+c...@chromium.org, speed-metrics...@chromium.org, eric.c...@apple.com, rmcelra...@chromium.org, kouhe...@chromium.org, webap...@microsoft.com, blink-re...@chromium.org, odejesu...@chromium.org, horo+...@chromium.org, mattreyno...@chromium.org, blink-revi...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, sloboda...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, dmurph+watchi...@chromium.org, toyosh...@chromium.org, webauthn...@chromium.org, dmurph+wa...@chromium.org, jkarli...@chromium.org, rayanka...@chromium.org, yigu+...@chromium.org, aleventh...@chromium.org, mgiuca...@chromium.org, kinuko+ser...@chromium.org, gavinp...@chromium.org, fmalit...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, video-networking...@google.com, edgesto...@microsoft.com, derinel+wat...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, enne...@chromium.org, mfoltz+wa...@chromium.org, pkotwic...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, web-schedulin...@chromium.org, dominicc+...@chromium.org, extension...@chromium.org
Attention needed from Daniel Cheng

Steinar H Gunderson has uploaded the change for review

Steinar H Gunderson would like Daniel Cheng to review this change.

Commit message

Revert "Remove some leftover references to Supplement."

This reverts commit 173bc8cbb96fa41dd0df7e88b549b9ad379daef6.
(See blink-dev for background.)
Bug: 460165754

Change diff


Change information

Files:
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/execution_context/navigator_base.h
  • M third_party/blink/renderer/core/execution_context/window_agent.h
  • M third_party/blink/renderer/core/frame/local_frame.cc
  • M third_party/blink/renderer/core/html/media/html_video_element.h
  • M third_party/blink/renderer/core/route_matching/route_map.cc
  • M third_party/blink/renderer/core/route_matching/route_map.h
  • M third_party/blink/renderer/modules/ad_auction/navigator_auction.h
  • M third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.cc
  • M third_party/blink/renderer/modules/cookie_store/global_cookie_store.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.h
  • M third_party/blink/renderer/modules/presentation/presentation_controller.h
  • M third_party/blink/renderer/modules/webshare/navigator_share.h
Change size: S
Delta: 13 files changed, 24 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0f3f2cad5c86359f5d493a2201bbd50ce87e868c
Gerrit-Change-Number: 7246275
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 10, 2025, 3:20:33 PM (2 days ago) Dec 10
to Steinar H Gunderson, Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org
Attention needed from Steinar H Gunderson

Daniel Cheng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Dec 2025 20:20:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Dec 11, 2025, 3:35:13 AM (yesterday) Dec 11
to Arnaud Mandy, Permissions Reviews, Rijubrata Bhaumik, Kaan Icer, Nate Chapin, Raphael Kubo da Costa, Simon Hangl, Hiroki Nakagawa, Luna Lu, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Gyuyoung Kim, Daniel Cheng, Wanming Lin, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Wang, Wei4, Andrew Rayskiy, Xida Chen, Kenneth R Christiansen, prerendering-reviews, Stephen Chenney, David Bokan, Christian Biesinger, Hongchan Choi, Yoav Weiss (@Shopify), Dirk Schulze, Peter Beverloo, iclella...@chromium.org, blink-rev...@chromium.org, nator...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, npm+...@chromium.org, dtapuska+...@chromium.org, storage...@chromium.org, blink-...@chromium.org, blink-revi...@chromium.org, dmurph+watch...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, kinuko...@chromium.org, giovax...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, tommyw+w...@chromium.org, kinuko+...@chromium.org, kainin...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, servicewor...@chromium.org, dcheng+c...@chromium.org, speed-metrics...@chromium.org, eric.c...@apple.com, rmcelra...@chromium.org, kouhe...@chromium.org, webap...@microsoft.com, blink-re...@chromium.org, odejesu...@chromium.org, horo+...@chromium.org, mattreyno...@chromium.org, blink-revi...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, sloboda...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, dmurph+watchi...@chromium.org, toyosh...@chromium.org, webauthn...@chromium.org, dmurph+wa...@chromium.org, jkarli...@chromium.org, rayanka...@chromium.org, yigu+...@chromium.org, aleventh...@chromium.org, mgiuca...@chromium.org, kinuko+ser...@chromium.org, gavinp...@chromium.org, fmalit...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, video-networking...@google.com, edgesto...@microsoft.com, derinel+wat...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, enne...@chromium.org, mfoltz+wa...@chromium.org, pkotwic...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, web-schedulin...@chromium.org, dominicc+...@chromium.org, extension...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

Revert "Remove some leftover references to Supplement."

This reverts commit 173bc8cbb96fa41dd0df7e88b549b9ad379daef6.
(See blink-dev for background.)
Bug: 460165754

Change diff


Change information

Files:
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/execution_context/navigator_base.h
  • M third_party/blink/renderer/core/execution_context/window_agent.h
  • M third_party/blink/renderer/core/frame/local_frame.cc
  • M third_party/blink/renderer/core/html/media/html_video_element.h
  • M third_party/blink/renderer/core/route_matching/route_map.cc
  • M third_party/blink/renderer/core/route_matching/route_map.h
  • M third_party/blink/renderer/modules/ad_auction/navigator_auction.h
  • M third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.cc
  • M third_party/blink/renderer/modules/cookie_store/global_cookie_store.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.h
  • M third_party/blink/renderer/modules/presentation/presentation_controller.h
  • M third_party/blink/renderer/modules/webshare/navigator_share.h
Change size: S
Delta: 13 files changed, 24 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib84725fbf172bb5bebda54f0aa3350e33dbe18b5
Gerrit-Change-Number: 7246074
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 11, 2025, 3:40:03 AM (yesterday) Dec 11
to Steinar H Gunderson, Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org
Attention needed from Steinar H Gunderson

Daniel Cheng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib84725fbf172bb5bebda54f0aa3350e33dbe18b5
Gerrit-Change-Number: 7246074
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 08:39:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Dec 11, 2025, 3:52:53 AM (yesterday) Dec 11
to Arnaud Mandy, Permissions Reviews, Rijubrata Bhaumik, Kaan Icer, Nate Chapin, Raphael Kubo da Costa, Simon Hangl, Hiroki Nakagawa, Luna Lu, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Gyuyoung Kim, Daniel Cheng, Wanming Lin, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Wang, Wei4, Andrew Rayskiy, Xida Chen, Kenneth R Christiansen, prerendering-reviews, Stephen Chenney, David Bokan, Christian Biesinger, Hongchan Choi, Yoav Weiss (@Shopify), Dirk Schulze, Peter Beverloo, iclella...@chromium.org, blink-rev...@chromium.org, nator...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, npm+...@chromium.org, dtapuska+...@chromium.org, storage...@chromium.org, blink-...@chromium.org, blink-revi...@chromium.org, dmurph+watch...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, kinuko...@chromium.org, giovax...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, tommyw+w...@chromium.org, kinuko+...@chromium.org, kainin...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, servicewor...@chromium.org, dcheng+c...@chromium.org, speed-metrics...@chromium.org, eric.c...@apple.com, rmcelra...@chromium.org, kouhe...@chromium.org, webap...@microsoft.com, blink-re...@chromium.org, odejesu...@chromium.org, horo+...@chromium.org, mattreyno...@chromium.org, blink-revi...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, sloboda...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, dmurph+watchi...@chromium.org, toyosh...@chromium.org, webauthn...@chromium.org, dmurph+wa...@chromium.org, jkarli...@chromium.org, rayanka...@chromium.org, yigu+...@chromium.org, aleventh...@chromium.org, mgiuca...@chromium.org, kinuko+ser...@chromium.org, gavinp...@chromium.org, fmalit...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, video-networking...@google.com, edgesto...@microsoft.com, derinel+wat...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, enne...@chromium.org, mfoltz+wa...@chromium.org, pkotwic...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, web-schedulin...@chromium.org, dominicc+...@chromium.org, extension...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

Revert "Remove some leftover references to Supplement."

This reverts commit 173bc8cbb96fa41dd0df7e88b549b9ad379daef6.
(See blink-dev for background.)
Bug: 460165754

Change diff


Change information

Files:
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/execution_context/navigator_base.h
  • M third_party/blink/renderer/core/execution_context/window_agent.h
  • M third_party/blink/renderer/core/frame/local_frame.cc
  • M third_party/blink/renderer/core/html/media/html_video_element.h
  • M third_party/blink/renderer/core/route_matching/route_map.cc
  • M third_party/blink/renderer/core/route_matching/route_map.h
  • M third_party/blink/renderer/modules/ad_auction/navigator_auction.h
  • M third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.cc
  • M third_party/blink/renderer/modules/cookie_store/global_cookie_store.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.h
  • M third_party/blink/renderer/modules/presentation/presentation_controller.h
  • M third_party/blink/renderer/modules/webshare/navigator_share.h
Change size: S
Delta: 13 files changed, 24 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I177fec06dd99b047934e148ae22085c1f2d426d9
Gerrit-Change-Number: 7247220
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Dec 11, 2025, 5:10:08 AM (yesterday) Dec 11
to Steinar H Gunderson, Rune Lillesveen, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Daniel Cheng, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org
Attention needed from Steinar H Gunderson

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I177fec06dd99b047934e148ae22085c1f2d426d9
Gerrit-Change-Number: 7247220
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 10:09:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 11, 2025, 6:17:25 AM (yesterday) Dec 11
to Steinar H Gunderson, Rune Lillesveen, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Daniel Cheng, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Remove some leftover references to Supplement."

This reverts commit 173bc8cbb96fa41dd0df7e88b549b9ad379daef6.
(See blink-dev for background.)
Bug: 460165754
Change-Id: I177fec06dd99b047934e148ae22085c1f2d426d9
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557266}
Files:
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/execution_context/navigator_base.h
  • M third_party/blink/renderer/core/execution_context/window_agent.h
  • M third_party/blink/renderer/core/frame/local_frame.cc
  • M third_party/blink/renderer/core/html/media/html_video_element.h
  • M third_party/blink/renderer/core/route_matching/route_map.cc
  • M third_party/blink/renderer/core/route_matching/route_map.h
  • M third_party/blink/renderer/modules/ad_auction/navigator_auction.h
  • M third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.cc
  • M third_party/blink/renderer/modules/cookie_store/global_cookie_store.cc
  • M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client.h
  • M third_party/blink/renderer/modules/presentation/presentation_controller.h
  • M third_party/blink/renderer/modules/webshare/navigator_share.h
Change size: S
Delta: 13 files changed, 24 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Rune Lillesveen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I177fec06dd99b047934e148ae22085c1f2d426d9
Gerrit-Change-Number: 7247220
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
open
diffy
satisfied_requirement

Steinar H Gunderson (Gerrit)

unread,
5:25 AM (15 hours ago) 5:25 AM
to Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Steinar H Gunderson abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0f3f2cad5c86359f5d493a2201bbd50ce87e868c
Gerrit-Change-Number: 7246275
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
satisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
5:26 AM (15 hours ago) 5:26 AM
to Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Steinar H Gunderson abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib84725fbf172bb5bebda54f0aa3350e33dbe18b5
Gerrit-Change-Number: 7246074
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages