Fix outline styles for ::-webkit-calendar-picker-indicator [chromium/src : main]

[Dominic Farolino (Gerrit)]

Attention needed from Joey Arhar

Dominic Farolino added 1 comment

File third_party/blink/renderer/core/html/resources/html.css

Line 1461, Patchset 5 (Latest): outline-color: light-dark(-webkit-focus-ring-color, white);

Dominic Farolino . unresolved

But above we *do* set `outline-style: solid`, so does that mean when the color-scheme is dark, the `, white)` as the second argument to `light-dark` will not be respected? Maybe I'm missing something.

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia749bccc62d6a763bf707f05aa3758418c0be573

Gerrit-Change-Number: 7132458

Gerrit-PatchSet: 5

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Dec 2025 16:25:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Dominic Farolino (Gerrit)]

Attention needed from Joey Arhar

Dominic Farolino added 1 comment

File third_party/blink/renderer/core/html/resources/html.css

Line 1461, Patchset 5 (Latest): outline-color: light-dark(-webkit-focus-ring-color, white);

Dominic Farolino . unresolved

But above we *do* set `outline-style: solid`, so does that mean when the color-scheme is dark, the `, white)` as the second argument to `light-dark` will not be respected? Maybe I'm missing something.

Dominic Farolino

Oh nevermind I'm dumb. You're saying ideally `-webkit-focus-ring-color` would itself be dynamic, but instead we have to hack around that and make it dynamic via the `light-dark()` fn. OK that makes sense. But just so I'm clear: you're saying it ordinarily *is* dynamic UNLESS we set `outline-style: solid`? And when `outline-style: solid` is set, the ring color stops being responsive to `color-scheme: dark` for some reason?

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia749bccc62d6a763bf707f05aa3758418c0be573

Gerrit-Change-Number: 7132458

Gerrit-PatchSet: 5

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Dec 2025 16:27:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Dominic Farolino <d...@chromium.org>

[Joey Arhar (Gerrit)]

Attention needed from Dominic Farolino

Joey Arhar added 1 comment

File third_party/blink/renderer/core/html/resources/html.css

Line 1461, Patchset 5 (Latest): outline-color: light-dark(-webkit-focus-ring-color, white);

Dominic Farolino . unresolved

But above we *do* set `outline-style: solid`, so does that mean when the color-scheme is dark, the `, white)` as the second argument to `light-dark` will not be respected? Maybe I'm missing something.

Dominic Farolino

Oh nevermind I'm dumb. You're saying ideally `-webkit-focus-ring-color` would itself be dynamic, but instead we have to hack around that and make it dynamic via the `light-dark()` fn. OK that makes sense. But just so I'm clear: you're saying it ordinarily *is* dynamic UNLESS we set `outline-style: solid`? And when `outline-style: solid` is set, the ring color stops being responsive to `color-scheme: dark` for some reason?

Joey Arhar

But just so I'm clear: you're saying it ordinarily is dynamic UNLESS we set outline-style: solid? And when outline-style: solid is set, the ring color stops being responsive to color-scheme: dark for some reason?

Yes and yes

Open in Gerrit

Related details

Attention is currently required from:

• Dominic Farolino

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia749bccc62d6a763bf707f05aa3758418c0be573

Gerrit-Change-Number: 7132458

Gerrit-PatchSet: 5

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Dominic Farolino <d...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Dec 2025 21:12:49 +0000