Canvas Text Writing Mode - prototype [chromium/src : main]

0 views

Skip to first unread message

Stephen Chenney (Gerrit)

unread,

Jan 11, 2026, 4:55:54 PM (yesterday) Jan 11

to Jean-Philippe Gravel, Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, servicewor...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, kenjibah...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from Jean-Philippe Gravel

Stephen Chenney added 2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Stephen Chenney . resolved

This is one more hurdle on the road to launching Extended Text Metrics. Hopefully I've learned some things since adding `lang`.

File third_party/blink/web_tests/external/wpt/html/canvas/tools/yaml/text.yaml

Line 1506, Patchset 7 (Latest): if ('{{ ctx_writing_mode }}' == 'vertical' && '{{ text_direction }}' == 'rtl')

Stephen Chenney . unresolved

Due to issues with DOM selection rects for RTL upright text, do not try to test it here. I'll try to create some ref tests.

Open in Gerrit

Related details

Attention is currently required from:

Jean-Philippe Gravel

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages