Migrate usages of base::to_underlying in //third_party/blink [chromium/src : main]
0 views
Skip to first unread message
Chris Harrelson (Gerrit)
Dec 19, 2025, 11:58:54 AM (4 days ago) Dec 19
to Victor Vianna, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, Yoav Weiss (@Shopify), blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, kainin...@chromium.org, loading...@chromium.org
Attention needed from Victor Vianna
Chris Harrelson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Victor Vianna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Dec 22, 2025, 11:45:56 AM (18 hours ago) Dec 22
to Chris Harrelson, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, Yoav Weiss (@Shopify), blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, kainin...@chromium.org, loading...@chromium.org
Victor Vianna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 22, 2025, 2:03:11 PM (16 hours ago) Dec 22
to Victor Vianna, Chris Harrelson, chromium...@chromium.org, Nate Chapin, prerendering-reviews, Yoav Weiss (@Shopify), blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, kainin...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate usages of base::to_underlying in //third_party/blink
```
files_using_header="$(git grep -l base::to_underlying | tr '\n' ' ')"
sed -i 's/base::to_underlying/std::to_underlying/g' \
${files_using_header}
tools/add_header.py --header '<utility>' ${files_using_header}
files_including_header="$(git grep -l base/types/cxx23_to_underlying.h | tr '\n' ' ')"
tools/add_header.py --header '"base/types/cxx23_to_underlying.h"' \
--remove ${files_including_header}
git cl format
```
Then some manual fixes.
Bug: 470039537
Change-Id: I89b9f5872ae0f44f37624d26ac9ada9d8a4a46ad
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Commit-Queue: Victor Vianna <victor...@google.com>
Cr-Commit-Position: refs/heads/main@{#1561886}
Files:
- M third_party/blink/renderer/DEPS
- M third_party/blink/renderer/core/dom/focusgroup_flags.h
- M third_party/blink/renderer/core/html/forms/html_button_element.cc
- M third_party/blink/renderer/core/html/forms/html_button_element.h
- M third_party/blink/renderer/core/html/forms/input_type.h
- M third_party/blink/renderer/core/loader/document_loader_auto_speculation_rules_test.cc
- M third_party/blink/renderer/core/loader/preload_helper.cc
- M third_party/blink/renderer/core/speculation_rules/auto_speculation_rules_config_test.cc
- M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_manager.cc
- M third_party/blink/renderer/modules/ml/ml_context.cc
- M third_party/blink/renderer/modules/webgpu/gpu.cc
- M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: M
Delta: 12 files changed, 65 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Harrelson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages