Set interactivity:inert!important on customizable select button [chromium/src : main]
0 views
Skip to first unread message
Joey Arhar (Gerrit)
Mar 31, 2026, 8:19:10 PM (2 days ago) Mar 31
to David Baron, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from David Baron
Joey Arhar added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 1 (Latest):
provide a way to un-inert it. Authors have found that accidentallyJoey Arhar . unresolved
fyi, "authors" here refers to bramus, who set all:unset on a customizable select button and was confused by the form submission behavior and asked me about it.
Related details
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Apr 1, 2026, 10:50:01 AM (20 hours ago) Apr 1
to David Baron, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Joey Arhar
David Baron voted and added 2 comments![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Baron . resolved
I have some mixed feelings about using `!important` in UA sheets, but I guess this LGTM.
Commit Message
Line 10, Patchset 1 (Latest):
provide a way to un-inert it. Authors have found that accidentallyJoey Arhar . resolved
fyi, "authors" here refers to bramus, who set all:unset on a customizable select button and was confused by the form submission behavior and asked me about it.
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Apr 1, 2026, 12:51:18 PM (18 hours ago) Apr 1
to David Baron, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Joey Arhar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
David Baron . resolved
I have some mixed feelings about using `!important` in UA sheets, but I guess this LGTM.
Joey Arhar
Alternatively we could go back to hard coding the intertness in c++ which I removed from HTMLButtonElement some time ago, but the functionality is the same I think. The inert attribute also sets interactivity:inert!important I think, so this is a better signal to anyone looking at styles that the button is inert.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 1, 2026, 12:56:07 PM (17 hours ago) Apr 1
to David Baron, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Set interactivity:inert!important on customizable select button
The HTML spec says that this button must always be inert and doesn't
provide a way to un-inert it. Authors have found that accidentally
removing inertness via CSS all:unset is unexpected.
Fixed: 498095295
Change-Id: I83212a85402201ecfcd8075958aaee9ff767a84f
Commit-Queue: Joey Arhar <jar...@chromium.org>
Reviewed-by: David Baron <dba...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608608}
Files:
- M third_party/blink/renderer/core/html/resources/html.css
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select/select-button-behaviors.html
Change size: S
Delta: 2 files changed, 8 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joey Arhar, +1 by David Baron
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 1, 2026, 2:08:32 PM (16 hours ago) Apr 1
to Chromium LUCI CQ, David Baron, AyeAye, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58913
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages