[ImmersivePlayback] Plumb video spatial format to PiP service and confirmation flow [chromium/src : main]

0 views
Skip to first unread message

Oleh Desiatyrikov (xWF) (Gerrit)

unread,
Jun 22, 2026, 10:35:12 AM (5 days ago) Jun 22
to Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Dale Curtis, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Dale Curtis and Oleh Desiatyrikov (xWF)

Message from Oleh Desiatyrikov (xWF)

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
Gerrit-Change-Number: 7886009
Gerrit-PatchSet: 14
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-CC: Frank Liberato <libe...@google.com>
Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jun 2026 14:34:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Oleh Desiatyrikov (xWF) (Gerrit)

unread,
Jun 22, 2026, 10:35:49 AM (5 days ago) Jun 22
to Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Dale Curtis, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Dale Curtis

Oleh Desiatyrikov (xWF) added 1 comment

File third_party/blink/renderer/platform/media/media_player_client.h
Line 191, Patchset 10: // Notify the client that the video configuration has changed.
Dale Curtis . resolved

Instead of adding this, lets just add a getter for the spatial format on WebMediaPlayer since that's a more common pattern.

Oleh Desiatyrikov (xWF)

Yes, it would be a much cleaner approach! Thank you for the suggestion.

Does the `RequestVideoSpatialFormat()` implementation look alright to you?

Dale Curtis

Yes, that looked fine. I didn't see any other method we could attach the information to, but if there is an existing one that runs when immersive mode starts, I'd consider attaching there.

Oleh Desiatyrikov (xWF)

I could pass it over directly to the `PictureInPictureController::EnterPictureInPictureImmersive` [[1]](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/media/html_video_element.cc;l=1047;drc=256d8d19b35cf936c3e86339da5409fb88788707) -> `PictureInPictureService::StartSession` [[2]](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom;l=87;drc=5496fbe366e6796c5b549c65a2cb267b5c933e35)

But we just refactored that part with @libe...@google.com here [[3]](https://g-issues.chromium.org/issues/514069440) + [[4]](crrev.com/c/7899097), so I'm sure if I should put it back there.

Oleh Desiatyrikov (xWF)

so I'm **NOT** sure if I should put it back there

Dale Curtis

StartSession() does seem like a reasonable place. What's your concern with adding it there?

Oleh Desiatyrikov (xWF)

Not much of a concern, it's just that we cleaned up those options recently and I will put them back again.

But yes, it is a significantly better place to have these.

If so, I will probably merge this CL together with a followup - crrev.com/c/7885666.

Dale Curtis

Ack

Oleh Desiatyrikov (xWF)

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
    Gerrit-Change-Number: 7886009
    Gerrit-PatchSet: 14
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-CC: Frank Liberato <libe...@google.com>
    Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 14:35:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Jun 22, 2026, 11:03:37 AM (5 days ago) Jun 22
    to Oleh Desiatyrikov (xWF), Chromium IPC Reviews, Dominic Farolino, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Bo Liu, Dmitry Gozman, Dominic Farolino and Sky Malice

    Message from gwsq

    From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
    IPC: d...@chromium.org

    📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

    IPC reviewer(s): d...@chromium.org


    Reviewer source(s):
    d...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    • Dmitry Gozman
    • Dominic Farolino
    • Sky Malice
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
    Gerrit-Change-Number: 7886009
    Gerrit-PatchSet: 14
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Frank Liberato <libe...@google.com>
    Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: gwsq
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Attention: Bo Liu <bo...@chromium.org>
    Gerrit-Attention: Sky Malice <sk...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 15:01:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dominic Farolino (Gerrit)

    unread,
    Jun 22, 2026, 11:12:47 AM (5 days ago) Jun 22
    to Oleh Desiatyrikov (xWF), Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Bo Liu, Dmitry Gozman, Oleh Desiatyrikov (xWF) and Sky Malice

    Dominic Farolino voted and added 1 comment

    Votes added by Dominic Farolino

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 14 (Latest):
    Dominic Farolino . resolved

    mojom lgtm; please don't use my LGTM for other files in Blink as I haven't reviewed them

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    • Dmitry Gozman
    • Oleh Desiatyrikov (xWF)
    • Sky Malice
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Attention: Bo Liu <bo...@chromium.org>
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 15:12:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Bo Liu (Gerrit)

      unread,
      Jun 22, 2026, 11:30:11 AM (5 days ago) Jun 22
      to Oleh Desiatyrikov (xWF), Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Dmitry Gozman, Oleh Desiatyrikov (xWF) and Sky Malice

      Bo Liu added 1 comment

      Patchset-level comments
      Bo Liu . resolved

      pick an owner from content/browser/picture_in_picture/OWNERS for code there

      Open in Gerrit

      Related details

      Attention is currently required from:
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 15:29:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Oleh Desiatyrikov (xWF) (Gerrit)

      unread,
      Jun 22, 2026, 12:16:05 PM (5 days ago) Jun 22
      to Fr, Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Dmitry Gozman, Fr and Sky Malice

      Oleh Desiatyrikov (xWF) added 2 comments

      Patchset-level comments
      Oleh Desiatyrikov (xWF) . resolved

      Hello everyone!
      I would greatly appreciate if you can help me by reviewing the following:

      @beaufort...@gmail.com

      • `content/browser/picture_in_picture/*`
      • `third_party/blink/renderer/modules/document_picture_in_picture/*`

      @dgo...@chromium.org

      • `third_party/blink/public/platform/*`
      • `third_party/blink/renderer/platform/*`

      @sk...@chromium.org

      • `chrome/android/java/src/org/chromium/chrome/browser/*`
      • `chrome/browser/android/*`

      Please let me know if I need to peek other reviewers!
      Thank you!

      Bo Liu . resolved

      pick an owner from content/browser/picture_in_picture/OWNERS for code there

      Oleh Desiatyrikov (xWF)

      Would you mind reviewing the `components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java`?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitry Gozman
      • Fr
      • Sky Malice
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
      Gerrit-Change-Number: 7886009
      Gerrit-PatchSet: 14
      Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
      Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
      Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Frank Liberato <libe...@google.com>
      Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
      Gerrit-CC: Hongchan Choi <hong...@chromium.org>
      Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: gwsq
      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
      Gerrit-Attention: Fr <beaufort...@gmail.com>
      Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 16:15:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Bo Liu <bo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Bo Liu (Gerrit)

      unread,
      Jun 22, 2026, 3:39:08 PM (5 days ago) Jun 22
      to Oleh Desiatyrikov (xWF), Fr, Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Dmitry Gozman, Fr, Oleh Desiatyrikov (xWF) and Sky Malice

      Bo Liu added 1 comment

      Patchset-level comments
      Bo Liu . resolved

      pick an owner from content/browser/picture_in_picture/OWNERS for code there

      Oleh Desiatyrikov (xWF)

      Would you mind reviewing the `components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java`?

      Bo Liu

      yes, after content owners approves

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitry Gozman
      • Fr
      • Oleh Desiatyrikov (xWF)
      • Sky Malice
      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Attention: Sky Malice <sk...@chromium.org>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 19:38:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Comment-In-Reply-To: Bo Liu <bo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Fr (Gerrit)

      unread,
      Jun 23, 2026, 2:11:56 AM (5 days ago) Jun 23
      to Oleh Desiatyrikov (xWF), Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Dmitry Gozman, Oleh Desiatyrikov (xWF) and Sky Malice

      Fr voted and added 4 comments

      Votes added by Fr

      Code-Review+1

      4 comments

      Patchset-level comments
      Fr . resolved

      LGTM modulo nits

      File content/browser/picture_in_picture/picture_in_picture_service_impl.h
      Line 12, Patchset 14 (Latest):#include "media/base/video_spatial_format.h"
      Fr . unresolved

      Nit: Can you move this to `content/browser/picture_in_picture/picture_in_picture_service_impl.cc` and forward declaration of media::VideoSpatialFormat there?

      File content/browser/picture_in_picture/picture_in_picture_service_impl.cc
      Line 9, Patchset 14 (Latest):#include "base/functional/bind.h"
      Fr . unresolved

      Can you explain those header changes?

      File content/browser/picture_in_picture/picture_in_picture_service_impl_unittest.cc
      Line 440, Patchset 14 (Latest): SetVideoSpatialFormat(media::VideoSpatialFormat{
      Fr . unresolved

      Shall we have more tests for other options as well?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitry Gozman
      • Oleh Desiatyrikov (xWF)
      • Sky Malice
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
          Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
          Gerrit-Attention: Sky Malice <sk...@chromium.org>
          Gerrit-Comment-Date: Tue, 23 Jun 2026 06:11:30 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Oleh Desiatyrikov (xWF) (Gerrit)

          unread,
          Jun 23, 2026, 11:04:38 AM (4 days ago) Jun 23
          to Fr, Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
          Attention needed from Dmitry Gozman, Dominic Farolino, Fr and Sky Malice

          Oleh Desiatyrikov (xWF) added 3 comments

          File content/browser/picture_in_picture/picture_in_picture_service_impl.h
          Line 12, Patchset 14:#include "media/base/video_spatial_format.h"
          Fr . resolved

          Nit: Can you move this to `content/browser/picture_in_picture/picture_in_picture_service_impl.cc` and forward declaration of media::VideoSpatialFormat there?

          Oleh Desiatyrikov (xWF)

          Done. Had to also move the `PendingSession` declaration to the .cc file.

          File content/browser/picture_in_picture/picture_in_picture_service_impl.cc
          Line 9, Patchset 14:#include "base/functional/bind.h"
          Fr . resolved

          Can you explain those header changes?

          Oleh Desiatyrikov (xWF)

          Refactored imports to remove unused references from previous iterations. Thanks for the catch!

          File content/browser/picture_in_picture/picture_in_picture_service_impl_unittest.cc
          Line 440, Patchset 14: SetVideoSpatialFormat(media::VideoSpatialFormat{
          Fr . resolved

          Shall we have more tests for other options as well?

          Oleh Desiatyrikov (xWF)

          Added coverage for all currently supported combinations.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Dmitry Gozman
          • Dominic Farolino
          • Fr
          • Sky Malice
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
            Gerrit-Change-Number: 7886009
            Gerrit-PatchSet: 16
            Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
            Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
            Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
            Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
            Gerrit-Reviewer: Fr <beaufort...@gmail.com>
            Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
            Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
            Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
            Gerrit-CC: Frank Liberato <libe...@google.com>
            Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
            Gerrit-CC: Hongchan Choi <hong...@chromium.org>
            Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
            Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
            Gerrit-CC: gwsq
            Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
            Gerrit-Attention: Fr <beaufort...@gmail.com>
            Gerrit-Attention: Dominic Farolino <d...@chromium.org>
            Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
            Gerrit-Attention: Sky Malice <sk...@chromium.org>
            Gerrit-Comment-Date: Tue, 23 Jun 2026 15:04:03 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Fr <beaufort...@gmail.com>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Gurmeet Kalra (Gerrit)

            unread,
            Jun 23, 2026, 11:55:09 AM (4 days ago) Jun 23
            to Oleh Desiatyrikov (xWF), Fr, Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
            Attention needed from Dmitry Gozman, Dominic Farolino, Fr, Oleh Desiatyrikov (xWF) and Sky Malice

            Gurmeet Kalra added 1 comment

            File third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom
            Line 97, Patchset 16 (Latest): media.mojom.VideoSpatialFormat spatial_format)
            Gurmeet Kalra . unresolved

            nit: Consider adding the new `spatial_format` parameter explanation in method description comment above, explaining its role in the context of starting a PiP session.

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Dmitry Gozman
            • Dominic Farolino
            • Fr
            • Oleh Desiatyrikov (xWF)
            • Sky Malice
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement is not satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedNo-Unresolved-Comments
              Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Attention: Sky Malice <sk...@chromium.org>
              Gerrit-Comment-Date: Tue, 23 Jun 2026 15:54:51 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Oleh Desiatyrikov (xWF) (Gerrit)

              unread,
              Jun 23, 2026, 12:43:40 PM (4 days ago) Jun 23
              to Fr, Dominic Farolino, Chromium IPC Reviews, Sky Malice, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
              Attention needed from Dmitry Gozman, Dominic Farolino, Fr, Gurmeet Kalra and Sky Malice

              Oleh Desiatyrikov (xWF) added 1 comment

              File third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom
              Line 97, Patchset 16: media.mojom.VideoSpatialFormat spatial_format)
              Gurmeet Kalra . resolved

              nit: Consider adding the new `spatial_format` parameter explanation in method description comment above, explaining its role in the context of starting a PiP session.

              Oleh Desiatyrikov (xWF)

              Done

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Dmitry Gozman
              • Dominic Farolino
              • Fr
              • Gurmeet Kalra
              • Sky Malice
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement is not satisfiedCode-Owners
                • requirement is not satisfiedCode-Review
                • requirement is not satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
                Gerrit-Change-Number: 7886009
                Gerrit-PatchSet: 17
                Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
                Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
                Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
                Gerrit-Reviewer: Fr <beaufort...@gmail.com>
                Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
                Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
                Gerrit-CC: Frank Liberato <libe...@google.com>
                Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
                Gerrit-CC: Hongchan Choi <hong...@chromium.org>
                Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
                Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
                Gerrit-CC: gwsq
                Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
                Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
                Gerrit-Attention: Fr <beaufort...@gmail.com>
                Gerrit-Attention: Dominic Farolino <d...@chromium.org>
                Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
                Gerrit-Attention: Sky Malice <sk...@chromium.org>
                Gerrit-Comment-Date: Tue, 23 Jun 2026 16:43:24 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: No
                Comment-In-Reply-To: Gurmeet Kalra <gurm...@google.com>
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Sky Malice (Gerrit)

                unread,
                Jun 23, 2026, 1:06:36 PM (4 days ago) Jun 23
                to Oleh Desiatyrikov (xWF), Fr, Dominic Farolino, Chromium IPC Reviews, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                Attention needed from Dmitry Gozman, Dominic Farolino, Fr, Gurmeet Kalra and Oleh Desiatyrikov (xWF)

                Sky Malice voted and added 1 comment

                Votes added by Sky Malice

                Code-Review+1

                1 comment

                Patchset-level comments
                File-level comment, Patchset 17 (Latest):
                Sky Malice . resolved

                lgtm for

                chrome/android/BUILD.gn
                chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java
                chrome/android/java/src/org/chromium/chrome/browser/media/immersive_playback/ImmersivePlaybackSnackbarController.java
                chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroidImpl.java
                chrome/android/junit/src/org/chromium/chrome/browser/media/immersive_playback/ImmersivePlaybackSnackbarControllerTest.java
                chrome/browser/android/tab_web_contents_delegate_android.cc
                chrome/browser/android/tab_web_contents_delegate_android.h

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Dmitry Gozman
                • Dominic Farolino
                • Fr
                • Gurmeet Kalra
                • Oleh Desiatyrikov (xWF)
                Submit Requirements:
                  • requirement satisfiedCode-Coverage
                  • requirement is not satisfiedCode-Owners
                  • requirement is not satisfiedCode-Review
                  • requirement satisfiedReview-Enforcement
                  Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                  Gerrit-Comment-Date: Tue, 23 Jun 2026 17:06:07 +0000
                  Gerrit-HasComments: Yes
                  Gerrit-Has-Labels: Yes
                  satisfied_requirement
                  unsatisfied_requirement
                  open
                  diffy

                  Fr (Gerrit)

                  unread,
                  Jun 23, 2026, 2:09:28 PM (4 days ago) Jun 23
                  to Oleh Desiatyrikov (xWF), Sky Malice, Dominic Farolino, Chromium IPC Reviews, Bo Liu, Dmitry Gozman, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                  Attention needed from Dmitry Gozman, Dominic Farolino, Gurmeet Kalra and Oleh Desiatyrikov (xWF)

                  Fr voted Code-Review+1

                  Code-Review+1
                  Open in Gerrit

                  Related details

                  Attention is currently required from:
                  • Dmitry Gozman
                  • Dominic Farolino
                  • Gurmeet Kalra
                  • Oleh Desiatyrikov (xWF)
                    Submit Requirements:
                      • requirement satisfiedCode-Coverage
                      • requirement is not satisfiedCode-Owners
                      • requirement satisfiedCode-Review
                      • requirement satisfiedReview-Enforcement
                      Gerrit-Attention: Dominic Farolino <d...@chromium.org>
                      Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
                      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Comment-Date: Tue, 23 Jun 2026 18:09:09 +0000
                      Gerrit-HasComments: No
                      Gerrit-Has-Labels: Yes
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Oleh Desiatyrikov (xWF) (Gerrit)

                      unread,
                      Jun 24, 2026, 11:06:05 AM (3 days ago) Jun 24
                      to Daniel Cheng, Camille Lamy, Dmitry Gozman, Fr, Sky Malice, Dominic Farolino, Chromium IPC Reviews, Bo Liu, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                      Attention needed from Camille Lamy, Daniel Cheng, Dmitry Gozman, Dominic Farolino and Gurmeet Kalra

                      Oleh Desiatyrikov (xWF) added 1 comment

                      Patchset-level comments
                      Oleh Desiatyrikov (xWF) . resolved

                      Hello, @dch...@chromium.org, @cl...@chromium.org! Would you mind helping me with the owners' approvals for the following files?

                      @dch...@chromium.org

                      • third_party/blink/public/platform/ DEPS
                      • third_party/blink/public/platform/ web_media_player.h
                      • third_party/blink/renderer/platform/media/ web_media_player_impl.h
                      • third_party/blink/renderer/platform/media/ web_media_player_impl.cc
                      • third_party/blink/renderer/core/html/media/ video_wake_lock_test.cc

                      @cl...@chromium.org

                      • content/public/browser/ web_contents_delegate.h
                      • content/public/browser/ web_contents_delegate.cc
                      Open in Gerrit

                      Related details

                      Attention is currently required from:
                      • Camille Lamy
                      • Daniel Cheng
                      • Dmitry Gozman
                      • Dominic Farolino
                      • Gurmeet Kalra
                      Submit Requirements:
                      • requirement satisfiedCode-Coverage
                      • requirement is not satisfiedCode-Owners
                      • requirement satisfiedCode-Review
                      • requirement satisfiedReview-Enforcement
                      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                      Gerrit-MessageType: comment
                      Gerrit-Project: chromium/src
                      Gerrit-Branch: main
                      Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
                      Gerrit-Change-Number: 7886009
                      Gerrit-PatchSet: 17
                      Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
                      Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
                      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
                      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
                      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
                      Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
                      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
                      Gerrit-CC: Dmitry Gozman <dgo...@chromium.org>
                      Gerrit-CC: Frank Liberato <libe...@google.com>
                      Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
                      Gerrit-CC: Hongchan Choi <hong...@chromium.org>
                      Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
                      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
                      Gerrit-CC: gwsq
                      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
                      Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
                      Gerrit-Attention: Dominic Farolino <d...@chromium.org>
                      Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
                      Gerrit-Attention: Camille Lamy <cl...@chromium.org>
                      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
                      Gerrit-Comment-Date: Wed, 24 Jun 2026 15:05:49 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: No
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Dominic Farolino (Gerrit)

                      unread,
                      Jun 24, 2026, 11:10:22 AM (3 days ago) Jun 24
                      to Oleh Desiatyrikov (xWF), Daniel Cheng, Camille Lamy, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Bo Liu, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                      Attention needed from Camille Lamy, Daniel Cheng, Dmitry Gozman, Gurmeet Kalra and Oleh Desiatyrikov (xWF)

                      Dominic Farolino added 1 comment

                      Patchset-level comments
                      Dominic Farolino . resolved

                      Is my review needed?

                      Open in Gerrit

                      Related details

                      Attention is currently required from:
                      • Camille Lamy
                      • Daniel Cheng
                      • Dmitry Gozman
                      • Gurmeet Kalra
                      • Oleh Desiatyrikov (xWF)
                      Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
                      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Attention: Camille Lamy <cl...@chromium.org>
                      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
                      Gerrit-Comment-Date: Wed, 24 Jun 2026 15:10:06 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: No
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Oleh Desiatyrikov (xWF) (Gerrit)

                      unread,
                      Jun 24, 2026, 11:38:30 AM (3 days ago) Jun 24
                      to Dominic Farolino, Daniel Cheng, Camille Lamy, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Bo Liu, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                      Attention needed from Camille Lamy, Daniel Cheng, Dmitry Gozman and Gurmeet Kalra

                      Oleh Desiatyrikov (xWF) added 1 comment

                      Patchset-level comments
                      Dominic Farolino . resolved

                      Is my review needed?

                      Oleh Desiatyrikov (xWF)

                      Thank you for checking in! I've moved you to CC. The vote from @cl...@chromium.org should cover your previous +1 on mojom.

                      Open in Gerrit

                      Related details

                      Attention is currently required from:
                      • Camille Lamy
                      • Daniel Cheng
                      • Dmitry Gozman
                      • Gurmeet Kalra
                      Submit Requirements:
                      • requirement satisfiedCode-Coverage
                      • requirement is not satisfiedCode-Owners
                      • requirement satisfiedCode-Review
                      • requirement satisfiedReview-Enforcement
                      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                      Gerrit-MessageType: comment
                      Gerrit-Project: chromium/src
                      Gerrit-Branch: main
                      Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
                      Gerrit-Change-Number: 7886009
                      Gerrit-PatchSet: 17
                      Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
                      Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
                      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
                      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
                      Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
                      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
                      Gerrit-CC: Dmitry Gozman <dgo...@chromium.org>
                      Gerrit-CC: Dominic Farolino <d...@chromium.org>
                      Gerrit-CC: Frank Liberato <libe...@google.com>
                      Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
                      Gerrit-CC: Hongchan Choi <hong...@chromium.org>
                      Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
                      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
                      Gerrit-CC: gwsq
                      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
                      Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
                      Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
                      Gerrit-Attention: Camille Lamy <cl...@chromium.org>
                      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
                      Gerrit-Comment-Date: Wed, 24 Jun 2026 15:38:14 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: No
                      Comment-In-Reply-To: Dominic Farolino <d...@chromium.org>
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Daniel Cheng (Gerrit)

                      unread,
                      Jun 24, 2026, 8:02:35 PM (3 days ago) Jun 24
                      to Oleh Desiatyrikov (xWF), Daniel Cheng, Dominic Farolino, Camille Lamy, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Bo Liu, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                      Attention needed from Bo Liu, Camille Lamy and Oleh Desiatyrikov (xWF)

                      Daniel Cheng voted and added 1 comment

                      Votes added by Daniel Cheng

                      Code-Review+1

                      1 comment

                      Patchset-level comments
                      Daniel Cheng . resolved

                      LGTM

                      Open in Gerrit

                      Related details

                      Attention is currently required from:
                      • Bo Liu
                      • Camille Lamy
                      • Oleh Desiatyrikov (xWF)
                      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                      Gerrit-Attention: Camille Lamy <cl...@chromium.org>
                      Gerrit-Attention: Bo Liu <bo...@chromium.org>
                      Gerrit-Comment-Date: Thu, 25 Jun 2026 00:02:14 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: Yes
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Camille Lamy (Gerrit)

                      unread,
                      Jun 25, 2026, 5:41:16 AM (3 days ago) Jun 25
                      to Oleh Desiatyrikov (xWF), Daniel Cheng, Dominic Farolino, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Bo Liu, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                      Attention needed from Bo Liu and Oleh Desiatyrikov (xWF)

                      Camille Lamy voted and added 1 comment

                      Votes added by Camille Lamy

                      Code-Review+1

                      1 comment

                      Patchset-level comments
                      Camille Lamy . resolved

                      content lgtm

                      Open in Gerrit

                      Related details

                      Attention is currently required from:
                      • Bo Liu
                      • Oleh Desiatyrikov (xWF)
                      Gerrit-Attention: Bo Liu <bo...@chromium.org>
                      Gerrit-Comment-Date: Thu, 25 Jun 2026 09:40:53 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: Yes
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Bo Liu (Gerrit)

                      unread,
                      Jun 25, 2026, 7:49:25 AM (3 days ago) Jun 25
                      to Oleh Desiatyrikov (xWF), Bo Liu, Camille Lamy, Daniel Cheng, Dominic Farolino, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org
                      Attention needed from Oleh Desiatyrikov (xWF)

                      Bo Liu voted and added 1 comment

                      Votes added by Bo Liu

                      Code-Review+1

                      1 comment

                      File components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java
                      Line 146, Patchset 17 (Latest): public void requestImmersivePlaybackConfirmation(
                      Bo Liu . unresolved

                      existing code but either this should just be in TabWebContentsDelegateAndrodImpl, or the native code calling this should be in embedder_support

                      jni should not cross layer boundaries

                      can you fix in that in a separate CL.

                      Open in Gerrit

                      Related details

                      Attention is currently required from:
                      • Oleh Desiatyrikov (xWF)
                      Submit Requirements:
                      • requirement satisfiedCode-Coverage
                      • requirement satisfiedCode-Owners
                      • requirement satisfiedCode-Review
                      • requirement is not satisfiedNo-Unresolved-Comments
                      • requirement satisfiedReview-Enforcement
                      Gerrit-Comment-Date: Thu, 25 Jun 2026 11:49:10 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: Yes
                      satisfied_requirement
                      unsatisfied_requirement
                      open
                      diffy

                      Oleh Desiatyrikov (xWF) (Gerrit)

                      unread,
                      Jun 25, 2026, 10:47:28 AM (2 days ago) Jun 25
                      to Bo Liu, Camille Lamy, Daniel Cheng, Dominic Farolino, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

                      Oleh Desiatyrikov (xWF) added 1 comment

                      File components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java
                      Line 146, Patchset 17 (Latest): public void requestImmersivePlaybackConfirmation(
                      Bo Liu . resolved

                      existing code but either this should just be in TabWebContentsDelegateAndrodImpl, or the native code calling this should be in embedder_support

                      jni should not cross layer boundaries

                      can you fix in that in a separate CL.

                      Oleh Desiatyrikov (xWF)

                      Acknowledged.

                      Created a bug to track this change: crbug.com/527879786.

                      Open in Gerrit

                      Related details

                      Attention set is empty
                      Submit Requirements:
                        • requirement satisfiedCode-Coverage
                        • requirement satisfiedCode-Owners
                        • requirement satisfiedCode-Review
                        • requirement satisfiedReview-Enforcement
                        Gerrit-Comment-Date: Thu, 25 Jun 2026 14:47:10 +0000
                        Gerrit-HasComments: Yes
                        satisfied_requirement
                        open
                        diffy

                        Oleh Desiatyrikov (xWF) (Gerrit)

                        unread,
                        Jun 25, 2026, 10:47:42 AM (2 days ago) Jun 25
                        to Bo Liu, Camille Lamy, Daniel Cheng, Dominic Farolino, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Chromium LUCI CQ, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

                        Oleh Desiatyrikov (xWF) voted Commit-Queue+2

                        Commit-Queue+2
                        Gerrit-Comment-Date: Thu, 25 Jun 2026 14:47:25 +0000
                        Gerrit-HasComments: No
                        Gerrit-Has-Labels: Yes
                        satisfied_requirement
                        open
                        diffy

                        Chromium LUCI CQ (Gerrit)

                        unread,
                        Jun 25, 2026, 10:53:08 AM (2 days ago) Jun 25
                        to Oleh Desiatyrikov (xWF), Bo Liu, Camille Lamy, Daniel Cheng, Dominic Farolino, Dmitry Gozman, Fr, Sky Malice, Chromium IPC Reviews, Raphael Kubo da Costa, Frank Liberato, Hongchan Choi, android-bu...@system.gserviceaccount.com, Gurmeet Kalra, chromium...@chromium.org, srirama chandra sekhar, mattreyno...@chromium.org, blink-re...@chromium.org, tommyw+w...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

                        Chromium LUCI CQ submitted the change

                        Change information

                        Commit message:
                        [ImmersivePlayback] Plumb video spatial format to PiP service and confirmation flow

                        Propagates video spatial format (VideoStereoMode and VideoProjectionType
                        enums) from Blink's WebMediaPlayer through
                        PictureInPictureService::StartSession.

                        Plumbs ImmersiveOptions through VideoPictureInPictureWindowController,
                        WebContentsDelegate, and ActivityTabWebContentsDelegateAndroid to
                        trigger the immersive playback confirmation snackbar on Android.
                        Bug: 525397255, 525393212
                        Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
                        Reviewed-by: Sky Malice <sk...@chromium.org>
                        Reviewed-by: Fr <beaufort...@gmail.com>
                        Reviewed-by: Camille Lamy <cl...@chromium.org>
                        Commit-Queue: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                        Reviewed-by: Daniel Cheng <dch...@chromium.org>
                        Reviewed-by: Bo Liu <bo...@chromium.org>
                        Cr-Commit-Position: refs/heads/main@{#1652420}
                        Files:
                        • M chrome/android/BUILD.gn
                        • M chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java
                        • M chrome/android/java/src/org/chromium/chrome/browser/media/immersive_playback/ImmersivePlaybackSnackbarController.java
                        • M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroidImpl.java
                        • M chrome/android/junit/src/org/chromium/chrome/browser/media/immersive_playback/ImmersivePlaybackSnackbarControllerTest.java
                        • M chrome/browser/android/tab_web_contents_delegate_android.cc
                        • M chrome/browser/android/tab_web_contents_delegate_android.h
                        • M components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java
                        • M content/browser/picture_in_picture/picture_in_picture_service_impl.cc
                        • M content/browser/picture_in_picture/picture_in_picture_service_impl.h
                        • M content/browser/picture_in_picture/picture_in_picture_service_impl_unittest.cc
                        • M content/browser/picture_in_picture/video_picture_in_picture_window_controller_impl.cc
                        • M content/browser/picture_in_picture/video_picture_in_picture_window_controller_impl.h
                        • M content/public/browser/web_contents_delegate.cc
                        • M content/public/browser/web_contents_delegate.h
                        • M third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom
                        • M third_party/blink/public/platform/DEPS
                        • M third_party/blink/public/platform/web_media_player.h
                        • M third_party/blink/renderer/core/html/media/video_wake_lock_test.cc
                        • M third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.cc
                        • M third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_test.cc
                        • M third_party/blink/renderer/platform/media/web_media_player_impl.cc
                        • M third_party/blink/renderer/platform/media/web_media_player_impl.h
                        Change size: L
                        Delta: 23 files changed, 423 insertions(+), 101 deletions(-)
                        Branch: refs/heads/main
                        Submit Requirements:
                        • requirement satisfiedCode-Review: +1 by Daniel Cheng, +1 by Bo Liu, +1 by Camille Lamy, +1 by Sky Malice, +1 by Fr
                        Open in Gerrit
                        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                        Gerrit-MessageType: merged
                        Gerrit-Project: chromium/src
                        Gerrit-Branch: main
                        Gerrit-Change-Id: If2585b3716d2a99aca9e9d92d34b1f13946a2305
                        Gerrit-Change-Number: 7886009
                        Gerrit-PatchSet: 18
                        Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                        Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
                        Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
                        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
                        Gerrit-Reviewer: Fr <beaufort...@gmail.com>
                        Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
                        Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
                        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
                        open
                        diffy
                        satisfied_requirement
                        Reply all
                        Reply to author
                        Forward
                        0 new messages