WTF: Renaem FlushBehavior::k*EOF to k*Eof [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Apr 21, 2026, 3:45:32 AM (yesterday) Apr 21
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I44f8901768a089acf5fd2982ed7db4788847c409
Gerrit-Change-Number: 7776030
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 07:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Apr 21, 2026, 4:24:00 AM (yesterday) Apr 21
to Kent Tamura, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44f8901768a089acf5fd2982ed7db4788847c409
    Gerrit-Change-Number: 7776030
    Gerrit-PatchSet: 5
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 08:23:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 21, 2026, 4:26:50 AM (yesterday) Apr 21
    to Kent Tamura, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Renaem FlushBehavior::k*EOF to k*Eof

    `EOF' is changed to `Eof' to follow a preference in Google C++ style
    guide.

    This CL has no behavior changes.
    Bug: 492927412
    Change-Id: I44f8901768a089acf5fd2982ed7db4788847c409
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1618031}
    Files:
    • M third_party/blink/renderer/core/dom/document.cc
    • M third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
    • M third_party/blink/renderer/modules/encoding/text_decoder.cc
    • M third_party/blink/renderer/modules/encoding/text_decoder_stream.cc
    • M third_party/blink/renderer/modules/eventsource/event_source_parser.cc
    • M third_party/blink/renderer/platform/text_codec_fuzzer.cc
    • M third_party/blink/renderer/platform/wtf/text/text_codec.h
    • M third_party/blink/renderer/platform/wtf/text/text_codec_replacement_test.cc
    • M third_party/blink/renderer/platform/wtf/text/text_codec_utf16.cc
    • M third_party/blink/renderer/platform/wtf/text/text_codec_utf8_test.cc
    • M third_party/blink/renderer/platform/wtf/text/text_encoding.cc
    Change size: S
    Delta: 11 files changed, 18 insertions(+), 18 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44f8901768a089acf5fd2982ed7db4788847c409
    Gerrit-Change-Number: 7776030
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages