Load HLS media documents as CORS Anonymous [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
May 11, 2026, 1:11:27 PM (yesterday) May 11
to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dale Curtis . unresolved

Probably we can just always set this. For normal playbacks it doesn't really matter and this isn't part of any standard, just a feature that each UA has.

Open in Gerrit

Related details

Attention is currently required from:
  • Ted (Chromium) Meyer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia021165b75d2a23647b741bbe56e2bb38466a262
Gerrit-Change-Number: 7833059
Gerrit-PatchSet: 1
Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Comment-Date: Mon, 11 May 2026 17:10:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ted (Chromium) Meyer (Gerrit)

unread,
May 11, 2026, 7:20:02 PM (18 hours ago) May 11
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

Ted (Chromium) Meyer added 1 comment

Patchset-level comments
Dale Curtis . resolved

Probably we can just always set this. For normal playbacks it doesn't really matter and this isn't part of any standard, just a feature that each UA has.

Ted (Chromium) Meyer

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia021165b75d2a23647b741bbe56e2bb38466a262
    Gerrit-Change-Number: 7833059
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Comment-Date: Mon, 11 May 2026 23:19:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    May 11, 2026, 7:36:40 PM (18 hours ago) May 11
    to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
    Attention needed from Ted (Chromium) Meyer

    Dale Curtis voted and added 1 comment

    Votes added by Dale Curtis

    Code-Review+1

    1 comment

    Commit Message
    Line 7, Patchset 2 (Latest):Load HLS media documents as CORS Anonymous
    Dale Curtis . unresolved

    Update commit message?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ted (Chromium) Meyer
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia021165b75d2a23647b741bbe56e2bb38466a262
      Gerrit-Change-Number: 7833059
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Comment-Date: Mon, 11 May 2026 23:36:22 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dale Curtis (Gerrit)

      unread,
      May 11, 2026, 7:38:23 PM (18 hours ago) May 11
      to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
      Attention needed from Ted (Chromium) Meyer

      Dale Curtis added 1 comment

      File third_party/blink/renderer/core/html/media/media_document.cc
      Line 106, Patchset 2 (Latest): media->setAttribute(html_names::kCrossoriginAttr, AtomicString("anonymous"));
      Dale Curtis . unresolved

      Also can you double check in dev tools that this doesn't cause a pre-flight for all media documents? I forgot that might be the one down side.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ted (Chromium) Meyer
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia021165b75d2a23647b741bbe56e2bb38466a262
      Gerrit-Change-Number: 7833059
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Comment-Date: Mon, 11 May 2026 23:38:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ted (Chromium) Meyer (Gerrit)

      unread,
      May 11, 2026, 8:16:00 PM (18 hours ago) May 11
      to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

      Ted (Chromium) Meyer voted and added 2 comments

      Votes added by Ted (Chromium) Meyer

      Commit-Queue+2

      2 comments

      Commit Message
      Line 7, Patchset 2:Load HLS media documents as CORS Anonymous
      Dale Curtis . resolved

      Update commit message?

      Ted (Chromium) Meyer

      Done

      File third_party/blink/renderer/core/html/media/media_document.cc
      Line 106, Patchset 2: media->setAttribute(html_names::kCrossoriginAttr, AtomicString("anonymous"));
      Dale Curtis . resolved

      Also can you double check in dev tools that this doesn't cause a pre-flight for all media documents? I forgot that might be the one down side.

      Ted (Chromium) Meyer

      I don't see it making any preflight requests for normal mp4 videos for example.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ia021165b75d2a23647b741bbe56e2bb38466a262
        Gerrit-Change-Number: 7833059
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
        Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
        Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
        Gerrit-Comment-Date: Tue, 12 May 2026 00:15:51 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages