Use inert document when creating a sanitizer-disallowed element [chromium/src : main]
0 views
Skip to first unread message
Daniel Vogelheim (Gerrit)
Jul 31, 2026, 5:34:09 AM (21 hours ago) Jul 31
to Noam Rosenthal, Daniel Vogelheim, Code Review Nudger, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Daniel Vogelheim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Vogelheim
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Daniel Vogelheim . resolved
I like this solution, and I like the test case. Thank you!
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Jul 31, 2026, 5:39:30 AM (21 hours ago) Jul 31
to Daniel Vogelheim, Code Review Nudger, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Noam Rosenthal voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 31, 2026, 5:40:54 AM (21 hours ago) Jul 31
to Noam Rosenthal, Daniel Vogelheim, Code Review Nudger, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61659.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Jul 31, 2026, 3:56:24 PM (11 hours ago) Jul 31
to Blink W3C Test Autoroller, Daniel Vogelheim, Code Review Nudger, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Noam Rosenthal voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 31, 2026, 5:16:05 PM (9 hours ago) Jul 31
to Noam Rosenthal, Blink W3C Test Autoroller, Daniel Vogelheim, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/html/parser/html_construction_site.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Use inert document when creating a sanitizer-disallowed element
This makes it so that creation time side effects like <img onerror>
don't take effect if the element is going to be removed anyway, while
keeping the same flow for elements that are going to work the same (e.g.
scripts remain associated with this document)
Bug: 537814747
Change-Id: I4df2b57d5cb642ab83c0a53bc91f5f80af4c7562
Reviewed-by: Daniel Vogelheim <voge...@chromium.org>
Commit-Queue: Noam Rosenthal <nrose...@google.com>
Cr-Commit-Position: refs/heads/main@{#1672097}
Files:
- M third_party/blink/renderer/core/html/html_stream.cc
- M third_party/blink/renderer/core/html/parser/html_construction_site.cc
- A third_party/blink/web_tests/external/wpt/domparsing/tentative/stream-sanitizer-img-ctor.html
Change size: M
Delta: 3 files changed, 162 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Vogelheim
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 31, 2026, 6:11:23 PM (8 hours ago) Jul 31
to Chromium LUCI CQ, Noam Rosenthal, Daniel Vogelheim, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61659
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages