WebMCP: Thread execution AbortSignal to tool implementation [chromium/src : main]

0 views
Skip to first unread message

Fr (Gerrit)

unread,
Jul 30, 2026, 4:40:39 AM (2 days ago) Jul 30
to Dominic Farolino, Chromium LUCI CQ, Raphael Kubo da Costa, Kentaro Hara, chromium...@chromium.org, Khushal Sagar, android-bu...@system.gserviceaccount.com, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, ipc-securi...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org, blink-re...@chromium.org, mfoltz+wa...@chromium.org, creis...@chromium.org, aleventh...@chromium.org, jmedle...@chromium.org
Attention needed from Dominic Farolino

Fr added 3 comments

Patchset-level comments
File-level comment, Patchset 29 (Latest):
Fr . resolved

Drive-by non-formal review

File third_party/blink/renderer/core/html/forms/html_form_element.cc
Line 225, Patchset 29 (Latest): if (is_currently_running_) {
Fr . unresolved

It'd be nice to have a test for this as well

File third_party/blink/renderer/core/script_tools/model_context.cc
Line 587, Patchset 29 (Latest): return false;
Fr . unresolved

Is this intended that toolcancel event is not fired as well?

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4971bb726e0dcf29e378d5d0bdae5f0e559aee94
Gerrit-Change-Number: 8025300
Gerrit-PatchSet: 29
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-CC: Fr <beaufort...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Khushal Sagar <khusha...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 08:40:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fr (Gerrit)

unread,
Jul 30, 2026, 4:44:08 AM (2 days ago) Jul 30
to Dominic Farolino, Chromium LUCI CQ, Raphael Kubo da Costa, Kentaro Hara, chromium...@chromium.org, Khushal Sagar, android-bu...@system.gserviceaccount.com, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, ipc-securi...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org, blink-re...@chromium.org, mfoltz+wa...@chromium.org, creis...@chromium.org, aleventh...@chromium.org, jmedle...@chromium.org
Attention needed from Dominic Farolino

Fr added 1 comment

File third_party/blink/renderer/core/html/forms/html_form_element.cc
Line 224, Patchset 29 (Latest):void HTMLFormElement::HTMLFormMcpTool::CancelTool() {
Fr . unresolved
Nit:
```suggestion
void HTMLFormElement::HTMLFormMcpTool::CancelTool() {
  if (!RuntimeEnabledFeatures::WebMCPEnabled(GetExecutionContext())) {
    return;
  }
```
Gerrit-Comment-Date: Thu, 30 Jul 2026 08:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fr (Gerrit)

unread,
Jul 30, 2026, 7:49:24 AM (2 days ago) Jul 30
to Dominic Farolino, Chromium LUCI CQ, Raphael Kubo da Costa, Kentaro Hara, chromium...@chromium.org, Khushal Sagar, android-bu...@system.gserviceaccount.com, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, ipc-securi...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, mfoltz+wa...@chromium.org, blink-re...@chromium.org, mfoltz+wa...@chromium.org, creis...@chromium.org, aleventh...@chromium.org, jmedle...@chromium.org
Attention needed from Dominic Farolino

Fr added 1 comment

File third_party/blink/renderer/core/html/forms/html_form_element.cc
Line 224, Patchset 29 (Latest):void HTMLFormElement::HTMLFormMcpTool::CancelTool() {
Fr . resolved
Nit:
```suggestion
void HTMLFormElement::HTMLFormMcpTool::CancelTool() {
  if (!RuntimeEnabledFeatures::WebMCPEnabled(GetExecutionContext())) {
    return;
  }
```
Fr

NVM It's not useful in `HTMLFormElement::HTMLFormMcpTool`

Gerrit-Comment-Date: Thu, 30 Jul 2026 11:49:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fr <beaufort...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages