Fix auto-advance logic for datetime-local year field [chromium/src : main]
Abhishek Sundriyal (Gerrit)
Abhishek Sundriyal added 1 comment![]( "Open in Gerrit")
Note: I have signed the Google CLA. AUTHORS sync may still be pending,
so I uploaded using --bypass-hooks.
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Abhishek Sundriyal (Gerrit)
Abhishek Sundriyal voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Abhishek Sundriyal
- Keishi Hattori
- Mason Freed
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keishi Hattori (Gerrit)
Keishi Hattori added 1 comment![]( "Open in Gerrit")
Thank you! This is a great change. Please add a test so we never regress.
I think it should go near this test.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html;drc=eb0ec5aca0c1efd3ad22bd7cda04921001cf2222;l=214
Related details
- Abhishek Sundriyal
- Mason Freed
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Abhishek Sundriyal (Gerrit)
Abhishek Sundriyal added 1 comment![]( "Open in Gerrit")
Thank you! This is a great change. Please add a test so we never regress.
I think it should go near this test.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html;drc=eb0ec5aca0c1efd3ad22bd7cda04921001cf2222;l=214
Added the requested test near the suggested file and updated the CL.
Please take another look.
Related details
- Keishi Hattori
- Mason Freed
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keishi Hattori (Gerrit)
Keishi Hattori voted Commit-Queue+1![]( "Open in Gerrit")
- Abhishek Sundriyal
- Mason Freed
- Xiaocheng Hu
Abhishek Sundriyal (Gerrit)
Abhishek Sundriyal added 1 comment![]( "Open in Gerrit")
I’ve added a test covering this case in
third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html
and updated the CL accordingly.
I also added myself to the AUTHORS file as this is my first contribution.
Please take another look.
Related details
- Keishi Hattori
- Mason Freed
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mason Freed added 4 comments![]( "Open in Gerrit")
Thanks for the patch!
Abhishek Sundriyal <abhishe...@gmail.com>Note to self: user has signed the CLA.
keyDown('3'); // 01/01/[0203] (old bug: jumped here)Remove this comment - no need to document old bugs. Alternatively, you could change this comment to `See crbug.com/473454959`.
beginTest('Year should not auto-advance early for datetime-local',
null, null, '2020-01-01T00:00');
keyDown('0'); // [00]/dd/yyyy
keyDown('1'); // 01/[dd]/yyyy
keyDown('0'); // 01/[00]/yyyy
keyDown('1'); // 01/01/[yyyy]
keyDown('2'); // 01/01/[0002]
keyDown('0'); // 01/01/[0020]
keyDown('3'); // 01/01/[0203] (old bug: jumped here)
keyDown('0'); // 01/01/[2030] (should allow full year)
shouldBeEqualToString('input.value', '2030-01-01T00:00');
Ordinarily, we try to avoid modifying legacy js-tests. They're very old and crufty. Having said that, this one is quite large, so it seems unfair of me to ask you to refactor 250 lines of test, just to add your own. So this is ok as-is. (Future project, if you're interested: convert this to a testharness test.)
Related details
- Abhishek Sundriyal
- Keishi Hattori
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Abhishek Sundriyal (Gerrit)
Abhishek Sundriyal abandoned this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |