[HTMLParamElement] Remove IsURLParameter [chromium/src : main]
0 views
Skip to first unread message
Philip Rogers (Gerrit)
Jan 9, 2025, 9:24:09 AMJan 9
to 后江振, Mason Freed, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Mason Freed and 后江振
Philip Rogers voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Rogers
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mason Freed
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Jan 9, 2025, 11:52:54 AMJan 9
to 后江振, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Philip Rogers and 后江振
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
1 comment
Commit Message
Line 9, Patchset 1 (Latest):
The IsURLParameter function only has a declaration but no implementation,Mason Freed . unresolved
nit: can you line wrap at 72 characters?
Related details
Attention is currently required from:
- Philip Rogers
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Jan 14, 2025, 3:45:11 AMJan 14
to 后江振, Mason Freed, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Philip Rogers and 后江振
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
Related details
Attention is currently required from:
- Philip Rogers
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frédéric Wang (Gerrit)
Jan 22, 2025, 3:24:26 AMJan 22
to 后江振, Koji Ishii, Mason Freed, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Philip Rogers and 后江振
Frédéric Wang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Frédéric Wang
| Code-Review | +1 |
2 comments
Patchset-level comments
Frédéric Wang . resolved
LGTM, but I believe you only need a single reviewer for this kind of small change?
Commit Message
Line 9, Patchset 1:
The IsURLParameter function only has a declaration but no implementation,Mason Freed . unresolved
nit: can you line wrap at 72 characters?
Frédéric Wang
nit: and then no new line after the comma?
Related details
Attention is currently required from:
- Philip Rogers
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Feb 10, 2025, 11:53:41 AMFeb 10
to 后江振, Frédéric Wang, Koji Ishii, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Frédéric Wang, Koji Ishii, Philip Rogers and 后江振
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Frédéric Wang
- Koji Ishii
- Philip Rogers
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
后江振 (Gerrit)
Feb 16, 2025, 8:27:23 AMFeb 16
to Thomas Anderson, Mason Freed, Frédéric Wang, Koji Ishii, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Frédéric Wang, Koji Ishii, Philip Rogers and Thomas Anderson
后江振 added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 1:
The IsURLParameter function only has a declaration but no implementation,Mason Freed . resolved
Frédéric Wangnit: can you line wrap at 72 characters?
nit: and then no new line after the comma?
Attention is currently required from:
- Frédéric Wang
- Koji Ishii
- Philip Rogers
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Feb 18, 2025, 12:01:28 AMFeb 18
to 后江振, Thomas Anderson, Mason Freed, Frédéric Wang, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Frédéric Wang, Philip Rogers, Thomas Anderson and 后江振
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
Attention is currently required from:
- Frédéric Wang
- Philip Rogers
- Thomas Anderson
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
后江振 (Gerrit)
Feb 21, 2025, 4:24:11 AMFeb 21
to Koji Ishii, Thomas Anderson, Mason Freed, Frédéric Wang, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Frédéric Wang, Philip Rogers and Thomas Anderson
后江振 voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Frédéric Wang
- Philip Rogers
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Feb 21, 2025, 10:41:41 AMFeb 21
to 后江振, Koji Ishii, Mason Freed, Frédéric Wang, Chromium LUCI CQ, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Frédéric Wang, Philip Rogers and 后江振
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Frédéric Wang
- Philip Rogers
- 后江振
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 21, 2025, 11:35:22 AMFeb 21
to 后江振, Thomas Anderson, Koji Ishii, Mason Freed, Frédéric Wang, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[HTMLParamElement] Remove IsURLParameter
The IsURLParameter function is only declared but not implemented.
It isn't used anywhere else, so it is removed.
Change-Id: I20900c2a0e27aeeb54a45d985eeaa76051276250
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1423170}
Files:
- M third_party/blink/renderer/core/html/html_param_element.h
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Koji Ishii, +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages