Fix touch input in ListBox <select multiple> [chromium/src : main]
0 views
Skip to first unread message
Joey Arhar (Gerrit)
Sep 16, 2025, 6:31:51 PM (3 days ago) Sep 16
to Mason Freed, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Joey Arhar added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-listbox-touch.html
Line 10, Patchset 2 (Latest):
appearance:auto event handling for listbox select elements. -->Joey Arhar . unresolved
I kind of wonder if this should be an optional wpt instead of an internal wpt
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Sep 17, 2025, 5:57:08 PM (2 days ago) Sep 17
to AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Mason Freed voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-listbox-touch.html
Line 10, Patchset 2 (Latest):
appearance:auto event handling for listbox select elements. -->Joey Arhar . unresolved
I kind of wonder if this should be an optional wpt instead of an internal wpt
Mason Freed
+1 to making it optional. I'm not even sure how those are really used, but at least in that case it'll be on wpt.fyi.
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Sep 18, 2025, 2:08:51 PM (24 hours ago) Sep 18
to Mason Freed, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/wpt_internal/html/semantics/forms/the-select-element/select-listbox-touch.html
Line 10, Patchset 2 (Latest):
appearance:auto event handling for listbox select elements. -->Joey Arhar . resolved
Mason FreedI kind of wonder if this should be an optional wpt instead of an internal wpt
+1 to making it optional. I'm not even sure how those are really used, but at least in that case it'll be on wpt.fyi.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Sep 18, 2025, 4:45:23 PM (21 hours ago) Sep 18
to AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Sep 18, 2025, 4:53:27 PM (21 hours ago) Sep 18
to Mason Freed, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/54939.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Sep 18, 2025, 8:45:20 PM (17 hours ago) Sep 18
to Blink W3C Test Autoroller, Mason Freed, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 18, 2025, 9:32:48 PM (16 hours ago) Sep 18
to Blink W3C Test Autoroller, Mason Freed, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix touch input in ListBox <select multiple>
Before this patch, there was already code in ListBoxSelectType to not
deselect other options when handling a gesturetap event, which happens
when options are clicked with a touch input, which is necessary in order
to select multiple options when no keyboard is present.
When tapping the text node instead of empty space around the text,
however, other options would get deselected due to some code which
required that the event target is an Element rather than a Node. This
patch removes that check and significantly improves the usability of
<select multiple> on touch devices.
Bug: 439964654
Change-Id: I0ebfbe5243f4d6de59fbdecfbcc0b9202dfff644
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1517685}
Files:
- M third_party/blink/renderer/core/html/forms/select_type.cc
- A third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/select-listbox-touch.optional.html
Change size: M
Delta: 2 files changed, 59 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Sep 18, 2025, 11:33:53 PM (14 hours ago) Sep 18
to Chromium LUCI CQ, Mason Freed, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54939
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages