Khushal Sagar (Gerrit)

unread,

Jan 17, 2026, 8:22:02 PMJan 17

to Mason Freed, Ben Greenstein, Tom Sepez, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Ben Greenstein, Mason Freed and Tom Sepez

Khushal Sagar voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Ben Greenstein
Mason Freed
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Jan 21, 2026, 10:40:50 PMJan 21

to Khushal Sagar, Chromium LUCI CQ, Ben Greenstein, Tom Sepez, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Ben Greenstein, Khushal Sagar and Tom Sepez

Mason Freed voted and added 2 comments

Votes added by Mason Freed

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mason Freed . resolved

third_party/blink/* LGTM. I didn't review chrome/*.

File third_party/blink/renderer/core/html/forms/html_form_element.cc

Line 185, Patchset 4 (Latest): return fail(WebDocument::ScriptToolError::kInvalidInputArguments);

Mason Freed . unresolved

Since all of the `fail()` cases are `kInvalidInputArguments`, perhaps we just hard-code that and avoid passing it?

Open in Gerrit

Related details

Attention is currently required from:

Ben Greenstein
Khushal Sagar
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Khushal Sagar (Gerrit)

unread,

Jan 22, 2026, 4:04:50 PMJan 22

to Chris Harrelson, Mason Freed, Chromium LUCI CQ, Ben Greenstein, Tom Sepez, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Ben Greenstein, Chris Harrelson and Tom Sepez

Khushal Sagar voted and added 2 comments

Votes added by Khushal Sagar

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Khushal Sagar . resolved

+chris for blink/public.

File third_party/blink/renderer/core/html/forms/html_form_element.cc

Line 185, Patchset 4: return fail(WebDocument::ScriptToolError::kInvalidInputArguments);

Mason Freed . resolved

Since all of the `fail()` cases are `kInvalidInputArguments`, perhaps we just hard-code that and avoid passing it?

Khushal Sagar

Done

Open in Gerrit

Related details

Attention is currently required from:

Ben Greenstein
Chris Harrelson
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ben Greenstein (Gerrit)

unread,

Jan 22, 2026, 4:50:40 PMJan 22

to Khushal Sagar, Chris Harrelson, Mason Freed, Chromium LUCI CQ, Tom Sepez, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Chris Harrelson, Khushal Sagar and Tom Sepez

Ben Greenstein voted and added 1 comment

Votes added by Ben Greenstein

Code-Review

+1

1 comment

File chrome/test/data/actor/declarative_script_tool_cross_document.html

Line 5, Patchset 5 (Latest): tooldescription="A declarative WebMCP tool"

Ben Greenstein . unresolved

nit: Did we want to use tool-name instead of toolname?

Open in Gerrit

Related details

Attention is currently required from:

Chris Harrelson
Khushal Sagar
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ben Greenstein (Gerrit)

unread,

Jan 22, 2026, 4:59:42 PMJan 22

to Khushal Sagar, Chris Harrelson, Mason Freed, Chromium LUCI CQ, Tom Sepez, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Chris Harrelson, Khushal Sagar and Tom Sepez

Ben Greenstein voted and added 1 comment

Votes added by Ben Greenstein

Code-Review

+0

1 comment

File third_party/blink/renderer/core/script_tools/model_context.h

Line 22, Patchset 5 (Latest):class DeclarativeWebMCPTool {

Ben Greenstein . unresolved

nit: The code uses the old name, ScriptTool for imperative WebMCP. Perhaps we should use a name like HTMLElementTool?

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Harrelson (Gerrit)

unread,

Jan 22, 2026, 7:08:27 PMJan 22

to Khushal Sagar, Ben Greenstein, Mason Freed, Chromium LUCI CQ, Tom Sepez, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Khushal Sagar and Tom Sepez

Chris Harrelson voted and added 1 comment

Votes added by Chris Harrelson

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Chris Harrelson . resolved

third_party/blink/public/web/web_document.h LGTM

Open in Gerrit

Related details

Attention is currently required from:

Khushal Sagar
Tom Sepez

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

Jan 22, 2026, 7:50:23 PMJan 22

to Khushal Sagar, Chris Harrelson, Ben Greenstein, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Khushal Sagar

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Tom Sepez . resolved

Ok, I'd prefer returning an explicit status rather than overloading the presence of the string, but its not crucial.

Open in Gerrit

Related details

Attention is currently required from:

Khushal Sagar

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Khushal Sagar (Gerrit)

unread,

Jan 22, 2026, 8:28:55 PMJan 22

to Tom Sepez, Chris Harrelson, Ben Greenstein, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Ben Greenstein

Khushal Sagar voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Ben Greenstein

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Khushal Sagar (Gerrit)

unread,

Jan 22, 2026, 8:28:57 PMJan 22

to Tom Sepez, Chris Harrelson, Ben Greenstein, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Ben Greenstein

Khushal Sagar added 2 comments

File chrome/test/data/actor/declarative_script_tool_cross_document.html

Line 5, Patchset 5 (Latest): tooldescription="A declarative WebMCP tool"

Ben Greenstein . resolved

nit: Did we want to use tool-name instead of toolname?

Khushal Sagar

@mas...@chromium.org switched to toolname, some restriction about the hyphen ones being used for custom attributes.

File third_party/blink/renderer/core/script_tools/model_context.h

Line 22, Patchset 5 (Latest):class DeclarativeWebMCPTool {

Ben Greenstein . resolved

nit: The code uses the old name, ScriptTool for imperative WebMCP. Perhaps we should use a name like HTMLElementTool?

Khushal Sagar

Naming is a mess because of the mix of WebMCP and script tool. I'd like us to do a pass once the spec name is finalized. I still lean on a name which includes the feature to make it explicit which tool we're talking about. Other features are adding tools as well now (like prompt API).

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 22, 2026, 8:32:15 PMJan 22

to Khushal Sagar, Tom Sepez, Chris Harrelson, Ben Greenstein, Mason Freed, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Declarative WebMCP: Add blink -> chrome API for cross-document case

Add the API to indicate when form submission uses the default action to
trigger a navigation.

Bug: 475991228

Change-Id: Ice7c90a646a14ceb780f037ed867db0eeec45547

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7490951

Auto-Submit: Khushal Sagar <khusha...@chromium.org>

Reviewed-by: Tom Sepez <tse...@chromium.org>

Reviewed-by: Mason Freed <mas...@chromium.org>

Commit-Queue: Khushal Sagar <khusha...@chromium.org>

Reviewed-by: Chris Harrelson <chri...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1573425}

Files:

M chrome/browser/actor/browser_action_util.h
M chrome/browser/actor/tools/script_tool_browsertest.cc
M chrome/common/actor.mojom
A chrome/test/data/actor/declarative_script_tool_cross_document.html
A chrome/test/data/actor/declarative_script_tool_cross_document_result.html
M third_party/blink/public/web/web_document.h
M third_party/blink/renderer/core/html/forms/html_form_element.cc
M third_party/blink/renderer/core/html/forms/html_form_element.h
M third_party/blink/renderer/core/script_tools/model_context.cc
M third_party/blink/renderer/core/script_tools/model_context.h
M third_party/blink/renderer/core/script_tools/model_context_test.cc

Change size: M

Delta: 11 files changed, 149 insertions(+), 36 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Tom Sepez, +1 by Chris Harrelson, +0 by Ben Greenstein, +1 by Mason Freed

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Fr (Gerrit)

unread,

Jan 23, 2026, 3:58:02 AMJan 23

to Khushal Sagar, Chromium LUCI CQ, Tom Sepez, Chris Harrelson, Ben Greenstein, Mason Freed, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Khushal Sagar

Fr added 1 comment

File chrome/test/data/actor/declarative_script_tool_cross_document.html

Line 1, Patchset 6 (Latest):<!DOCTYPE html>

Fr . unresolved

From what I can see, this file is not tested in `chrome/browser/actor/tools/script_tool_browsertest.cc`. Is that intentional?

Open in Gerrit

Related details

Attention is currently required from:

Khushal Sagar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Fr (Gerrit)

unread,

Jan 26, 2026, 9:25:02 AMJan 26

to Khushal Sagar, Chromium LUCI CQ, Tom Sepez, Chris Harrelson, Ben Greenstein, Mason Freed, AyeAye, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Khushal Sagar

Fr added 1 comment

File chrome/test/data/actor/declarative_script_tool_cross_document.html

Line 1, Patchset 6 (Latest):<!DOCTYPE html>

Fr . resolved

From what I can see, this file is not tested in `chrome/browser/actor/tools/script_tool_browsertest.cc`. Is that intentional?

Fr

Nvm. I just found out it was used later in https://chromium-review.googlesource.com/c/chromium/src/+/7512307

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Declarative WebMCP: Add blink -> chrome API for cross-document case [chromium/src : main]

Khushal Sagar (Gerrit)

Khushal Sagar voted

Related details

Mason Freed (Gerrit)

Mason Freed voted and added 2 comments

Votes added by Mason Freed

2 comments

Related details

Khushal Sagar (Gerrit)

Khushal Sagar voted and added 2 comments

Votes added by Khushal Sagar

2 comments

Related details

Ben Greenstein (Gerrit)

Ben Greenstein voted and added 1 comment

Votes added by Ben Greenstein

1 comment

Related details

Ben Greenstein (Gerrit)

Ben Greenstein voted and added 1 comment

Votes added by Ben Greenstein

1 comment

Chris Harrelson (Gerrit)

Chris Harrelson voted and added 1 comment

Votes added by Chris Harrelson

1 comment

Related details

Tom Sepez (Gerrit)

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

1 comment

Related details

Khushal Sagar (Gerrit)

Khushal Sagar voted Commit-Queue+2

Related details

Khushal Sagar (Gerrit)

Khushal Sagar added 2 comments

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Fr (Gerrit)

Fr added 1 comment

Related details

Fr (Gerrit)

Fr added 1 comment