make scrollParent a function [chromium/src : main]

0 views
Skip to first unread message

Sanfeng Liao (Gerrit)

unread,
May 11, 2026, 11:18:19 AM (yesterday) May 11
to Robert Flack, Fredrik Söderquist, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Fredrik Söderquist and Robert Flack

Sanfeng Liao added 1 comment

Patchset-level comments
File-level comment, Patchset 1:
Sanfeng Liao . resolved

@fla...@chromium.org @f...@opera.com please take a look

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Robert Flack
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62fd1c3af952519bcb89e9f4f071214c53a349c0
Gerrit-Change-Number: 7835472
Gerrit-PatchSet: 1
Gerrit-Owner: Sanfeng Liao <sanfe...@gmail.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Mon, 11 May 2026 15:18:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
7:27 AM (6 hours ago) 7:27 AM
to Sanfeng Liao, Robert Flack, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Robert Flack and Sanfeng Liao

Fredrik Söderquist added 2 comments

Commit Message
Line 9, Patchset 2 (Latest):make scrollParent a function
Fredrik Söderquist . unresolved

This doesn't add much. Maybe instead say that this implements the resolution from
https://github.com/w3c/csswg-drafts/issues/12731 ?

Line 11, Patchset 2 (Latest):Bug: 483693112
Fredrik Söderquist . unresolved

This should probably also reference issue 414808394

Open in Gerrit

Related details

Attention is currently required from:
  • Robert Flack
  • Sanfeng Liao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62fd1c3af952519bcb89e9f4f071214c53a349c0
    Gerrit-Change-Number: 7835472
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sanfeng Liao <sanfe...@gmail.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Attention: Sanfeng Liao <sanfe...@gmail.com>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 May 2026 11:26:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    10:24 AM (3 hours ago) 10:24 AM
    to Sanfeng Liao, Fredrik Söderquist, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Sanfeng Liao

    Robert Flack voted and added 1 comment

    Votes added by Robert Flack

    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Robert Flack . resolved

    I think you'll also have to change the webexposed expectations:

    https://source.chromium.org/search?q=webexposed%20scrollparent&sq=

    But i can start a cq test run to flag those.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sanfeng Liao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62fd1c3af952519bcb89e9f4f071214c53a349c0
    Gerrit-Change-Number: 7835472
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sanfeng Liao <sanfe...@gmail.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Attention: Sanfeng Liao <sanfe...@gmail.com>
    Gerrit-Comment-Date: Tue, 12 May 2026 14:24:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages