[WebMCP] Add parameter schema for <input type=hidden> [chromium/src : main]

0 views
Skip to first unread message

Fr (Gerrit)

unread,
Feb 10, 2026, 10:15:15 AM (yesterday) Feb 10
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud

Fr added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
Gerrit-Change-Number: 7560695
Gerrit-PatchSet: 2
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 15:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Feb 10, 2026, 11:19:48 AM (yesterday) Feb 10
to Fr, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Fr

Anders Hartvoll Ruud added 3 comments

Commit Message
Line 8, Patchset 2 (Latest):
Anders Hartvoll Ruud . unresolved

Maybe explain that, unlike other form control elements so far, this is an _opt-in_ (and _why_).

File third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
Line 858, Patchset 2 (Latest): return !ToolParamTitleAttribute(control).empty();
Anders Hartvoll Ruud . unresolved

Maybe we should also allow these inputs if `toolparamdescription` is set?

File third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
Line 1938, Patchset 2 (Latest): }
Anders Hartvoll Ruud . unresolved

We should also add some tests which check the actual input schema?

Open in Gerrit

Related details

Attention is currently required from:
  • Fr
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
    Gerrit-Change-Number: 7560695
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fr <beaufort...@gmail.com>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Fr <beaufort...@gmail.com>
    Gerrit-Attention: Fr <beaufort...@gmail.com>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 16:19:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Fr (Gerrit)

    unread,
    Feb 10, 2026, 11:53:16 AM (yesterday) Feb 10
    to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Anders Hartvoll Ruud

    Fr added 3 comments

    Commit Message
    Line 8, Patchset 2:
    Anders Hartvoll Ruud . resolved

    Maybe explain that, unlike other form control elements so far, this is an _opt-in_ (and _why_).

    Fr

    Done

    File third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
    Line 858, Patchset 2: return !ToolParamTitleAttribute(control).empty();
    Anders Hartvoll Ruud . resolved

    Maybe we should also allow these inputs if `toolparamdescription` is set?

    Fr

    Done

    File third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
    Line 1938, Patchset 2: }
    Anders Hartvoll Ruud . resolved

    We should also add some tests which check the actual input schema?

    Fr

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Anders Hartvoll Ruud
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
      Gerrit-Change-Number: 7560695
      Gerrit-PatchSet: 4
      Gerrit-Owner: Fr <beaufort...@gmail.com>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
      Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Comment-Date: Tue, 10 Feb 2026 16:53:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Anders Hartvoll Ruud (Gerrit)

      unread,
      5:29 AM (18 hours ago) 5:29 AM
      to Fr, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
      Attention needed from Fr

      Anders Hartvoll Ruud voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fr
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
      Gerrit-Change-Number: 7560695
      Gerrit-PatchSet: 4
      Gerrit-Owner: Fr <beaufort...@gmail.com>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
      Gerrit-Attention: Fr <beaufort...@gmail.com>
      Gerrit-Comment-Date: Wed, 11 Feb 2026 10:28:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Fr (Gerrit)

      unread,
      5:30 AM (18 hours ago) 5:30 AM
      to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Fr voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
      Gerrit-Change-Number: 7560695
      Gerrit-PatchSet: 4
      Gerrit-Owner: Fr <beaufort...@gmail.com>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
      Gerrit-Comment-Date: Wed, 11 Feb 2026 10:30:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      6:44 AM (17 hours ago) 6:44 AM
      to Fr, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [WebMCP] Add parameter schema for <input type=hidden>

      Allows <input type=hidden> elements to be included in the WebMCP tool
      form schema, provided they include either a toolparamtitle or
      toolparamdescription.
      Since hidden fields are not user-facing, this requirement ensures
      developers explicitly define the field's purpose for the AI agent.
      Bug: 475972617
      Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
      Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
      Commit-Queue: Fr <beaufort...@gmail.com>
      Cr-Commit-Position: refs/heads/main@{#1583122}
      Files:
      • M third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
      • M third_party/blink/renderer/core/html/forms/form_mcp_schema.h
      • M third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
      Change size: M
      Delta: 3 files changed, 99 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2d7b5b21b5b7c8a335ba807e8140b512e3634c61
      Gerrit-Change-Number: 7560695
      Gerrit-PatchSet: 5
      Gerrit-Owner: Fr <beaufort...@gmail.com>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Fr <beaufort...@gmail.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages