Web IDL: Fix HTMLConstructor extended attribute usage #3 [chromium/src : main]

0 views
Skip to first unread message

Ho Cheung (Gerrit)

unread,
Sep 12, 2025, 10:16:12 AM (7 days ago) Sep 12
to Chromium LUCI CQ, AyeAye, dom+...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, blink-...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org
Attention needed from Joey Arhar

Ho Cheung added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aca48180f19152d81d67118d6a4b766878af01c
Gerrit-Change-Number: 6943411
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Sep 2025 14:15:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ho Cheung (Gerrit)

unread,
Sep 12, 2025, 10:16:26 AM (7 days ago) Sep 12
to Chromium LUCI CQ, AyeAye, dom+...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, blink-...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org
Attention needed from Joey Arhar

Ho Cheung voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aca48180f19152d81d67118d6a4b766878af01c
Gerrit-Change-Number: 6943411
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Sep 2025 14:16:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Sep 12, 2025, 5:55:59 PM (7 days ago) Sep 12
to Ho Cheung, Chromium LUCI CQ, AyeAye, dom+...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, blink-...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org
Attention needed from Ho Cheung

Joey Arhar voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ho Cheung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aca48180f19152d81d67118d6a4b766878af01c
Gerrit-Change-Number: 6943411
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Ho Cheung <hoch...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Sep 2025 21:55:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 12, 2025, 6:10:54 PM (7 days ago) Sep 12
to Ho Cheung, AyeAye, dom+...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, blink-...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Web IDL: Fix HTMLConstructor extended attribute usage #3

Move [HTMLConstructor] from interface declarations to constructor
operations to comply with Web IDL specification section 3.2.3.
Bug: 40683312
Change-Id: I4aca48180f19152d81d67118d6a4b766878af01c
Auto-Submit: Ho Cheung <hoch...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1515116}
Files:
  • M third_party/blink/renderer/core/html/html_meter_element.idl
  • M third_party/blink/renderer/core/html/html_mod_element.idl
  • M third_party/blink/renderer/core/html/html_object_element.idl
  • M third_party/blink/renderer/core/html/html_olist_element.idl
  • M third_party/blink/renderer/core/html/html_paragraph_element.idl
  • M third_party/blink/renderer/core/html/html_param_element.idl
  • M third_party/blink/renderer/core/html/html_picture_element.idl
  • M third_party/blink/renderer/core/html/html_pre_element.idl
  • M third_party/blink/renderer/core/html/html_progress_element.idl
  • M third_party/blink/renderer/core/html/html_quote_element.idl
  • M third_party/blink/renderer/core/html/html_script_element.idl
  • M third_party/blink/renderer/core/html/html_slot_element.idl
  • M third_party/blink/renderer/core/html/html_source_element.idl
  • M third_party/blink/renderer/core/html/html_span_element.idl
  • M third_party/blink/renderer/core/html/html_style_element.idl
  • M third_party/blink/renderer/core/html/html_table_caption_element.idl
  • M third_party/blink/renderer/core/html/html_table_cell_element.idl
  • M third_party/blink/renderer/core/html/html_table_col_element.idl
  • M third_party/blink/renderer/core/html/html_table_element.idl
  • M third_party/blink/renderer/core/html/html_table_row_element.idl
  • M third_party/blink/renderer/core/html/html_table_section_element.idl
Change size: M
Delta: 21 files changed, 41 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joey Arhar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4aca48180f19152d81d67118d6a4b766878af01c
Gerrit-Change-Number: 6943411
Gerrit-PatchSet: 2
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages