Revert "Don't expose pseudo element to web via event.target and .currentTarget" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Jun 24, 2025, 10:07:21 AMJun 24
to Daniil Sakhapov, Chromium LUCI CQ, Mason Freed, Alexis Menard, Kentaro Hara, Alex Keng, chromium...@chromium.org, Olga Gerchikov, David Bokan, AyeAye, Blink W3C Test Autoroller, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, dtapuska+...@chromium.org, feature-me...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dom+...@chromium.org, steimel+watch...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, speed-metrics...@chromium.org, hiroshig...@chromium.org, blink-revi...@chromium.org
Attention needed from Mason Freed

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia099b1357a13d517adea5f563bd5f27f3fb86743
Gerrit-Change-Number: 6663864
Gerrit-PatchSet: 1
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Jun 2025 14:07:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Jun 24, 2025, 10:07:59 AMJun 24
to Daniil Sakhapov, Rune Lillesveen, Rubber Stamper, Chromium LUCI CQ, Mason Freed, Alexis Menard, Kentaro Hara, Alex Keng, chromium...@chromium.org, Olga Gerchikov, David Bokan, AyeAye, Blink W3C Test Autoroller, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, dtapuska+...@chromium.org, feature-me...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dom+...@chromium.org, steimel+watch...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, speed-metrics...@chromium.org, hiroshig...@chromium.org, blink-revi...@chromium.org
Attention needed from Daniil Sakhapov and Mason Freed

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia099b1357a13d517adea5f563bd5f27f3fb86743
Gerrit-Change-Number: 6663864
Gerrit-PatchSet: 1
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Jun 2025 14:07:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Jun 24, 2025, 10:08:54 AMJun 24
to Rune Lillesveen, Rubber Stamper, Chromium LUCI CQ, Mason Freed, Alexis Menard, Kentaro Hara, Alex Keng, chromium...@chromium.org, Olga Gerchikov, David Bokan, AyeAye, Blink W3C Test Autoroller, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, dtapuska+...@chromium.org, feature-me...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dom+...@chromium.org, steimel+watch...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, speed-metrics...@chromium.org, hiroshig...@chromium.org, blink-revi...@chromium.org
Attention needed from Mason Freed

Daniil Sakhapov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Jun 2025 14:08:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 24, 2025, 10:50:30 AMJun 24
to Daniil Sakhapov, Rune Lillesveen, Rubber Stamper, Mason Freed, Alexis Menard, Kentaro Hara, Alex Keng, chromium...@chromium.org, Olga Gerchikov, David Bokan, AyeAye, Blink W3C Test Autoroller, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, dtapuska+...@chromium.org, feature-me...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dom+...@chromium.org, steimel+watch...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, speed-metrics...@chromium.org, hiroshig...@chromium.org, blink-revi...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Don't expose pseudo element to web via event.target and .currentTarget"

This reverts commit 45fd03eab27d2cd1cd99f78741649d6ff9a3d078.

Reason for revert: crash at prod

Bug: 420463805
Original change's description:
> Don't expose pseudo element to web via event.target and .currentTarget
>
> The only possible cases now are ::scroll-marker and ::scroll-button().
>
> Also, this CL changes internal call sites of target() to RawTarget(),
> as internally we need to work with pseudo elements.
>
> Bug: 420463805
> Change-Id: Ica69a3de925d04524cad97c8fd75657c71515d1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633705
> Reviewed-by: Mason Freed <mas...@chromium.org>
> Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1477142}
Bug: 420463805
Change-Id: Ia099b1357a13d517adea5f563bd5f27f3fb86743
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477918}
Files:
  • M third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  • M third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
  • M third_party/blink/renderer/core/dom/events/event.cc
  • M third_party/blink/renderer/core/dom/events/event.h
  • M third_party/blink/renderer/core/dom/events/event_dispatcher.cc
  • M third_party/blink/renderer/core/dom/events/event_queue.cc
  • M third_party/blink/renderer/core/dom/events/scoped_event_queue.cc
  • M third_party/blink/renderer/core/dom/node.cc
  • M third_party/blink/renderer/core/dom/scripted_animation_controller.cc
  • M third_party/blink/renderer/core/dom/scroll_button_pseudo_element.cc
  • M third_party/blink/renderer/core/dom/scroll_marker_pseudo_element.cc
  • M third_party/blink/renderer/core/editing/commands/insert_commands.cc
  • M third_party/blink/renderer/core/editing/editor.cc
  • M third_party/blink/renderer/core/editing/editor_key_bindings.cc
  • M third_party/blink/renderer/core/events/mouse_event.cc
  • M third_party/blink/renderer/core/html/forms/html_form_control_element.cc
  • M third_party/blink/renderer/core/html/forms/html_form_element.cc
  • M third_party/blink/renderer/core/html/forms/html_label_element.cc
  • M third_party/blink/renderer/core/html/forms/range_input_type.cc
  • M third_party/blink/renderer/core/html/forms/select_type.cc
  • M third_party/blink/renderer/core/html/html_anchor_element.cc
  • M third_party/blink/renderer/core/html/html_summary_element.cc
  • M third_party/blink/renderer/core/html/media/media_document.cc
  • M third_party/blink/renderer/core/input/event_handler.cc
  • M third_party/blink/renderer/core/page/context_menu_controller.cc
  • M third_party/blink/renderer/core/page/focusgroup_controller.cc
  • M third_party/blink/renderer/core/page/spatial_navigation_controller.cc
  • M third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc
  • M third_party/blink/renderer/core/timing/window_performance.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_playback_speed_list_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_track_selector_list_element.cc
  • M third_party/blink/renderer/modules/media_controls/media_controls_shared_helper.cc
  • D third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-button-event-target.html
  • D third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-marker-event-target.html
Change size: L
Delta: 36 files changed, 71 insertions(+), 257 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Rune Lillesveen, Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia099b1357a13d517adea5f563bd5f27f3fb86743
Gerrit-Change-Number: 6663864
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
Jun 24, 2025, 11:29:00 AMJun 24
to Daniil Sakhapov, Chromium LUCI CQ, Rune Lillesveen, Rubber Stamper, Mason Freed, Alexis Menard, Kentaro Hara, Alex Keng, chromium...@chromium.org, Olga Gerchikov, David Bokan, AyeAye, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, dtapuska+...@chromium.org, feature-me...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dom+...@chromium.org, steimel+watch...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kouhei...@chromium.org, speed-metrics...@chromium.org, hiroshig...@chromium.org, blink-revi...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/53354

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia099b1357a13d517adea5f563bd5f27f3fb86743
Gerrit-Change-Number: 6663864
Gerrit-PatchSet: 2
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 15:28:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages