Fenced frames: Remove mode attribute [3/N] [chromium/src : main]

Garrett Tanzer (Gerrit)

unread,

Mar 21, 2023, 2:02:44 PM3/21/23

to Dominic Farolino, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention is currently required from: Dominic Farolino.

Garrett Tanzer would like Dominic Farolino to review this change.

Fenced frames: Remove mode attribute [3/N]

Previous CLs in this chain made the `mode` attribute on
HTMLFencedFrameElement a no-op. This CL finally removes the attribute
itself.

Bug: 1347953
Change-Id: I7d7f4439bae9f575052db8b1a45873f6eb23f7cb
---
M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element.idl
M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element_test.cc
M third_party/blink/renderer/core/html/html_attribute_names.json5
M third_party/blink/renderer/core/html/keywords.json5
M third_party/blink/web_tests/wpt_internal/fenced_frame/change-src-attribute-after-config-installation-does-not-trigger-navigation.https.html
M third_party/blink/web_tests/wpt_internal/fenced_frame/config-installation-triggers-navigation-of-navigated-fenced-frame.https.html
M third_party/blink/web_tests/wpt_internal/fenced_frame/config-installation-triggers-navigation.https.html
M third_party/blink/web_tests/wpt_internal/fenced_frame/config-with-empty-url-installation-unloads-navigated-fenced-frame.https.html
8 files changed, 0 insertions(+), 17 deletions(-)

To view, visit change 4357082. To unsubscribe, or for help writing mail filters, visit settings.

Garrett Tanzer (Gerrit)

unread,

Mar 21, 2023, 2:02:49 PM3/21/23

to blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Dominic Farolino.

View Change

To view, visit change 4357082. To unsubscribe, or for help writing mail filters, visit settings.

Dominic Farolino (Gerrit)

unread,

Mar 21, 2023, 2:58:10 PM3/21/23

to Garrett Tanzer, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Garrett Tanzer.

Patch set 4:Code-Review +1

View Change

To view, visit change 4357082. To unsubscribe, or for help writing mail filters, visit settings.

Garrett Tanzer (Gerrit)

unread,

Mar 21, 2023, 3:39:32 PM3/21/23

to blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Garrett Tanzer.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 4357082. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Mar 21, 2023, 3:42:38 PM3/21/23

to Garrett Tanzer, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, Dominic Farolino, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Dominic Farolino: Looks good to me
  Garrett Tanzer: Commit

Fenced frames: Remove mode attribute [3/N]

Previous CLs in this chain made the `mode` attribute on
HTMLFencedFrameElement a no-op. This CL finally removes the attribute
itself.

Bug: 1347953
Change-Id: I7d7f4439bae9f575052db8b1a45873f6eb23f7cb

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4357082
Reviewed-by: Dominic Farolino <d...@chromium.org>
Commit-Queue: Garrett Tanzer <gta...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1120130}


---
M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element.idl
M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element_test.cc
M third_party/blink/renderer/core/html/html_attribute_names.json5
M third_party/blink/renderer/core/html/keywords.json5
M third_party/blink/web_tests/wpt_internal/fenced_frame/change-src-attribute-after-config-installation-does-not-trigger-navigation.https.html
M third_party/blink/web_tests/wpt_internal/fenced_frame/config-installation-triggers-navigation-of-navigated-fenced-frame.https.html
M third_party/blink/web_tests/wpt_internal/fenced_frame/config-installation-triggers-navigation.https.html
M third_party/blink/web_tests/wpt_internal/fenced_frame/config-with-empty-url-installation-unloads-navigated-fenced-frame.https.html
8 files changed, 0 insertions(+), 17 deletions(-)

To view, visit change 4357082. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward