overscroll: Add the requirement for the button [chromium/src : main]

0 views
Skip to first unread message

Robert Flack (Gerrit)

unread,
Jul 30, 2026, 1:14:54 PM (2 days ago) Jul 30
to Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Vladimir Levin

Robert Flack added 2 comments

File third_party/blink/renderer/core/dom/element.cc
Line 1416, Patchset 1 (Latest): if (name == html_names::kCommandforAttr) {
Robert Flack . unresolved

Can we check IsOverscrollCommand or not in this context? Where do we handle if the command changes to/from toggle-overscroll? Thinking about it, shouldn't this case be handled by HTMLElement::AttributeChanged?

Line 3736, Patchset 1 (Latest): GetDocument().MarkOverscrollCommandTargetsDirty();
Robert Flack . unresolved

Couldn't this go in the condition on line 3721 where we check if the id changed and call IdChangedForElement?

Open in Gerrit

Related details

Attention is currently required from:
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53855006a498e4703549252567257f3bb6bd2842
Gerrit-Change-Number: 8178863
Gerrit-PatchSet: 1
Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 17:14:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vladimir Levin (Gerrit)

unread,
Jul 30, 2026, 1:49:26 PM (2 days ago) Jul 30
to Chromium LUCI CQ, Robert Flack, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack

Vladimir Levin added 2 comments

File third_party/blink/renderer/core/dom/element.cc
Line 1416, Patchset 1: if (name == html_names::kCommandforAttr) {
Robert Flack . resolved

Can we check IsOverscrollCommand or not in this context? Where do we handle if the command changes to/from toggle-overscroll? Thinking about it, shouldn't this case be handled by HTMLElement::AttributeChanged?

Vladimir Levin

Done

Line 3736, Patchset 1: GetDocument().MarkOverscrollCommandTargetsDirty();
Robert Flack . resolved

Couldn't this go in the condition on line 3721 where we check if the id changed and call IdChangedForElement?

Vladimir Levin

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Robert Flack
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I53855006a498e4703549252567257f3bb6bd2842
    Gerrit-Change-Number: 8178863
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Thu, 30 Jul 2026 17:49:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Robert Flack <fla...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vladimir Levin (Gerrit)

    unread,
    Jul 30, 2026, 1:49:36 PM (2 days ago) Jul 30
    to Chromium LUCI CQ, Robert Flack, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Robert Flack

    Vladimir Levin added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Vladimir Levin . resolved

    ptal

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Flack
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I53855006a498e4703549252567257f3bb6bd2842
    Gerrit-Change-Number: 8178863
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Thu, 30 Jul 2026 17:49:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Jul 30, 2026, 2:04:56 PM (2 days ago) Jul 30
    to Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Vladimir Levin

    Robert Flack voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vladimir Levin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I53855006a498e4703549252567257f3bb6bd2842
      Gerrit-Change-Number: 8178863
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Comment-Date: Thu, 30 Jul 2026 18:04:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Vladimir Levin (Gerrit)

      unread,
      Jul 30, 2026, 2:06:51 PM (2 days ago) Jul 30
      to Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Vladimir Levin voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I53855006a498e4703549252567257f3bb6bd2842
      Gerrit-Change-Number: 8178863
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Thu, 30 Jul 2026 18:06:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 30, 2026, 3:19:30 PM (2 days ago) Jul 30
      to Vladimir Levin, Robert Flack, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      overscroll: Add the requirement for the button

      This patch restores the requirement that the button is needed to create
      an overscroll area. This is following the resolution and discussion at
      OpenUI:
      https://github.com/openui/open-ui/issues/1457#issuecomment-5061915189

      R=fla...@chromium.org
      Change-Id: I53855006a498e4703549252567257f3bb6bd2842
      Reviewed-by: Robert Flack <fla...@chromium.org>
      Commit-Queue: Vladimir Levin <vmp...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1671310}
      Files:
      • M third_party/blink/renderer/core/css/style_change_reason.cc
      • M third_party/blink/renderer/core/css/style_change_reason.h
      • M third_party/blink/renderer/core/dom/document.cc
      • M third_party/blink/renderer/core/dom/document.h
      • M third_party/blink/renderer/core/dom/element.cc
      • M third_party/blink/renderer/core/dom/element.h
      • M third_party/blink/renderer/core/dom/element_test.cc
      • M third_party/blink/renderer/core/html/html_element.cc
      • M third_party/blink/renderer/core/overscroll/overscroll_area_tracker_test.cc
      • M third_party/blink/renderer/core/paint/cull_rect_updater_test.cc
      • M third_party/blink/renderer/core/scroll/scrollable_area_test.cc
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-area-attribute.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-backdrop-click-dismiss.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-backdrop-scroll.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-backdrop.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-container-scroll-state.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-overlay-stacking.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/shadow-slot-change-crash.html
      • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/shadow-slot-change-double-lock-crash.html
      Change size: L
      Delta: 19 files changed, 315 insertions(+), 13 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Robert Flack
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I53855006a498e4703549252567257f3bb6bd2842
      Gerrit-Change-Number: 8178863
      Gerrit-PatchSet: 3
      Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages